[Bug 27261] New: PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Bug ID: 27261 Summary: PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If you check branchcode in PatronSelfRegistrationBorrowerUnwantedField and try to submit the self registration form you will get a ISE. Bug 22844 simplifies the process of selecting database columns. Bug 17364 adds the ability to allow exclusions. We can now easily exclude branchcode from PatronSelfRegistrationBorrowerUnwantedField and probably should do that/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22844, 17364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114483&action=edit Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Great :D Maybe we need some CSS on excluded fields name, grey color for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114483|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114751&action=edit Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #2)
Great :D
Maybe we need some CSS on excluded fields name, grey color for example.
I agree, I have opened Bug 27321. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 [Bug 27321] Make excluded database columns in system preferences more clearly disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch excludes the release notes| |ability to add branchcode | |to the | |PatronSelfRegistrationBorro | |werUnwantedField system | |preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114751|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116117&action=edit Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Bug 27261 depends on bug 17364, which changed state. Bug 17364 Summary: branchcode in BorrowerUnwantedField causes software error when saving patron record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org