[Bug 28475] New: Searching all headings returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Bug ID: 28475 Summary: Searching all headings returns no results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org This is caused by bug 26533. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |26533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533 [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121456&action=edit Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121456|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121457&action=edit Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121457|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121458&action=edit Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the staff interface 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :D Fixed the test plan: in the OPAC => in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121458|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121459&action=edit Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121459|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121460&action=edit Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- There is another change after this patch. After a "all headings" search, it was going back to "Search main heading ($a only)" without the patch. With the patch, it stays on "all headings". It's the only non-default tab that had this issue. I don't know why this change though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #7)
There is another change after this patch. After a "all headings" search, it was going back to "Search main heading ($a only)" without the patch. With the patch, it stays on "all headings". It's the only non-default tab that had this issue.
I don't know why this change though.
I think since we were passing an invalid index to search we couldn't match and select the correct tab on return. This behavior is the correct behavior :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- FYI Victor's SO got lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121460|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121461&action=edit Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Nick Clemens from comment #8)
I think since we were passing an invalid index to search we couldn't match and select the correct tab on return. This behavior is the correct behavior :-)
Great, thanks :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Does Bug 26533 still work after this change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It quickly tested that exact match work but it turns out I didn't new the subtleties. See bug 26533 comment 18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Test plan has a mistake : 1. Open the authorities section in the OPAC => It in is in staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Fridolin Somers from comment #15)
Test plan has a mistake :
1. Open the authorities section in the OPAC => It in is in staff interface
Oops. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Ready to backport to the new oldoldstable (20.05.x). Applied locally until getting the push rights. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #20 from wainuiwitikapark@catalyst.net.nz --- Not backported to 19.11.x Couldn't reproduce the bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org