[Bug 28419] New: addorderiso2709 untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Bug ID: 28419 Summary: addorderiso2709 untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr I feel like I'm missing something obvious, because it can't be that a whole page is not translatable... To go to this page: 1) Go to Acquisitions 2) Search for a vendor 3) Create a basket 4) Add to basket "from a new file" 5) Stage a marc file 6) Click on Add staged files to basket You should be on the addorderiso2709 page. I did ./translate update fr-CA, then using the git grep command, I searched for the string "Add orders from" which is the title of the page, and I can't find it anywhere in the po files. The string only comes out in the tt file and in the release notes files... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Caroline, which version did you test this on? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Caroline, I am not sure how this can even be possible... but I am seeing the exact same thing for de-DE in our package based installation of 20.11.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Example URL: /cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=6&basketno=25&booksellerid=8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|addorderiso2709 |Page addorderiso2709.pl is |untranslatable |untranslatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Try `gulp po:update` to update the po files. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hum, forget that. There is something wrong, indeed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121373&action=edit Bug 28419: Fix addorderiso2709.tt translatability It seems that the html tag within the TT comment breaks the translate script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It seems that this patch fixes the problem. Can you confirm please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121374&action=edit Bug 28419: Remove suspicious occurrence in opac-shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is the only other occurrence I found. I don't have time right now to fix the translate script, and it does not seem a good idea to modify it few days before the release anyway :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121374|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121376&action=edit Bug 28419: Remove suspicious occurrence in opac-shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121373|0 |1 is obsolete| | Attachment #121376|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121394&action=edit Bug 28419: Fix addorderiso2709.tt translatability It seems that the html tag within the TT comment breaks the translate script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121395&action=edit Bug 28419: Remove suspicious occurrence in opac-shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121394|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121413&action=edit Bug 28419: Fix addorderiso2709.tt translatability It seems that the html tag within the TT comment breaks the translate script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121395|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121414&action=edit Bug 28419: Remove suspicious occurrence in opac-shelves.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Well sleuthed.. works as expected and passes QA scripts.. I couldn't find any other cases with a grep/ack. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks everyone! Just for information, I noticed this on a client's 20.05 installation. So if it's backportable, it would be useful. :) Sorry I couldn't help more on this I'm swamped with client work atm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.07 released in| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Version(s)|21.05.00,20.11.07,20.05.13 |21.05.00,20.11.07,20.05.13, released in| |19.11.19 CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #20 from wainuiwitikapark@catalyst.net.nz --- Backported to 19.11.x for 19.11.19 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org