https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show patron is the |Show that a patron is the |anonymous in patrons search |anonymous in patrons search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 183063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183063&action=edit Bug 40000: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> ---

Display uses class 'circ-hlt' to show bold red text. Maybe there is a better way for that. Its is open to discussion ;)

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183063|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 183256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183256&action=edit Bug 40000: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183258&action=edit Bug 40000: (follow-up) Use badge to highlight anonymous patron I think a "warning" class is appropriate because we're warning the user that this patron should be treated differently. I trimmed to label to "Anonymous patron" because I don't think the "This is the..." is necessary for a label. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #7)

(In reply to David Nind from comment #5)

...

So maybe 'Anonymous patron' as a green badge.

I have attached an opinionated suggestion!

Looks great to me Owen! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement highlights release notes| |the anonymous patron using | |a yellow badge in patron | |search results (set using | |the AnonymousPatron system | |preference). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Fridolin Somers from comment #10)

https://getbootstrap.com/docs/4.0/components/badge/

Not that version! This one: https://getbootstrap.com/docs/5.3/components/badge/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #12)

Maybe I should change to use "Patron->is_anonymous" from Bug 40401

Do you want to make this change? Or do you like this as is? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- QA : Ah maybe "[% Koha.Preference('AnonymousPatron') %]" needs html filter ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've looked at the code and it seems we never use Koha.Preference with an | html filter. There are also other occurrence in the code close to this one, where it doesn't seem to have complained. [% IF ! open_on_row_click %] r += "<a href=\"/cgi-bin/koha/members/moremember.pl?borrowernumber=" + patron_id + "\" class=\"patron_name\" data-borrowernumber=\"" + patron_id + "\" style=\"white-space:nowrap\">" + $patron_to_html(row, { invert_name: 1, showDiffFirstname: [% Koha.Preference('ShowPatronFirstnameIfDifferentThanPreferredname') ? 1 : 0 | html %] }) + "</a>"; [% ELSE %] r += $patron_to_html(row, { invert_name: 1, showDiffFirstname: [% Koha.Preference('ShowPatronFirstnameIfDifferentThanPreferredname') ? 1 : 0 | html %] }); Patch works, nice little addition- sending this one a level higher up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183256|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193044&action=edit Bug 40000: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, back to FQA as a question in the Development channel led to some more information: https://chat.koha-community.org/koha-community/pl/wkyk1gcffbfgxysfshhb8khn3w TT vars must now be moved to a separate script tag for serialization see the tree under Bug 41324 There is also a "store" for syspref it's still not in the coding guideline, not everything is pushed yet, but this is the correct way to fix it see "addPrefs" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #21 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Fridolin Somers from comment #20)

...

see "addPrefs" Sorry I cant find it

I was just curious on the discussion on mattermost. I guess that's what it should look like f.e.: addPrefs({'anonPatronId': [% Koha.Preference('AnonymousPatron') ? 1 : 0 %]}) then later compare it via prefs.anonPatronId -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #22)

Ah but is it not a boolean pref.

And needs HTML filter no ?

addPrefs({'anonPatronId': [% Koha.Preference('AnonymousPatron') | html %]})

@Joubu? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- I've suggested on Mattermost that we start using <script type="application/json"> for storing Template::Toolkit output for Javascript. So above the Javascript <script> where you've added the logic, you could add <script id="anonymous_patron_id" type="application/json"> [% To.json(Koha.Preference('AnonymousPatron')) | $raw %] </script> You don't have to use the To.json but then you definitely need a try/catch in your JS to make sure you can handle invalid data in there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40000 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #28)

(In reply to David Cook from comment #27)

...

I've suggested on Mattermost that we start using <script type="application/json"> for storing Template::Toolkit output for Javascript.

That said, I think the QA script might flag script elements with type attributes, but we should get rid of that QA check anyway because things like <script type="module"> would be awesome to start using...

Actually no... I think they just fail if the type is application/javascript or something, so it should be fine... -- You are receiving this mail because: You are watching all bug changes.