[Bug 40782] New: Selections toolbar buttons should not be focusable when they are inactive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Bug ID: 40782 Summary: Selections toolbar buttons should not be focusable when they are inactive Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jake.deery@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org On the results page, some toolbar buttons have a disabled class, but can still be focused. This should not be possible, as it is misleading for users of a screen reader. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 186310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186310&action=edit Bug 40782: Selections toolbar checkbox now adds tabindex -1 This patch now sets tabindex to -1 if a disabled class is applied to a control, and removes it when the class evaporates. This improves accessibility by making these disabled items non-focusable. To test: a) make a search on the OPAC b) tab through the selections toolbar, notice how visually disabled items are focusable APPLY PATCH c) repeat steps a-b, notice how the elements are no longer focusable SIGN OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186310|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 186318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186318&action=edit Bug 40782: Selections toolbar checkbox now adds tabindex -1 This patch now sets tabindex to -1 if a disabled class is applied to a control, and removes it when the class evaporates. This improves accessibility by making these disabled items non-focusable. To test: a) make a search on the OPAC b) tab through the selections toolbar, notice how visually disabled items are focusable APPLY PATCH c) repeat steps a-b, notice how the elements are no longer focusable SIGN OFF Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 186319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186319&action=edit Bug 40782: (follow-up) Tidy results-list.js Tidy converts single quotes to double quotes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|oleonard@myacpl.org |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186318|0 |1 is obsolete| | Attachment #186319|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186466&action=edit Bug 40782: Selections toolbar checkbox now adds tabindex -1 This patch now sets tabindex to -1 if a disabled class is applied to a control, and removes it when the class evaporates. This improves accessibility by making these disabled items non-focusable. To test: a) make a search on the OPAC b) tab through the selections toolbar, notice how visually disabled items are focusable APPLY PATCH c) repeat steps a-b, notice how the elements are no longer focusable SIGN OFF Signed-off-by: Owen Leonard <oleonard@myacpl.org> Bug 40782: (follow-up) Tidy results-list.js Tidy converts single quotes to double quotes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Text to go in the| |The selections toolbar on release notes| |OPAC search results now | |properly manages keyboard | |focus for disabled buttons. | |Previously, visually | |disabled toolbar buttons | |(such as "Add to cart" or | |"Add to list" when no items | |were selected) could still | |receive keyboard focus, | |which was confusing for | |screen reader users. | | | |Disabled toolbar buttons | |now have `tabindex="-1"` | |applied, making them | |non-focusable until they | |become active. When items | |are selected and the | |buttons become enabled, | |they are automatically made | |focusable again. | | | |This enhancement improves | |the keyboard navigation | |experience and ensures that | |assistive technology users | |are not misled by inactive | |controls that appear to be | |interactive. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40782 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org