http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25183&action=edit Bug 11738 - Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Submit a change to multiple borrowers. The results page should also be sorted correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Regression found. To reproduce: 1/ Link a patron attribute to a patron category. 2/ On the patrons mod tools, you should see (at the bottom): Attribute: [SELECT] [CHECKBOX] [INPUT] [New] This attribute will be only applied to the patron's category "CATEGORY_CODE" With the patch, I get: Attribute: [SELECT] [CHECKBOX] [New] This input and the message have disappeared. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25196&action=edit patron attr type screen -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25198&action=edit batch mod patron screen - with patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25186|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25200&action=edit Bug 11738 [Revised] Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Test with extended patron attributes enabled. Test adding and removing varying numbers of attributes to patrons in your batch. Submit a change to multiple borrowers. The results page should also be sorted correctly. Revision: Corrected error caused by the variable number of columns in the table corresponding to varying numbers of patron attributes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25200|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25733&action=edit Bug 11738 [Revised] Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Test with extended patron attributes enabled. Test adding and removing varying numbers of attributes to patrons in your batch. Submit a change to multiple borrowers. The results page should also be sorted correctly. Revision: Corrected error caused by the variable number of columns in the table corresponding to varying numbers of patron attributes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25733|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26379&action=edit [PASSED QA] Bug 11738 [Revised] Use new DataTables include in batch patron modification template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the batch patron modification template. This patch modifies the template so that date columns are sorted using the "title-string" filter, based on the unformatted date. The DataTables configuration has also been modified to account for varying structure based on the page state. Other minor edits: Corrected capitalization. To test, go Tools -> Batch patron modification and submit a list of patrons for modification. The resulting page should be correctly sorted. Date columns should sort correctly for all dateformat system pref settings. Test with extended patron attributes enabled. Test adding and removing varying numbers of attributes to patrons in your batch. Submit a change to multiple borrowers. The results page should also be sorted correctly. Revision: Corrected error caused by the variable number of columns in the table corresponding to varying numbers of patron attributes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, works as described. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11738 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes.