[Bug 11495] New: i18n toolchain misses one instance of text "Select titles to: " in bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Bug ID: 11495 Summary: i18n toolchain misses one instance of text "Select titles to: " in bootstrap Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The translation toolchain does not pick up one instance of "Select titles to: " for translation from opac-tmpl/bootstrap/en/modules/opac-results.tt This means the text is shown in English until you click one of the checkboxes, then the javascript text is applied and it replaces the English text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24194&action=edit Bug 11495: Make "Select titles to: " translatable Fixes translation of "Select titles to: " on the Bootstrap OPAC result page. Test plan: - Update one of the po files running: perl translate update <langcode> - Verify that "Select titles to: " is only listed once for search-results.tt Apply patch - Verify addings titles to lists and cart from the result list still works as expected - Rerun the po file update - Verify the string is now listed twice for search-results.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24194|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24872&action=edit [SIGNED-OFF] Bug 11495: Make "Select titles to: " translatable Fixes translation of "Select titles to: " on the Bootstrap OPAC result page. Test plan: - Update one of the po files running: perl translate update <langcode> - Verify that "Select titles to: " is only listed once for search-results.tt Apply patch - Verify addings titles to lists and cart from the result list still works as expected - Rerun the po file update - Verify the string is now listed twice for search-results.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24921&action=edit Bug 11495: Make "Select titles to: " translatable Fixes translation of "Select titles to: " on the Bootstrap OPAC result page. Test plan: - Update one of the po files running: perl translate update <langcode> - Verify that "Select titles to: " is only listed once for search-results.tt Apply patch - Verify addings titles to lists and cart from the result list still works as expected - Rerun the po file update - Verify the string is now listed twice for search-results.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|unspecified |master QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Fridolyn: This patch would deserved to be pushed to 3.14. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 In fact it looks like a minor bug, not an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org