https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16908 Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- To recreate: 1 - Create or edit a borrower with info in Sort1 and Sort2 field, not mapped to authorized values 2 - Note this info does not display on moremember.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16908 [Bug 16908] Koha::Patrons - Remove GetSortDetails -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62859&action=edit Bug 18512 - GetAuthorisedValues.GetByCode Template plguin should return code (not empty string) if value not found To test: 1 - Create or edit a borrower with info in Sort1 and Sort2 field, not mapped to authorized values 2 - Note this info does not display on moremember.tt 3 - Apply patch 4 - Note value is passed through -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hard to say... Indeed, bug 16908 modified the behaviour, but with this patch you are going to modify the behaviour for all other AuthorisedValues.GetByCode calls. Bug 16908 did not modify the behaviour of GetByCode. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I did a git grep on 'GetByCode' - I didn't see anything that would break on the code - it will just add to the display for anything unmapped so helps root out old data and cruft that has been hidden -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62893|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62988&action=edit Bug 18512 - GetAuthorisedValues.GetByCode Template plguin should return code (not empty string) if value not found To test: 1 - Create or edit a borrower with info in Sort1 and Sort2 field, not mapped to authorized values 2 - Note this info does not display on moremember.tt 3 - Apply patch 4 - Note value is passed through Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |athieschafer@smac.edu --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- *** Bug 18180 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tests don't pass applied on 16.11.x - not pushing this, please check. Test Summary Report ------------------- t/db_dependent/Template/Plugin/AuthorisedValues.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63714&action=edit Bug 18512: Add tests 16.11.X version Remove use of build_object Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nick! These patches have been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.