[Bug 18482] New: False duplicates detected on adding a batch from a stage file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Bug ID: 18482 Summary: False duplicates detected on adding a batch from a stage file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org Created attachment 62572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62572&action=edit False duplicates detected on adding a batch from a stage file When adding a batch from a stage file with defaut matching on title/author, if a duplicate is detected, all following records treated in the batch are discarded from import even if they are not duplicates. Checking for duplicate now lies on duplinbatch value that is not reset at each loop (In the initial commit, discarding record was directly tight to FindDuplicate return). So from the point when duplinbatch is defined, all the following biblios are discarded as duplicate whatever FindDuplicate return is. This patch adds a distinct flag. Test plan : You need the 2 test attached files TestFile1.mrc and TestFile2.elc (TestFile1 includes only the title "Amilec ou La graine d'hommes" that is also included in TestFile2). To save them, right click on bugzilla link and do 'Save target as'. 1) go to “Stage MARC records for import” page, upload TestFile1, select iso 5426 encoding and stage it for Import. 2) Click again 'Stage MARC records' button and do the same for TestFile2.elc 3) Go to acquisitions module, enter a vendor name and create a new basket. 4) From your basket, click 'Add to basket', then in the “Add order to basket window/block” choose 'From a staged file'. 5) Then click ‘Add orders' button on File1. 6) Leave default matching on Title/Author, tick the title, add a location in second tag and fund in third tag and Save. 7) Make sure that the new record is indexed (depending to your indexing system and test platform). 8) Redo step 4 and step 5 this time on TestFile2. 9) Leave default matching on Title/Author, select all titles, add a location in second tag, a fund in third tag and Save. 10) A warning is displayed saying that no records have been imported because they all match an existing record. The “Import all” block is not any more visible. 11) Apply the patch 12) Refresh 'Add orders from' page (File2) and redo step 9 13) You are redirected to the basket page : a warning is displayed to tell you that some duplicates have been found and skipped. There's a link on the warning throughout you can go back to the list of remaining records and treat them individually if necesary. 14) Click the link : you fall upon the only title that is a very duplicate (record of TestFile1). 15) Be happy 16) Sign off Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 62573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62573&action=edit TestFile1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 62574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62574&action=edit TestFile2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62572|0 |1 is obsolete| | --- Comment #3 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 62575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62575&action=edit Bug 18482 False duplicates detected on adding a batch from a stage file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- This patch must be added from version 3.22.13 and higher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12074, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16493 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62575|0 |1 is obsolete| | --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62581&action=edit Bug 18482 False duplicates detected on adding a batch from a stage file When adding a batch from a stage file with defaut matching on title/author, if a duplicate is detected, all following records treated in the batch are discarded from import even if they are not duplicates Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12074 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |koha@univ-lyon3.fr |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 [Bug 12074] Filter duplicates when adding a full batch from a staged file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62581|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62621&action=edit Bug 18482 False duplicates detected on adding a batch from a stage file When adding a batch from a stage file with defaut matching on title/author, if a duplicate is detected, all following records treated in the batch are discarded from import even if they are not duplicates Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Olivier! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a conflict in acqui/addorderiso2709.pl when applying this to 16.11.x, can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 --- Comment #9 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 63579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63579&action=edit Bug 18482 False duplicates detected on adding a batch [16.11.x] add specific patch for 16.11.x. Just remove the biblio_count line that seems to been added more lately -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the rebased patch! This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org