[Bug 36328] New: C4::Scrubber should allow more html tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Bug ID: 36328 Summary: C4::Scrubber should allow more html tags Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Should not we allow span, div, etc. as well as existing "br b i em big small strong"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163192&action=edit Bug 36328: Add p span div to Scrubber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163193&action=edit Bug 36328: Add test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19613 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I think it probably makes sense to have a few different profiles. For the "comment" scrubber, we probably want to keep it fairly minimal I think. Whereas "borrowernotes" and "opacnote" could have more elaborate structures. Bug 31934 has a profile with a fairly comprehensive list (although I wouldn't use it for "borrowernotes" or "opacnote"). I think an argument could be made for also including headings, table elements, fieldset/legend, ul/ol/li. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We could really do with getting bug 31934 moving again I think.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163497&action=edit Bug 36328: Add a separate 'note' profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Would this patch work for you? Here I am trying to tackle down bug 19613. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)
Would this patch work for you? Here I am trying to tackle down bug 19613.
Looks good. I'll look at signing this off pronto... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163192|0 |1 is obsolete| | --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Created attachment 163582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163582&action=edit Bug 36328: Add p span div to Scrubber Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163193|0 |1 is obsolete| | --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Created attachment 163583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163583&action=edit Bug 36328: Add test Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163497|0 |1 is obsolete| | --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 163584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163584&action=edit Bug 36328: Add a separate 'note' profile Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163582|0 |1 is obsolete| | Attachment #163583|0 |1 is obsolete| | Attachment #163584|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164206&action=edit Bug 36328: Add p span div to Scrubber Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164207&action=edit Bug 36328: Add test Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164208&action=edit Bug 36328: Add a separate 'note' profile Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164209&action=edit Bug 36328: (QA follow-up) Expand tests and reorder elements to clarify differences Also tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Scrubber should allow |C4::Scrubber should allow |more html tags |more HTML tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #16 from wainuiwitikapark@catalyst.net.nz --- Applied to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.05,23.05.11, released in| |22.05.21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- In hindsight, perhaps we should've allowed "id" and "class" attributes through for the "note" profile to allow people to easily add styling via CSS... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38488 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #17)
In hindsight, perhaps we should've allowed "id" and "class" attributes through for the "note" profile to allow people to easily add styling via CSS...
Yes - new bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 164208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164208 Bug 36328: Add a separate 'note' profile Review of attachment 164208: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36328&attachment=164208) ----------------------------------------------------------------- ::: C4/Scrubber.pm @@ +50,4 @@
rules => exists $settings->{rules} ? $settings->{rules} : [], default => exists $settings->{default} ? $settings->{default} : [ 0 => { '*' => 0 } ], comment => exists $settings->{comment} ? $settings->{comment} : 0, + note => exists $settings->{note} ? $settings->{note} : 0,
This line actually looks like it doesn't do anything. I'll open a bug to remove it as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #18)
(In reply to David Cook from comment #17)
In hindsight, perhaps we should've allowed "id" and "class" attributes through for the "note" profile to allow people to easily add styling via CSS...
Yes - new bug?
Bug 38498 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38498 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38499 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38499 [Bug 38499] Remove unused "note" argument to HTML::Scrubber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm also going to add a bug asking for ul/ol and li. We see those used quite often and I can't see a security issue with those? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40079 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Added bug 40079 for ol/ul and li tags Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40079 [Bug 40079] C4::Scrubber should allow for list (ul/ol and li) HTML tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #23 from David Nind <david@davidnind.com> --- Enhancement - the manual needs updating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |andrew.auld@openfifth.co.uk Resolution|--- |FIXED --- Comment #24 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Architectural change - doesn't need to be documented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42047 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org