[Bug 12160] New: Rename intranetuserjs to IntranetUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Bug ID: 12160 Summary: Rename intranetuserjs to IntranetUserJS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com ... to match IntranetUserCSS The same should be done with opacuserjs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10327 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38563&action=edit Bug 12160: Rename intranetuserjs with IntranetUserJS To match IntranetUserCSS, intranetuserjs should be renamed IntranetUserJS. Test plan: 1/ Be sure there is no occurrence of intranetuserjs 2/ Confirm the pref still works as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38564&action=edit Bug 12160: Rename opacuserjs with OpacUserJS Test plan: Same as previous patch for opacuserjs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename intranetuserjs to |Rename |IntranetUserJS |[intranet|opac]userjs to | |[Intranet|OPAC]UserJS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename |Rename |[intranet|opac]userjs to |[intranet|opac]userjs to |[Intranet|OPAC]UserJS |[Intranet|Opac]UserJS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename |Rename |[intranet|opac]userjs to |[intranet|opac]userjs to |[Intranet|Opac]UserJS |[Intranet|OPAC]UserJS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38564|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38565&action=edit Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38565|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38566&action=edit Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Here's my checking. Looks good. mtompset@debian:~/kohaclone$ grep -i intranetuserjs `git grep -l -i intranetuserjs | grep -v "\.po"` C4/Auth.pm: intranetuserjs => C4::Context->preference("intranetuserjs"), C4/Auth.pm: intranetuserjs => C4::Context->preference("intranetuserjs"), installer/data/mysql/sysprefs.sql:('intranetuserjs','','70|10','Custom javascript for inclusion in Intranet','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='intranetuserjs'"); installer/data/mysql/updatedatabase.pl: my $intranetuserjs = C4::Context->preference('intranetuserjs'); installer/data/mysql/updatedatabase.pl: if ($intranetuserjs and $intranetuserjs eq $bad_value) { installer/data/mysql/updatedatabase.pl:WHERE variable = 'intranetuserjs' installer/data/mysql/updatedatabase.pl: print "Upgrade to $DBversion done (removed bogus intranetuserjs syspref)\n"; koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% IF ( intranetuserjs ) %] koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: [% intranetuserjs %] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref: - pref: intranetuserjs koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[% IF ( intranetuserjs ) %] koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt: [% intranetuserjs %] [SNIP] mtompset@debian:~/kohaclone$ grep -i opacuserjs `git grep -l -i opacuserjs | grep -v "\.po"` C4/Auth.pm: opacuserjs => C4::Context->preference("opacuserjs"), C4/Auth.pm: opacuserjs => C4::Context->preference("opacuserjs"), installer/data/mysql/sysprefs.sql:('opacuserjs','','70|10','Define custom javascript for inclusion in OPAC','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='opacuserjs'"); koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - pref: opacuserjs koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( opacuserjs ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc: [% opacuserjs %] [SNIP] mtompset@debian:~/kohaclone$ git bz apply 12160 Bug 12160 - Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS 38563 - Bug 12160: Rename intranetuserjs with IntranetUserJS 38566 - Bug 12160: Rename opacuserjs with OPACUserJS Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12160: Rename intranetuserjs with IntranetUserJS Applying: Bug 12160: Rename opacuserjs with OPACUserJS mtompset@debian:~/kohaclone$ grep -i intranetuserjs `git grep -l -i intranetuserjs | grep -v "\.po"` C4/Auth.pm: IntranetUserJS => C4::Context->preference("IntranetUserJS"), C4/Auth.pm: IntranetUserJS => C4::Context->preference("IntranetUserJS"), installer/data/mysql/atomicupdate/Bug_12160-Rename_pref_intranetuserjs_to_IntranetUserJS.sql:UPDATE systempreferences SET variable="IntranetUserJS" where variable="intranetuserjs" installer/data/mysql/sysprefs.sql:('IntranetUserJS','','70|10','Custom javascript for inclusion in Intranet','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='intranetuserjs'"); installer/data/mysql/updatedatabase.pl: my $intranetuserjs = C4::Context->preference('intranetuserjs'); installer/data/mysql/updatedatabase.pl: if ($intranetuserjs and $intranetuserjs eq $bad_value) { installer/data/mysql/updatedatabase.pl:WHERE variable = 'intranetuserjs' installer/data/mysql/updatedatabase.pl: print "Upgrade to $DBversion done (removed bogus intranetuserjs syspref)\n"; koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% IF ( IntranetUserJS ) %] koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: [% IntranetUserJS %] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref: - pref: IntranetUserJS koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[% IF ( IntranetUserJS ) %] koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt: [% IntranetUserJS %] [SNIP] mtompset@debian:~/kohaclone$ grep -i opacuserjs `git grep -l -i opacuserjs | grep -v "\.po"` C4/Auth.pm: OPACUserJS => C4::Context->preference("OPACUserJS"), C4/Auth.pm: OPACUserJS => C4::Context->preference("OPACUserJS"), installer/data/mysql/atomicupdate/Bug_12160-Rename_pref_opacuserjs_to_OPACUserJS.sql:UPDATE systempreferences SET variable="OPACUserJS" where variable="opacuserjs" installer/data/mysql/sysprefs.sql:('OPACUserJS','','70|10','Define custom javascript for inclusion in OPAC','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='opacuserjs'"); koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - pref: OPACUserJS koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( OPACUserJS ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc: [% OPACUserJS %] [SNIP] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38563|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38742&action=edit Bug 12160: Rename intranetuserjs with IntranetUserJS To match IntranetUserCSS, intranetuserjs should be renamed IntranetUserJS. Test plan: 1/ Be sure there is no occurrence of intranetuserjs 2/ Confirm the pref still works as before Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the person unaware of case insensitivity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38566|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38743&action=edit Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the programmer unaware of case-insensitivity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38742|0 |1 is obsolete| | Attachment #38743|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38774&action=edit [PASSED QA] Bug 12160: Rename intranetuserjs with IntranetUserJS To match IntranetUserCSS, intranetuserjs should be renamed IntranetUserJS. Test plan: 1/ Be sure there is no occurrence of intranetuserjs 2/ Confirm the pref still works as before Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the person unaware of case insensitivity. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38775&action=edit [PASSED QA] Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the programmer unaware of case-insensitivity. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Consistency, YAY! Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org