[Bug 12416] New: DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Bug ID: 12416 Summary: DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: yohann.dufour@biblibre.com QA Contact: gmcharlt@gmail.com The subroutine DelUniqueDebarment (Koha/Borrower/Debarments.pm) is not tested in t/db_dependent/Borrower_Debarments.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |yohann.dufour@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 --- Comment #1 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 28834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28834&action=edit Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested test plan: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.46 cusr 0.08 csys = 1.58 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Yohann, Please prefer the use of "is" instead of "ok". Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Adding unit tests is far from being 'minor' :) Switch the severity back to normal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28834|0 |1 is obsolete| | --- Comment #4 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 28859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28859&action=edit Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 --- Comment #5 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 28860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28860&action=edit Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' The use of the subroutine 'is' is prefered over the subroutine 'is' To test: execute the commande prove t/db_dependent/Borrower_Debarments.t To command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 --- Comment #6 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 28861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28861&action=edit Bug 12416: add new tests of DelUniqueDebarment The subroutine DelUniqueDebarment was not enough tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28859|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29139&action=edit [SIGNED-OFF] Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28860|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29140&action=edit [SIGNED-OFF] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' The use of the subroutine 'is' is prefered over the subroutine 'is' To test: execute the commande prove t/db_dependent/Borrower_Debarments.t To command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28861|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29141&action=edit [SIGNED-OFF] Bug 12416: add new tests of DelUniqueDebarment The subroutine DelUniqueDebarment was not enough tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All 31 test pass, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29139|0 |1 is obsolete| | Attachment #29140|0 |1 is obsolete| | Attachment #29141|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29148&action=edit [PASSED QA] Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29149&action=edit [PASSED QA] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' The use of the subroutine 'is' is prefered over the subroutine 'is' To test: execute the commande prove t/db_dependent/Borrower_Debarments.t To command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29150&action=edit [PASSED QA] Bug 12416: add new tests of DelUniqueDebarment The subroutine DelUniqueDebarment was not enough tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All 31 test pass, no koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org