[Bug 12393] New: OverDrive does not depend on SSL modules for LWP, causing searches to fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Bug ID: 12393 Summary: OverDrive does not depend on SSL modules for LWP, causing searches to fail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha needs to list IO::Socket::SSL and Crypt::SSLeay as dependencies; if these modules are not installed, the OverDrive code cannot get an authentication token over SSL. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Misspoke, seems only IO::Socket::SSL is required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 28751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28751&action=edit Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28751|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 28961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28961&action=edit Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28961|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29055&action=edit [SIGNED-OFF] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29055|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29061&action=edit [PASSED QA] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jesse! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org