[Bug 42033] New: Add diff support to patron restriction and circ message action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Bug ID: 42033 Summary: Add diff support to patron restriction and circ message action logs Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Blocks: 37940 Several MEMBERS action log calls in Koha do not pass the $original parameter to logaction(), so no structured diff is generated in the action_logs.diff column. Affected calls: 1. Koha/Patron/Debarments.pm - CREATE_RESTRICTION (~line 89): logaction( "MEMBERS", "CREATE_RESTRICTION", $borrowernumber, $restriction ) (no $original; $restriction hashref is the new state) 2. Koha/Patron/Debarments.pm - DELETE_RESTRICTION (~line 113): logaction( "MEMBERS", "DELETE_RESTRICTION", $borrowernumber, $restriction ) (no $original; $restriction hashref is the state being deleted) 3. Koha/Patron/Message.pm - MODCIRCMESSAGE (~line 58): C4::Log::logaction( "MEMBERS", "MODCIRCMESSAGE", $self->borrowernumber, $self->message ) (passes new message text; should also pass original for diff) 4. Koha/Patron/Message.pm - ADDCIRCMESSAGE (~line 60): C4::Log::logaction( "MEMBERS", "ADDCIRCMESSAGE", $self->borrowernumber, $self->message ) 5. Koha/Patron/Message.pm - DELCIRCMESSAGE (~line 74): C4::Log::logaction( "MEMBERS", "DELCIRCMESSAGE", $self->borrowernumber, $self->message ) This bug covers updating these calls to pass structured data so the diff mechanism can generate proper before/after comparisons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940 [Bug 37940] [OMNIBUS] All modification logged via action logs should include original to create JSON diff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Comma delimited| |Open Fifth list of Sponsors| | Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 --- Comment #1 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 200909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200909&action=edit Bug 42033: Add action log diffs for restrictions and messages This patch ensures that the diffs for patron restrictions and messages appear in the action log. It widens logaction's detection of create/delete actions, and passes the original version of the respective models in for diffing. Test plan: 1. In one tab, open Tools > Log Viewer, and click "Submit" to load a complete list of log entries. 2. Enable the "Diff" column for log entries. 3. In another tab, navigate to a patron's circulation page (you can click their barcode from patron search). 4. Click "Add message", and enter any message for the patron. 5. On the patron page, find the message, and edit the text to something different. 6. On the patron page, find the message, and delete it. 7. Refresh the log results page. 8. Verify there are three log entries for creating, editing, and deleting the message. Each should include a diff. 9. On the patron page, click the "Restrictions" tab near the bottom, and add a manual restriction with any text. 10. On the patron page, click the "Restrictions" tab near the bottom, and delete the manual restriction you just added. 11. Refresh the log results page. 12. Verify there is a log entry for both creating and deleting the restriction, each including a diff. 13. Under Administration > Circulation and fine rules, ensure "Suspension in days" is set to a non-zero value. 14. On the patron page, check out an item to the patron, setting the due date to around a year ago. You'll need to confirm this due date. 15. Check the item back in. Verify the patron is suspended as a result. 16. Bypass the suspension restriction and check out an item to the patron, setting the due date to around _two_ years ago. 17. Check the item back in. Verify the patron's suspension has increased. 18. Refresh the log results page. 19. Verify there are two log entries for the creation and updating of the suspension restriction. Each should have a displayed diff. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 200935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200935&action=edit Bug 42033: Add action log diffs for restrictions and messages This patch ensures that the diffs for patron restrictions and messages appear in the action log. It widens logaction's detection of create/delete actions, and passes the original version of the respective models in for diffing. Test plan: 1. In one tab, open Tools > Log Viewer, and click "Submit" to load a complete list of log entries. 2. Enable the "Diff" column for log entries. 3. In another tab, navigate to a patron's circulation page (you can click their barcode from patron search). 4. Click "Add message", and enter any message for the patron. 5. On the patron page, find the message, and edit the text to something different. 6. On the patron page, find the message, and delete it. 7. Refresh the log results page. 8. Verify there are three log entries for creating, editing, and deleting the message. Each should include a diff. 9. On the patron page, click the "Restrictions" tab near the bottom, and add a manual restriction with any text. 10. On the patron page, click the "Restrictions" tab near the bottom, and delete the manual restriction you just added. 11. Refresh the log results page. 12. Verify there is a log entry for both creating and deleting the restriction, each including a diff. 13. Under Administration > Circulation and fine rules, ensure "Suspension in days" is set to a non-zero value. 14. On the patron page, check out an item to the patron, setting the due date to around a year ago. You'll need to confirm this due date. 15. Check the item back in. Verify the patron is suspended as a result. 16. Bypass the suspension restriction and check out an item to the patron, setting the due date to around _two_ years ago. 17. Check the item back in. Verify the patron's suspension has increased. 18. Refresh the log results page. 19. Verify there are two log entries for the creation and updating of the suspension restriction. Each should have a displayed diff. Sponsored-by: Open Fifth Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds diffs release notes| |to the log viewer for | |patron restriction and | |message actions. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200935|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 --- Comment #3 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 206705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206705&action=edit Bug 42033: Add action log diffs for restrictions and messages This patch ensures that the diffs for patron restrictions and messages appear in the action log. It widens logaction's detection of create/delete actions, and passes the original version of the respective models in for diffing. Test plan: 1. In one tab, open Tools > Log Viewer, and click "Submit" to load a complete list of log entries. 2. Enable the "Diff" column for log entries. 3. In another tab, navigate to a patron's circulation page (you can click their barcode from patron search). 4. Click "Add message", and enter any message for the patron. 5. On the patron page, find the message, and edit the text to something different. 6. On the patron page, find the message, and delete it. 7. Refresh the log results page. 8. Verify there are three log entries for creating, editing, and deleting the message. Each should include a diff. 9. On the patron page, click the "Restrictions" tab near the bottom, and add a manual restriction with any text. 10. On the patron page, click the "Restrictions" tab near the bottom, and delete the manual restriction you just added. 11. Refresh the log results page. 12. Verify there is a log entry for both creating and deleting the restriction, each including a diff. 13. Under Administration > Circulation and fine rules, ensure "Suspension in days" is set to a non-zero value. 14. On the patron page, check out an item to the patron, setting the due date to around a year ago. You'll need to confirm this due date. 15. Check the item back in. Verify the patron is suspended as a result. 16. Bypass the suspension restriction and check out an item to the patron, setting the due date to around _two_ years ago. 17. Check the item back in. Verify the patron's suspension has increased. 18. Refresh the log results page. 19. Verify there are two log entries for the creation and updating of the suspension restriction. Each should have a displayed diff. Sponsored-by: Open Fifth Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org