https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42033 Bug ID: 42033 Summary: Add diff support to patron restriction and circ message action logs Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Blocks: 37940 Several MEMBERS action log calls in Koha do not pass the $original parameter to logaction(), so no structured diff is generated in the action_logs.diff column. Affected calls: 1. Koha/Patron/Debarments.pm - CREATE_RESTRICTION (~line 89): logaction( "MEMBERS", "CREATE_RESTRICTION", $borrowernumber, $restriction ) (no $original; $restriction hashref is the new state) 2. Koha/Patron/Debarments.pm - DELETE_RESTRICTION (~line 113): logaction( "MEMBERS", "DELETE_RESTRICTION", $borrowernumber, $restriction ) (no $original; $restriction hashref is the state being deleted) 3. Koha/Patron/Message.pm - MODCIRCMESSAGE (~line 58): C4::Log::logaction( "MEMBERS", "MODCIRCMESSAGE", $self->borrowernumber, $self->message ) (passes new message text; should also pass original for diff) 4. Koha/Patron/Message.pm - ADDCIRCMESSAGE (~line 60): C4::Log::logaction( "MEMBERS", "ADDCIRCMESSAGE", $self->borrowernumber, $self->message ) 5. Koha/Patron/Message.pm - DELCIRCMESSAGE (~line 74): C4::Log::logaction( "MEMBERS", "DELCIRCMESSAGE", $self->borrowernumber, $self->message ) This bug covers updating these calls to pass structured data so the diff mechanism can generate proper before/after comparisons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940 [Bug 37940] [OMNIBUS] All modification logged via action logs should include original to create JSON diff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.