[Bug 42919] New: Suggestion duplicate warning erases suggestion info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Bug ID: 42919 Summary: Suggestion duplicate warning erases suggestion info Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To recreate: 1. Make a suggestion that will trigger a duplicate warning, in KTD I like "Clothes, clothes, clothes, music, music, music, boys, boys, boys". 2. Fill out some other details, like notes and public notes. 2. The warning says "Click on "Confirm your suggestion" to ignore this message." 3. Notice none of the details are still there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 42940 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- We are running into this on 25.11.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 [Bug 39721] Remove GetSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com, | |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|baptiste.wojtkowski@biblibr |Laura.escamilla@bywatersolu |e.com |tions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201300&action=edit Bug 42919: Retain suggestion form values when duplicate warning is shown To test: 1. Make a suggestion that will trigger a duplicate warning, in KTD I like "Clothes, clothes, clothes, music, music, music, boys, boys, boys". 2. Fill out some other details, like notes and public notes. 3. The warning says "Click on "Confirm your suggestion" to ignore this message." 4. Notice none of the details are still there. 5. Apply the patch 6. Repeat steps 1-3. Notice that the details remain now after you get the warning message. 7. Submit the form to ensure all details are saved correctly. 8. Sign off and have a lovely day. :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 201303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201303&action=edit Bug 42919: Retain suggestion form values when duplicate warning is shown To test: 1. Make a suggestion that will trigger a duplicate warning, in KTD I like "Clothes, clothes, clothes, music, music, music, boys, boys, boys". 2. Fill out some other details, like notes and public notes. 3. The warning says "Click on "Confirm your suggestion" to ignore this message." 4. Notice none of the details are still there. 5. Apply the patch 6. Repeat steps 1-3. Notice that the details remain now after you get the warning message. 7. Submit the form to ensure all details are saved correctly. 8. Sign off and have a lovely day. :D Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- I tried testing on Biblibre sandbox. I tested without patch, and then I applied patch and I see no change. I even restarted services, but still no change with the patch. I don't think the patch applied properly. I then deleted the sandbox and created a new one twice, with the patch on creation, and both times the sandbox failed with this message in the provision log each time: TASK [Apply bug 42919 via git-bz in docker container] ************************** fatal: [localhost -> koha-but42919]: FAILED! => {"changed": true, "cmd": "koha-shell -c 'cd /kohadevbox/koha && yes | git bz apply 42919' but42919", "delta": "0:00:30.897910", "end": "2026-06-30 18:16:21.652962", "msg": "non-zero return code", "rc": 1, "start": "2026-06-30 18:15:50.755052", "stderr": "Error: Login failed: 500 Can't connect to bugs.koha-community.org:443 (Connection timed out)", "stderr_lines": ["Error: Login failed: 500 Can't connect to bugs.koha-community.org:443 (Connection timed out)"], "stdout": "", "stdout_lines": []} PLAY RECAP ********************************************************************* localhost : ok=26 changed=16 unreachable=0 failed=1 skipped=5 rescued=0 ignored=0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- concerning the second message it looks like it is a connectivity issue between Sandboxes and Bugzilla :) It might have affected your first test also. I'll try and reproduce once a sandbox is available -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42919 snewell@hmcpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snewell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org