[Bug 43046] New: Checkbox labels in Currencies and EDI accounts have unnecessary colons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Bug ID: 43046 Summary: Checkbox labels in Currencies and EDI accounts have unnecessary colons Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Remove unnecessary colons from checkbox labels when adding/editing currencies and EDI accounts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kbecker@jcls.org --- Comment #4 from Kris <kbecker@jcls.org> --- My second patch, woo! Works well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 --- Comment #3 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 201825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201825&action=edit Bug 43046: Checkbox labels in Currencies and EDI accounts have unnecessary colons Removes unnecessary colons when adding currencies and edi accounts. 1. Enable EDIFACT syspref 2. Navigate to Admin > Currencies.. > New currency 3. Note unnecessary colons after checkbox labels 4. Navigate to Admin > EDI accounts > New account 5. Note unnecessary colons after checkbox labels 6. Apply patch 7. Repeat steps 2 and 4, note colons have been removed Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 201826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201826&action=edit Bug 43046: Checkbox labels in Currencies and EDI accounts have unnecessary colons Removes unnecessary colons when adding currencies and edi accounts. 1. Enable EDIFACT syspref 2. Navigate to Admin > Currencies.. > New currency 3. Note unnecessary colons after checkbox labels 4. Navigate to Admin > EDI accounts > New account 5. Note unnecessary colons after checkbox labels 6. Apply patch 7. Repeat steps 2 and 4, note colons have been removed Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jrobb@sekls.org Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Jason Robb <jrobb@sekls.org> --- 1. Enable EDIFACT syspref 2. Navigate to Admin > Currencies.. > New currency 3. Note unnecessary colons after checkbox labels 4. Navigate to Admin > EDI accounts > New account 5. Note unnecessary colons after checkbox labels 6. Apply patch 7. Repeat steps 2 and 4, note colons have been removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 --- Comment #2 from Jason Robb <jrobb@sekls.org> --- Created attachment 201824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201824&action=edit Bug 43046: Checkbox labels in Currencies and EDI accounts have unnecessary colons Removes unnecessary colons when adding currencies and edi accounts. 1. Enable EDIFACT syspref 2. Navigate to Admin > Currencies.. > New currency 3. Note unnecessary colons after checkbox labels 4. Navigate to Admin > EDI accounts > New account 5. Note unnecessary colons after checkbox labels 6. Apply patch 7. Repeat steps 2 and 4, note colons have been removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43046 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org