http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky@gmail.com --- Comment #1 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 36784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36784&action=edit RDA: 246 field changes in XSLT -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #2 from Winona Salesky <wsalesky@gmail.com> --- Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 246 4) Perform an opac search that would show the record in the search results 5) Note the fields uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. Change has been made to results view and detail view. 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- (In reply to Nick Clemens from comment #3)

Outside the scope of this change, but if I had my druthers:

246 2nd indicator specifies type of other title, would be nice to display that when 1st indicator 1. Probab;y it would go into brackets like relator terms and would be overridden by subfield i

That out of the way, works as described and will sign off momentarily

I think that will be easy to add after the fact - but do agree! Nicole -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #7 from Winona Salesky <wsalesky@gmail.com> --- Should this become a new issue? -Winona (In reply to rgravel from comment #6)

I think that sounds like a great idea, Nick.

One thing to keep in mind is that the second indicator isn't *always* coded; occasionally it's left blank and the type of other title isn't specified. So, I suspect you'd have to tell the xslt what to do in that case.

(In reply to Nick Clemens from comment #3)

...

Outside the scope of this change, but if I had my druthers:

246 2nd indicator specifies type of other title, would be nice to display that when 1st indicator 1. Probab;y it would go into brackets like relator terms and would be overridden by subfield i

That out of the way, works as described and will sign off momentarily

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #9 from Winona Salesky <wsalesky@gmail.com> --- I think I can add this without to much of a problem. Let me just clarify the rules: Label should remain "Other title:" With value indicated by ind2 in brackets after title? Or Label should be generated based on value of ind2? Also, does $i override ind2? Thanks! -Winona (In reply to rgravel from comment #8)

If it's not easy to incorporate into these changes and if Nicole thinks this is something we can tackle later, then I'd say no.

I'm about to put in a ticket to explore a development for dynamic display of 264s, which would similarly read the second indicator and change the label; these two things seem very related, so I can add this to the ticket to see if they might be better handled together.

(In reply to Winona Salesky from comment #7)

...

Should this become a new issue?

-Winona

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37249|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38087&action=edit [PASSED QA] Bug 13386 - Added separator to full and brief display. This patch adds a separator | to the full and brief displays in the staff and OPAC views. Separator wrapped with span clas=separator | To test: * Search the opac * Click the title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client http://bugs.koha-community.org/show_bug.cgi?id=13386 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14054 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.