http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #4 from Nick Clemens <nick@quecheelibrary.org> --- Separation and display look good so signing off, but I have some questions that I am leaving for QA: 1 - Before this patch the awards displayed in the description tab only on staff-client, and both in detail view and description tab on opac. I am thinking if we are going to display on the details page we should remove from description tab on both staff/opac - maybe out of scope. 2 - indicator 1 is supposed to control generation of display content "Awards:" (display if blank, dont if =8) and it does if all =8, but with multiple fields and a mix of =8 or =# you always get the "Awards:" I don't know if it would be worth splitting them into two display sections based on the indicator or if it isn't a big deal (In reply to Winona Salesky from comment #2)

Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 586 4) Perform an opac search that would show the record in the search results 5) Note the fields uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 rgravel@marlboro.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgravel@marlboro.edu --- Comment #6 from rgravel@marlboro.edu --- Regarding 1: That sounds right to me, Nick. The redundancy of the contents and summary notes, for instance, drives me a little crazy personally, and so anything to avoid that appeals to me! I am in favor of leaving it only in the details and not in the notes tab. Regarding 2: I'm no expert on display constants, but I think these are for card/shelf-list printing, so I don't think that distinguishing ## from #8 is necessary, as they are all awards and the cataloger cannot supply a different label anyway. (In reply to Nick Clemens from comment #4)

Separation and display look good so signing off, but I have some questions that I am leaving for QA:

1 - Before this patch the awards displayed in the description tab only on staff-client, and both in detail view and description tab on opac. I am thinking if we are going to display on the details page we should remove from description tab on both staff/opac - maybe out of scope.

2 - indicator 1 is supposed to control generation of display content "Awards:" (display if blank, dont if =8) and it does if all =8, but with multiple fields and a mix of =8 or =# you always get the "Awards:" I don't know if it would be worth splitting them into two display sections based on the indicator or if it isn't a big deal

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37592|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38086&action=edit [PASSED QA] Updated display for 586 in XSLT http://bugs.koha-community.org/show_bug.cgi?id=13434 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Winona! And congrats for your patch pushed! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.