[Bug 15578] New: Authority tests skip and hide a bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Bug ID: 15578 Summary: Authority tests skip and hide a bug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14639 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 [Bug 14639] Extend Koha::MetadataRecord to handle serialization format -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46649&action=edit Bug 15578: Insert authority records before processing tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46650&action=edit Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15358 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 [Bug 15358] merge.pl does not populate values to merge -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46649|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46675&action=edit [SIGNED-OFF]Bug 15578: Insert authority records before processing tests Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46650|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46676&action=edit [SIGNED-OFF]Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46675|0 |1 is obsolete| | Attachment #46676|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46711&action=edit Bug 15578: Insert authority records before processing tests Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46712&action=edit Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Depends on| |15380 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org