http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
Created attachment 41199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41199&action=edit
Bug 14598: Make C4::Circulation::AddReturn store the right itemtype

This patch makes C4::Circulation::AddReturn correctly store the itemtype
on the 'statistics' table.

To reproduce:
- Checkout master.
- Make a checkout.
- Check the 'statistics' table and notice the itemtype is correctly set
  > SELECT * FROM statistics;
- Check the item in.
- Check the 'statistics' table and notice the itemtype is not set
  > SELECT * FROM statistics WHERE type="return";
=> FAIL: itemtype is set to NULL

To test:
- Apply the regression tests patch
- Run the tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail
- Apply this patch
- Run the regression tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> SUCCESS: Tests now pass.
- Repeat the 'To reproduce' steps
=> SUCCESS: itemtype is now correctly set (in real life)
- Happily sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41200|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41201&action=edit Bug 14598 [QA Followup] - Don't die on bad barcode -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> ---
Created attachment 41204
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41204&action=edit
[SIGNED-OFF] Bug 14598: Make C4::Circulation::AddReturn store the right
itemtype

This patch makes C4::Circulation::AddReturn correctly store the itemtype
on the 'statistics' table.

To reproduce:
- Checkout master.
- Make a checkout.
- Check the 'statistics' table and notice the itemtype is correctly set
  > SELECT * FROM statistics;
- Check the item in.
- Check the 'statistics' table and notice the itemtype is not set
  > SELECT * FROM statistics WHERE type="return";
=> FAIL: itemtype is set to NULL

To test:
- Apply the regression tests patch
- Run the tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail
- Apply this patch
- Run the regression tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> SUCCESS: Tests now pass.
- Repeat the 'To reproduce' steps
=> SUCCESS: itemtype is now correctly set (in real life)
- Happily sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9351 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is it a duplicate of bug 9351? I would say we need to update existing rows. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Tomás Cohen Arazi <tomascohen@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41204|0                           |1
        is obsolete|                            |

--- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
Created attachment 41384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41384&action=edit
Bug 14598: Make C4::Circulation::AddReturn store the right itemtype

This patch makes C4::Circulation::AddReturn correctly store the itemtype
on the 'statistics' table.

To reproduce:
- Checkout master.
- Make a checkout.
- Check the 'statistics' table and notice the itemtype is correctly set
  > SELECT * FROM statistics;
- Check the item in.
- Check the 'statistics' table and notice the itemtype is not set
  > SELECT * FROM statistics WHERE type="return";
=> FAIL: itemtype is set to NULL

To test:
- Apply the regression tests patch
- Run the tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail
- Apply this patch
- Run the regression tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> SUCCESS: Tests now pass.
- Repeat the 'To reproduce' steps
=> SUCCESS: itemtype is now correctly set (in real life)
- Happily sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 14531 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> ---
Created attachment 41628
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41628&action=edit
[SIGNED-OFF] Bug 14598: Make C4::Circulation::AddReturn store the right
itemtype

This patch makes C4::Circulation::AddReturn correctly store the itemtype
on the 'statistics' table.

To reproduce:
- Checkout master.
- Make a checkout.
- Check the 'statistics' table and notice the itemtype is correctly set
  > SELECT * FROM statistics;
- Check the item in.
- Check the 'statistics' table and notice the itemtype is not set
  > SELECT * FROM statistics WHERE type="return";
=> FAIL: itemtype is set to NULL

To test:
- Apply the regression tests patch
- Run the tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail
- Apply this patch
- Run the regression tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> SUCCESS: Tests now pass.
- Repeat the 'To reproduce' steps
=> SUCCESS: itemtype is now correctly set (in real life)
- Happily sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9)

Is it a duplicate of bug 9351?

I would say we need to update existing rows.

What about existing rows? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 41637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41637&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl block that updates the rows that lack itemtype. It relies on Koha::Item->effective_itemtype() to choose the rigt one. I wrote it using SQL because the statistics table lacks PKs. Note: I'm not sure about making this dependent on 14651, I need a QA POV on this, and I'm biased as I wrote all the related patches... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41637|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 42171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42171&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42171|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42177&action=edit [SIGNED-OFF] Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #23)

Tomás, you have marked this bug as a duplicate of bug 9351 but you don't take care of the CanBookBeIssued subroutine. Do you plan to update it as well?

It is GBSD, I will probably fill a new bug and take care of that too, yeah. ☺ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The thing is that the update queries can take ages on a big DB, and we will have to loop again if everything is not fixed at the same time. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about comments 23&26? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Tomás Cohen Arazi <tomascohen@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41628|0                           |1
        is obsolete|                            |

--- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
Created attachment 44666
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44666&action=edit
Bug 14598: Make C4::Circulation::AddReturn store the right itemtype

This patch makes C4::Circulation::AddReturn correctly store the itemtype
on the 'statistics' table.

To reproduce:
- Checkout master.
- Make a checkout.
- Check the 'statistics' table and notice the itemtype is correctly set
  > SELECT * FROM statistics;
- Check the item in.
- Check the 'statistics' table and notice the itemtype is not set
  > SELECT * FROM statistics WHERE type="return";
=> FAIL: itemtype is set to NULL

To test:
- Apply the regression tests patch
- Run the tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail
- Apply this patch
- Run the regression tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> SUCCESS: Tests now pass.
- Repeat the 'To reproduce' steps
=> SUCCESS: itemtype is now correctly set (in real life)
- Happily sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42177|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44668&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #35 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 45030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45030&action=edit Bug 14598 - QA Followup touching CanBookBeIssued subroutine -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45047&action=edit Bug 14598 [QA Followup] - Only fetch bib data if needed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45838&action=edit Bug 14598 [QA Followup] - Correct the behavior of GetItem Currently GetItem sets itemtype to the biblio itemtype if no item level itemtype exists. Instead, it should only do this if item_level-itypes is not set. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45843&action=edit Bug 14598 [QA Followup] - Correct the behavior of GetItem Currently GetItem sets itemtype to the biblio itemtype if no item level itemtype exists. Instead, it should only do this if item_level-itypes is not set. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver@bywatersolutions.co | |m Status|Signed Off |Failed QA --- Comment #41 from Jesse Weaver <jweaver@bywatersolutions.com> --- One of the new test fails after applying all patches, and I'm not quite sure why: [elf]:~/p/koha> prove t/db_dependent/Circulation/Returns.t -- [2016-01-07 17:01] ------------------------------------------------------------------------------------------------------------ t/db_dependent/Circulation/Returns.t .. 1/3 item-level_itypes set but no itemtype set for item (Koha::Schema::Result::Item=HASH(0x7666618)->itemnumber) at /home/feoh3/p/koha/Koha/Schema/Result/Item.pm line 653. item-level_itypes set but no itemtype set for item (Koha::Schema::Result::Item=HASH(0x7677b68)->itemnumber) at /home/feoh3/p/koha/Koha/Schema/Result/Item.pm line 653. # Failed test 'biblio-level itype recorded on statistics for return as a fallback for null item-level itype' # at t/db_dependent/Circulation/Returns.t line 167. # got: 'zmH5aYw18' # expected: 'JTI' # Looks like you failed 1 test of 2. # Failed test 'AddReturn logging on statistics table (item-level_itypes=1)' # at t/db_dependent/Circulation/Returns.t line 170. # Looks like you failed 1 test of 3. t/db_dependent/Circulation/Returns.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/Circulation/Returns.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.19 cusr 0.04 csys = 1.25 CPU) Result: FAIL (FYI: the same warning that appears at the top of the test output here also appears when I prove t/db_dependent/Items.t, though that test passes.) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46546&action=edit Bug 14598 [QA Followup] - Make unit test pass -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- It took me a minute for what you wrote to sink in. Still, we should address the issue on a separate bug report. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Unit tests fixes submitted on bug 15599! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think other routines (CanBookBeIssued, ...?) still suffer the same problem - I tried fixing CanBookBeIssued, but failed at writing the unit tests. We should make sure there are updated separate bug reports for those - best would be to fix them all before the next release (consistency in reporting) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #49)

(In reply to Jonathan Druart from comment #47)

...

Kyle, With the last patches, you consider that all the concerns have been taken into account, that's it? It's what I understand, but in this case, we need to update the existing rows in the update DB entry.

There is already a db update in updatedatabase.pl, is this what you are looking for?

No, it does not update localuse. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #50)

No, it does not update localuse.

This followup should take care of that! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44665|0 |1 is obsolete| | --- Comment #54 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 47108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47108&action=edit Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44667|0 |1 is obsolete| | --- Comment #56 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 47110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47110&action=edit Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45030|0 |1 is obsolete| | --- Comment #58 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 47112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47112&action=edit Bug 14598 - QA Followup touching CanBookBeIssued subroutine Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45844|0 |1 is obsolete| | --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 47114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47114&action=edit Bug 14598 [QA Followup] - Correct the behavior of GetItem Currently GetItem sets itemtype to the biblio itemtype if no item level itemtype exists. Instead, it should only do this if item_level-itypes is not set. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We need to fix bug 15599 first. -- You are receiving this mail because: You are watching all bug changes.