[Bug 31754] New: DataTable paginate_button make other elements move around when hovered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Bug ID: 31754 Summary: DataTable paginate_button make other elements move around when hovered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 30952 Created attachment 141758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141758&action=edit Screenshot of problem If you bring up a dataTable, like when doing a patron search, and hover over the paginate_button's (first,previous,next,last) you'll notice the rest of the elements in the toolbar move a bit. ( search box, clear filter ) see attachment Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142079&action=edit GIF showing revised responsive behavior The staff interface update included several changes to DataTables controls which I think were unnecessary (and unrelated to the redesign). I propose to build on some work I'd intended for Bug 30986 to make general improvements. See the attached GIF for a preview. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DataTable paginate_button |Improve appearance of |make other elements move |behavior of DataTables |around when hovered |controls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142080&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 [Bug 31842] admin/branches: DT search generates js error on col.data.split -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- So much better, thank you Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142080|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142085&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I quite like what I see, but leaving it here for now as: (21:34:00) oleonard: Hm... I think my patch for Bug 31754 doesn't keep the controls on the right. I should revised it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142085|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142089&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142154&action=edit Bug 31754: (follow-up) Correct alignment of buttons This patch corrects the alignment of the "Columns," "Export," and "Configure" buttons. The new design has them aligned to the right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 [Bug 31861] Table controls on checkouts table are buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is looking good.. but Lucas's first point isn't addressed... if you hover over the 'first, previous, next, last' page controls, the bold on hover makes the interactive elements on the left 'jiggle' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142330&action=edit Video of hover effect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142089|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142478&action=edit Bug 31754: Improve appearance of behavior of DataTables controls This patch makes changes to CSS and to the default DataTables DOM configuration in order to make toolbars work better at various screen widths. The patch also makes stylelint corrections to _tables.scss. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test pages in the staff interface where tables contain multiple pages of results, e.g. a patron search. - Confirm that table information (entries) and controls look correct. - Confirm that all controls work correctly, including the search field. - Resize your browser to check how the controls respond at various browser widths. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142154|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142479&action=edit Bug 31754: (follow-up) Correct alignment of buttons This patch corrects the alignment of the "Columns," "Export," and "Configure" buttons. The new design has them aligned to the right. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It was caching at my end.. passing qa -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Bug 31754 depends on bug 31842, which changed state. Bug 31842 Summary: admin/branches: DT search generates js error on col.data.split https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31754 Bug 31754 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org