[Bug 31932] New: The basket summary page template needs a cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Bug ID: 31932 Summary: The basket summary page template needs a cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The indentation on basket.tt is really confusing and could do with a cleanup.. lots of nested conditions without consistent nesting end points. I'd also love to see the top two col sections marked up with page-section to 'card' them, and we could do with fixing where the 'add user' link appear on the 'Managed by' row. Lots of little things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 [Bug 31837] Add page-section to basket summary page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Staff Client |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Bug 31932 depends on bug 31837, which changed state. Bug 31837 Summary: Add page-section to basket summary page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145664&action=edit Bug 31932: The basket summary page template needs a cleanup This patch reindents the Acquisitions basket template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions. Locate a vendor and add a basket and some orders if necessary. Test as much of the page's functionality as possible, e.g. toolbar controls, in-table controls, managed-by and managing library controls, etc. Try adding an internal note, adding a vendor note, and deleting the basket. Everything should look correct and work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145665&action=edit Bug 31932: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145664|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145686&action=edit Bug 31932: The basket summary page template needs a cleanup This patch reindents the Acquisitions basket template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions. Locate a vendor and add a basket and some orders if necessary. Test as much of the page's functionality as possible, e.g. toolbar controls, in-table controls, managed-by and managing library controls, etc. Try adding an internal note, adding a vendor note, and deleting the basket. Everything should look correct and work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145665|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145687&action=edit Bug 31932: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Much clearer, thanks for this Owen.. I had meant to come back to it myself but there's never enough time is there! It's much more understandable now. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32733 [Bug 32733] Add more page-sections to basket summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145686|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145736&action=edit Bug 31932: The basket summary page template needs a cleanup This patch reindents the Acquisitions basket template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions. Locate a vendor and add a basket and some orders if necessary. Test as much of the page's functionality as possible, e.g. toolbar controls, in-table controls, managed-by and managing library controls, etc. Try adding an internal note, adding a vendor note, and deleting the basket. Everything should look correct and work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145687|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145737&action=edit Bug 31932: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org