[Bug 32482] New: Reindent holds awaiting pickup template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Bug ID: 32482 Summary: Reindent holds awaiting pickup template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose to reformat the holds awaiting pickup template (waitingreserves.tt) in the staff interface so that it has consistent spacing and indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144674&action=edit Bug 32482: Reindent holds awaiting pickup template This patch reindents the holds awaiting pickup template so that it has consistent indentation. This patch also corrects a markup error that was causing a layout issue. Incorrectly closed <div>s caused the circulation sidebar menu to disappear. To test, apply the patch and test all aspects of the page, including: - Correctly functioning tabs and DataTables - Cancel selected holds waiting - Cancel selected holds waiting past ReservesMaxPickUpDelay - Cancel all holds waiting past ReservesMaxPickUpDelay - Cancel individual holds with cancellation requests (Cancellations of waiting holds via the OPAC. See "Default waiting hold cancellation policy" in Circulation and Fine rules). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144675&action=edit Bug 32482: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144674|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 144709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144709&action=edit Bug 32482: Reindent holds awaiting pickup template This patch reindents the holds awaiting pickup template so that it has consistent indentation. This patch also corrects a markup error that was causing a layout issue. Incorrectly closed <div>s caused the circulation sidebar menu to disappear. To test, apply the patch and test all aspects of the page, including: - Correctly functioning tabs and DataTables - Cancel selected holds waiting - Cancel selected holds waiting past ReservesMaxPickUpDelay - Cancel all holds waiting past ReservesMaxPickUpDelay - Cancel individual holds with cancellation requests (Cancellations of waiting holds via the OPAC. See "Default waiting hold cancellation policy" in Circulation and Fine rules). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144675|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 144710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144710&action=edit Bug 32482: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This tidies up the template release notes| |used to display the holds | |awaiting pickup page | |(Circulation > Holds > | |Holds awaiting pickup). It | |also fixes the page so that | |the circulation sidebar is | |now shown. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144709|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145821&action=edit Bug 32482: Reindent holds awaiting pickup template This patch reindents the holds awaiting pickup template so that it has consistent indentation. This patch also corrects a markup error that was causing a layout issue. Incorrectly closed <div>s caused the circulation sidebar menu to disappear. To test, apply the patch and test all aspects of the page, including: - Correctly functioning tabs and DataTables - Cancel selected holds waiting - Cancel selected holds waiting past ReservesMaxPickUpDelay - Cancel all holds waiting past ReservesMaxPickUpDelay - Cancel individual holds with cancellation requests (Cancellations of waiting holds via the OPAC. See "Default waiting hold cancellation policy" in Circulation and Fine rules). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144710|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145822&action=edit Bug 32482: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- These fixes have been great but they don't apply well in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org