[Bug 36559] New: Transport Cost Matrix update helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Bug ID: 36559 Summary: Transport Cost Matrix update helpers Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: holly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the transport cost matrix, library name row and column titles are only visible in the browser window if the user is working in a part of the matrix fairly close to the top or left side of the matrix. For large consortia, and when there are many libraries in the system, the matrix is often too big to see this information. For ease of filling out the matrix, it would be nice if the user always had a way to see the library combination for the active cell. This could look a few ways, and I'm sure someone out here has additional ideas. 1. Library names could be frozen and always visible 2. Library names could show when the user hovers over any given cell. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- +1 Good ideas -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|23.05 |master Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164794&action=edit Bug 36559: Add sticky table headers to transport cost matrix To test: 1. APPLY patch and regenerate CSS. ( yarn build ) 2. Have many, many branches. To test it is good to have more branches than in a standard k-t-d. 3. Go to Admin > Transport cost matrix 4. Scroll down and to the right, the table headers should stay visible. 5. Hover over any cell, a title should appear like 'Branch A / Branch B' 6. Test in Chrome and Firefox. This uses position: sticky which has recently gained more widespread browser support: https://caniuse.com/?search=sticky -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- I tested this with 40 branches and it works well in both Chrome and Firefox. One small thing I noticed is that the first column table header From \ To does not stick in either vertical or horizontal scrolling directions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165145&action=edit Bug 36559: (follow-up) Fix To/From z-index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #3)
I tested this with 40 branches and it works well in both Chrome and Firefox.
One small thing I noticed is that the first column table header From \ To does not stick in either vertical or horizontal scrolling directions.
Thanks Brendan! I provided a follow up to fix that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164794|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 165202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165202&action=edit Bug 36559: Add sticky table headers to transport cost matrix To test: 1. APPLY patch and regenerate CSS. ( yarn build ) 2. Have many, many branches. To test it is good to have more branches than in a standard k-t-d. 3. Go to Admin > Transport cost matrix 4. Scroll down and to the right, the table headers should stay visible. 5. Hover over any cell, a title should appear like 'Branch A / Branch B' 6. Test in Chrome and Firefox. This uses position: sticky which has recently gained more widespread browser support: https://caniuse.com/?search=sticky Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165145|0 |1 is obsolete| | --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 165203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165203&action=edit Bug 36559: (follow-up) Fix To/From z-index Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Status|Signed Off |Patch doesn't apply --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi guys, second patch is failing to apply for me: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36559: Add sticky table headers to transport cost matrix Applying: Bug 36559: (follow-up) Fix To/From z-index error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 36559: (follow-up) Fix To/From z-index hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-36559-follow-up-Fix-ToFrom-z-index-cx2obgcd.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165203|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165400&action=edit Bug 36559: (follow-up) Fix To/From z-index Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165202|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165402&action=edit Bug 36559: Add sticky table headers to transport cost matrix To test: 1. APPLY patch and regenerate CSS. ( yarn build ) 2. Have many, many branches. To test it is good to have more branches than in a standard k-t-d. 3. Go to Admin > Transport cost matrix 4. Scroll down and to the right, the table headers should stay visible. 5. Hover over any cell, a title should appear like 'Branch A / Branch B' 6. Test in Chrome and Firefox. This uses position: sticky which has recently gained more widespread browser support: https://caniuse.com/?search=sticky Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165400|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165403&action=edit Bug 36559: (follow-up) Fix To/From z-index Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Working as described. Great improvement. QA script happy. Used Nick's https://github.com/kidclamp/handy-koha-script/blob/main/randbranches.pl to generate a ton of branches to test this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transport Cost Matrix |Transport cost matrix |update helpers |update helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With a lot of columns and release notes| |rows the transport cost | |matrix got hard to edit. | |This patch makes it so that | |the header column and row | |are fixed and will always | |remain visible while | |editing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org