http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46869&action=edit Bug 15599 - Unit tests output warnings The unit tests t/db_dependent/Circulation/Returns.t and t/db_dependent/Items.t print out eh warning "item-level_itypes set but no itemtype set for item". This should not happen. Test Plan: 1) prove t/db_dependent/Circulation/Returns.t 2) Note the warning 3) prove t/db_dependent/Items.t 4) Note the warning 5) Apply this patch 6) prove t/db_dependent/Circulation/Returns.t 7) Note there is no warning 8) prove t/db_dependent/Items.t 9) Note there is no warning -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Gus Ellerm from comment #2)

Tried to test this and still generated errors. Not sure if it was due to me applying the process wrong or if patch is unusable.

Everything still works for me. Did you apply bug 14598 first? If so, can you paste the output of the unit tests here? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Can't duplicate problem as described in test plan. mtompset@debian:~/kohaclone$ git checkout -b bug_15599 origin/master Branch bug_15599 set up to track remote branch master from origin. Switched to a new branch 'bug_15599' mtompset@debian:~/kohaclone$ prove t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/Returns.t .. Subroutine C4::Context::userenv redefined at t/db_dependent/Circulation/Returns.t line 15. t/db_dependent/Circulation/Returns.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.90 cusr 0.04 csys = 0.96 CPU) Result: PASS mtompset@debian:~/kohaclone$ prove t/db_dependent/Items.t t/db_dependent/Items.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.16 cusr 0.03 csys = 1.21 CPU) Result: PASS Patch does not apply. mtompset@debian:~/kohaclone$ git bz apply 15599 Bug 15599 - Unit tests output warnings 46869 - Bug 15599 - Unit tests output warnings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15599 - Unit tests output warnings fatal: sha1 information is lacking or useless (t/db_dependent/Circulation/Returns.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15599 - Unit tests output warnings The copy of the patch that failed is found in: /home/mtompset/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15599---Unit-tests-output-warnings-lEGWsI.patch mtompset@debian:~/kohaclone$ NOTE: I read the patch, and it looks like an improvement to me, but can't sign off. Please rebase first. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47243&action=edit Bug 15599 - Unit tests output warnings The unit tests t/db_dependent/Circulation/Returns.t and t/db_dependent/Items.t print out eh warning "item-level_itypes set but no itemtype set for item". This should not happen. Test Plan: 1) prove t/db_dependent/Circulation/Returns.t 2) Note the warning 3) prove t/db_dependent/Items.t 4) Note the warning 5) Apply this patch 6) prove t/db_dependent/Circulation/Returns.t 7) Note there is no warning 8) prove t/db_dependent/Items.t 9) Note there is no warning Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #7)

Kyle, the warnings appear for many other tests, see t/db_dependent/Reserves.t for instance. I don't think this is a right way to fix it.

Perhaps not overall, however, taking "string $foo->bar" and turning it to "string $foobar" is a start. Catching warnings is a good test. Perhaps "$debug and" prepended to the {warn mess} would be fitting, and still allow for the testing added? -- You are receiving this mail because: You are watching all bug changes.