http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19766|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19767&action=edit Bug 10612 - Add ability to delete patrons with batch patron modification tool The batch patron deletion/anonymization does not allow for batch deletion of arbitrary lists of patrons. The batch patron modification tool allows for modification of arbitrary lists of patrons, but not deletion. If would be highly beneficial to add patron deletion to the batch patron modification tool. Test Plan: 1) Apply all dependencies for this patch 2) Apply this patch 3) Create a list of patrons with the new Patron Lists feature a) Include at least one patron owing fines b) Include at least one patron with items currently checked out c) Include at least one patron not falling into a) or b) 4) Browse to the batch patron modifications tool 5) Select your list from the pulldown, and submit 6) Check the "Delete patrons" checkbox, the click the submit button 7) You should a list of errors for the patrons with fines or issues and a table of patrons that were deleted successfully. 8) Click the link for a deleted patron, you should get a "patron not found" message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Liz Rea from comment #3)

Hi,

Tried to test this, got the following:

Falling back to patching base and 3-way merge... Auto-merging tools/modborrowers.pl CONFLICT (content): Merge conflict in tools/modborrowers.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt Failed to merge in the changes. Patch failed at 0001 Bug 10612 - Add ability to delete patrons with batch patron modification tool

It applied fine for me. Did you apply all the dependencies? First you need to apply 8798, then 10565, then finally this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19767|0 |1 is obsolete| | CC| |melissa@bywatersolutions.co | |m --- Comment #7 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 21081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21081&action=edit Bug 10612 - Add ability to delete patrons with batch patron modification tool -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21081|0 |1 is patch| | Attachment #21081|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21444|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21445&action=edit Bug 10612 - Add ability to delete patrons with batch patron modification tool - QA Followup - Move member deletion related calls to DelMember -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I am sorry, but this patch no longer applies and I was not sure how to resolve the conflict, could you please take a look? [~/kohaclone (73-10612-deletepatronsbatch)]> git bz apply 10612 Bug 10612 - Add ability to delete patrons with batch patron modification tool 21081 - Bug 10612 - Add ability to delete patrons with batch patron modification tool 21446 - Bug 10612 - Add ability to delete patrons with batch patron modification tool - QA Followup - Move member deletion related calls to DelMember Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10612 - Add ability to delete patrons with batch patron modification tool /home/katrin/kohaclone/.git/rebase-apply/patch:41: trailing whitespace. Cannot delete patron /home/katrin/kohaclone/.git/rebase-apply/patch:49: trailing whitespace. Cannot delete patron /home/katrin/kohaclone/.git/rebase-apply/patch:101: trailing whitespace. warning: 3 lines add whitespace errors. Using index info to reconstruct a base tree... <stdin>:41: trailing whitespace. Cannot delete patron <stdin>:49: trailing whitespace. Cannot delete patron <stdin>:101: trailing whitespace. warning: 3 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging tools/modborrowers.pl CONFLICT (content): Merge conflict in tools/modborrowers.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt Failed to merge in the changes. Patch failed at 0001 Bug 10612 - Add ability to delete patrons with batch patron modification tool When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10612---Add-ability-to-delete-patrons-with-bat-_BRqbC.patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Why don't you use the Batch patron deletion? Maybe we could have a new entry "Delete patrons in the list <select>". Don't you think it is not consistent to allow to delete patron in 2 different places? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #15)

Kyle, Why don't you use the Batch patron deletion? Maybe we could have a new entry "Delete patrons in the list <select>". Don't you think it is not consistent to allow to delete patron in 2 different places?

The code is an extension of the addition of lists to the patron modification tool. I understand what you mean. However I'd suggest that over time we, instead of having two separate tools that function in different ways, unify both the existing patron modification and deletion tools in a manner equivalent to the batch item and modification deletion which is just the same script with a flag passed in for deletion. If you consider this change in behavior a QA deal breaker, please let me know by setting this bug to Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #19 from Nora Blake <nblake@masslibsystem.org> --- Hello, I am the force behind this whole development and I can tell you what our situation is and what we are trying to accomplish. We have many schools in our consortium. They want to be able to remove classes of students each year after they graduate. Our schools do not treat their patron accounts in the same way that they treat books, so they do not have the student barcodes on hand or available in the same way that they can grab a stack of books and scan them all in to the batch item deletion tool. They need to be able to search for a group of patrons by a common piece of information stored in a single field. In our case, we store year of graduation information in either the "sort 1" or "sort 2" field of the patron record. They need to be able to search for that common piece of information easily, obtain a grouping of patrons from the search and then decide whether they want to delete the whole class of kids from the system (probably the most common event we will have) OR change their patron type from "student" to "alumni" or something else. They don't use patron card numbers to find patron accounts. Often they checkout based on a name search or they may scan the kid's school ID, but they won't have those ID cards on hand when it comes time to delete them from the system. So they need to be able to perform a search for the "class of 2014" or "2014" or "grade 12," depending on what they have entered in the child's record and get a group of patrons together in one place so they can then delete them (most common need) or modify their patron type or modify their year of graduation if several are being held back or do something else that I can't think of. I hope this helps clarify why Kyle is looking to do what he is proposing. Thanks, Nora Blake -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to delete |Add ability to delete |patrons with batch patron |patrons with batch patron |modification tool |deletion tool -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22837|0 |1 is obsolete| | Attachment #22838|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28779&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nick@quecheelibrary.org --- Comment #23 from Nick Clemens <nick@quecheelibrary.org> --- I got some odd results when testing: 1 Added four patrons to the list: One with a checkout One with a fine Two with empty accounts Patron modification link seemed to work as expected Patron deletion link said 3 patrons would be deleted, I deleted, it said 3 were gone, 2 were left in list (one with checkout, one with fine) I would be nice on the deletion screen to know who was going to be deleted/who was deleted, I can't tell from my results which patron (issue or fine) it was planning to delete. If not a list before deletion, maybe a results list after the action. I also found that I had two identical lists, both affected by deletion, but don't know if that is from this patch (In reply to Kyle M Hall from comment #1)

Created attachment 19766 [details] [review] Bug 10612 - Add ability to delete patrons with batch patron modification tool

The batch patron deletion/anonymization does not allow for batch deletion of arbitrary lists of patrons. The batch patron modification tool allows for modification of arbitrary lists of patrons, but not deletion. If would be highly beneficial to add patron deletion to the batch patron modification tool.

Test Plan: 1) Apply all dependencies for this patch 2) Apply this patch 3) Create a list of patrons with the new Patron Lists feature a) Include at least one patron owing fines b) Include at least one patron with items currently checked out c) Include at least one patron not falling into a) or b) 4) Browse to the batch patron modifications tool 5) Select your list from the pulldown, and submit 6) Check the "Delete patrons" checkbox, the click the submit button 7) You should a list of errors for the patrons with fines or issues and a table of patrons that were deleted successfully. 8) Click the link for a deleted patron, you should get a "patron not found" message.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl --- Comment #27 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Owen Leonard from comment #26)

Are patron automatically excluded from deletion for some reason? I tried to delete based on a patron list that contains 82 patrons and the tool offers to delete 2 patrons.

Only patrons with non-zero account balance (with unpaid fines/charges) are explicitly excluded when deleting from a list. Batch deleting (from a list) patrons with active check-outs really needs some thought, IMO (apart from the somehow missleading count mentioned in comment #25). While such patron records would not get actually deleted (due to the foreign key constraint in issues table): - their reserves and lists/virtual shelves (if any) would be deleted, - if the choosen action is 'Move these patrons to the trash', I think that the surplus record would be created in the deletedborrowers table, with original patron record still remaining in borrowers table. Also, when deleting from a list, it's possible to (accidentally) delete a staff patron, and a patron which is a guarantor for some other patron[s]. On an unrelated subject: 'patron category' filter in batch patron deletion/anonymization tool seems to be badly broken in the current master (different issue, encountered while testing this patch - I will file separate bug report for it). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36311&action=edit [SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables To move towards a more consistent codebase, I have changed some variables from being camelCased or onelongname to the more standard convention of words_separated_with_underscores. In addition, this changes the use of the word 'member' to the word 'patron' to move towards unification of our terminology. Our internal terminology should move towards matching our external terminology ( members, borrowers => patrons, reserves => holds, etc ). Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28779|0 |1 is obsolete| | Attachment #28780|0 |1 is obsolete| | Attachment #36311|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36313&action=edit [SIGNED-OFF] Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36314|0 |1 is obsolete| | --- Comment #32 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36315&action=edit [SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables To move towards a more consistent codebase, I have changed some variables from being camelCased or onelongname to the more standard convention of words_separated_with_underscores. In addition, this changes the use of the word 'member' to the word 'patron' to move towards unification of our terminology. Our internal terminology should move towards matching our external terminology ( members, borrowers => patrons, reserves => holds, etc ). Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |jweaver@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |kyle.m.hall@gmail.com --- Comment #35 from Kyle M Hall <kyle.m.hall@gmail.com> ---

1) I know it's outside the scope of this bug, but we are about to make the feature much more prominent and easier to use with this patch.

I am worried about the lack of good error messages and possible missing checks in the patron deletion tool (see also comment#27). In general we always need to check at least for: - checkouts - fines - guarantor relationships

Example: Argh? I created a patron list with 6 patrons, I checked out a book to one of the patrons. The test run on the patron delete tells me the that 6 patrons would have been deleted.

I agree this is out of the scope of this bug. Can you file a separate bug for that?

2) Patron list page: I don't like the "2 symbol" concept on the buttons, because that won't work well for translations. You can't assume safely that the Verb is always on the left side and the subject on the right. For example in the German translations we could have both: Lösche Benutzer and Benutzer löschen.

I've removed the double icons and just kept the left most icon for each! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #36)

Hi Kyle,

could you do me a favour and try the test case I described? I feel if we push this without checking the basic functionality of the tool is correct, we will just end up with unhappy feedback on a good new feature.

...

Example: Argh? I created a patron list with 6 patrons, I checked out a book to one of the patrons. The test run on the patron delete tells me the that 6 patrons would have been deleted.

Katrin, I have tried and it works: Create patrons A and B Check an item out to B Add A and B to a patron list Use the tool to delete patrons from this list Test tun tells me 1 patron will be deleted Permanently delete the patrons delete only 1 patron -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41364&action=edit Bug 10612 [Code cleanup] - Rename some variables To move towards a more consistent codebase, I have changed some variables from being camelCased or onelongname to the more standard convention of words_separated_with_underscores. In addition, this changes the use of the word 'member' to the word 'patron' to move towards unification of our terminology. Our internal terminology should move towards matching our external terminology ( members, borrowers => patrons, reserves => holds, etc ). Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, thx for testing! - I will rerun my test and see if I did something differently. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- - Add 4 patrons to a patron list, one has a checkout - Select patron list in batch tool - Reports: 4 patrons will be deleted (misleading, only 3 should) - Choose test run: 4 patrons would have been removed (if it wasn't a test run) In my eyes, if a test run doesn't reflect what would be happening, it's useless. - Go back, change to "move to trash" 4 patrons have been successfully moved to trash - The user with the checkout has NOT been deleted (thankfully) Now the next strange thing: - Checking the deletedborrowers table - there is my user with the checkout. So it actually moved all the borrowers to deletedborrowers and I have ended up with the same borrowernumber in borrowers and deletedborrowers. I know this is not related directly to the feature, but this tool gives me a headache as it is. I don't trust it at all. In my opinion it's very buggy and shouldn't be promoted before fixed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #43)

Hm, it seems I tested the same as you but with very different results... what could be the difference? My results look worrysome, especially the double existance of borrower data in borrowers and deletedborrowers.

Tested again right now, and it works for me. Nothing in the logs? What happen if you use the tool using the 2 other criteria (not borrowed since, expiration date)? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- I squashed patches, rebased, and added a check for issues to the subroutine: _skip_borrowers_with_nonzero_balance making it: _skip_borrowers_with_nonzero_balance_or_issues -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 46280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46280&action=edit Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 natasha <tasham_8@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46280|0 |1 is obsolete| | --- Comment #50 from natasha <tasham_8@hotmail.com> --- Created attachment 46834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46834&action=edit Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt Signed-off-by: Natasha <tasham_8@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10565 |15642 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 [Bug 15642] Batch patron deletion should not delete patrons with issues -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46834|0 |1 is obsolete| | --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47225&action=edit Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt Signed-off-by: Natasha <tasham_8@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47153|0 |1 is obsolete| | --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47226&action=edit Bug 10612 [QA Followup] 1 - Use Koha::List::Patron 2 - Return only non-empty lists for deletion selection -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I get Undefined subroutine &main::_skip_borrowers_with_nonzero_balance_or_issues called at /home/koha/src/tools/cleanborrowers.pl line 103. then, afer renaming the subroutine correctly: Can't call method "patron_list_patrons" on an undefined value at /home/koha/src/tools/cleanborrowers.pl line 128. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #57)

Undefined subroutine &main::_skip_borrowers_with_nonzero_balance_or_issues called at /home/koha/src/tools/cleanborrowers.pl line 103. I don't get this one, did you apply 15642?

Can't call method "patron_list_patrons" on an undefined value at /home/koha/src/tools/cleanborrowers.pl line 128. Fixed missing closing quote on patron_list_id value which caused this

-- You are receiving this mail because: You are watching all bug changes.