https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Bug 32914 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a small display issue on http://localhost:8081/cgi-bin/koha/tools/batch_record_modification.pl with the tabs being further left than the corresponding content block below. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146420|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147829&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #6 from Philip Orr <philip.orr@lmscloud.de> --- Hi Owen, I wanted to test this bug but after creating a list and a MARC modification template, when I clicked on "Batch record modification", I got an error: template process failed. "Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt line 158: unexpected token (ELSIF) [% ELSIF view == 'list' %] at /kohadevbox/koha/C4/Templates.pm line 127" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #8 from Philip Orr <philip.orr@lmscloud.de> --- OK, will do! :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147829|0 |1 is obsolete| | Attachment #147830|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148814&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Philip Orr <philip.orr@lmscloud.de> --- The display issue is now fixed! All three tabs display correctly. However when submitting a batch for modification only the tab "Enter a list of record numbers" actually leads to a batch record modification; both other tabs "Select a list of records" and "Upload a file" lead to the message "No records were modified". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148814|0 |1 is obsolete| | Attachment #148815|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149670&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. This patch adds a "clearfix" snippet of CSS to _mixins.scss copied from Bootstrap. Applied to the active tab pane, this helps in situations where Bootstrap tabs follow a floated element. The patch also wraps tab label strings in <span> to ensure they can be translated. Unrelated: The patch removes an extra </option> from the batch record modification template. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Philip Orr from comment #13)

then switch from Record type: Biblios to Record type: Authorities, your list actually stays selected and is still shown (and will indeed be modified if you proceed).

In my testing this is a bug which exists in master and previous versions. I'm not sure if the bug should be resolved as part of this patch or not -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 150214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150214&action=edit Bug 32914: (follow-up) Improve handling of list tab visibility This patch makes minor changes to the way this page handles switching between authority and bibliographic record batch operation in order to ensure that the list tab is correctly shown or hidden and that the list tab selection isn't transmitted when an authority batch is submitted. This patch also changes the labels on the "record type" fields to fix the incorrect use of the abbreviated "biblios" in favor of "Bibliographic." To test, apply the patch and go to Cataloging -> Batch record modification - With the "Bibliographic records" selected, click the "Select a list of records" tab." - Select the "Authority records" radio button. - The "Select a list of records" tab should disappear, and the "Upload a file" tab should now be selected." - Select the "Bibliographic records radio button. - The "Select a list of records" tab should reappear, and the "Upload a file" tab should be selected. - Test all combinations of form submissions to confirm that each works correctly: - Bibliographic records by upload, list, and biblionumber entry - Authory records by upload and authority record number entry -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Philip Orr <philip.orr@lmscloud.de> --- Thanks Owen for going above and beyond on this one :) Everything now works as expected and displays correctly. Although... I hope I'm not being too much of a nuisance, but I did find another bug. If you enter batch record modification, select Authority records, select a template and then hit continue without actually uploading a file or entering record numbers, the error message "No records were modified." will be displayed. All correct so far. If you then don't click on "New batch record modification" and instead use the back button in Firefox to go back one page, you will land in batch record modification with Authority records selected but with the tab "Select a list of records" now again displayed and usable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #19 from Philip Orr <philip.orr@lmscloud.de> --- will do! :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149670|0 |1 is obsolete| | --- Comment #20 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 150285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150285&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. This patch adds a "clearfix" snippet of CSS to _mixins.scss copied from Bootstrap. Applied to the active tab pane, this helps in situations where Bootstrap tabs follow a floated element. The patch also wraps tab label strings in <span> to ensure they can be translated. Unrelated: The patch removes an extra </option> from the batch record modification template. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150856&action=edit k -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150285|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150857&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. This patch adds a "clearfix" snippet of CSS to _mixins.scss copied from Bootstrap. Applied to the active tab pane, this helps in situations where Bootstrap tabs follow a floated element. The patch also wraps tab label strings in <span> to ensure they can be translated. Unrelated: The patch removes an extra </option> from the batch record modification template. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Bug 32914 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.