https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77982&action=edit Bug 21243: Regression: SRU mapping popup for bibliographic records is unstyled This patch corrects a regression caused by Bug 21151: The include file which adds CSS to the page was removed from the template. To test, apply the patch and go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button next to "SRU Search fields mapping" - Verify that the pop-up window is correctly styled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, my patch on bug 21552 didn't remove it, only added a parameter - wonder what happened there? +[% INCLUDE 'doc-head-close.inc' popup => 1 %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77982|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 78026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78026&action=edit Bug 21243: Regression: SRU mapping popup for bibliographic records is unstyled This patch corrects a regression caused by Bug 21151: The include file which adds CSS to the page was removed from the template. To test, apply the patch and go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button next to "SRU Search fields mapping" - Verify that the pop-up window is correctly styled. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78026|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 78041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78041&action=edit Bug 21243: Regression: SRU mapping popup for bibliographic records is unstyled This patch corrects a regression caused by Bug 21151: The include file which adds CSS to the page was removed from the template. To test, apply the patch and go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button next to "SRU Search fields mapping" - Verify that the pop-up window is correctly styled. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5)

Is reverting bug 21151 and repushing it correctly also an option? It adds a missing div as well.

The div does seem to have been added, it was a typo during rebase that I deleted the line, I think we can just add it here bug 13618 would make revert more difficult I think -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78044&action=edit Bug 21243: (follow-up) Remove extra '</div>' tag To test: 1 - Go to Admin->Z39/SRU servers 2 - Pick a server or add one 3 - Click 'Modify' button for mappings 4 - Copy the HTML of the popup into w3c validator https://validator.w3.org/#validate_by_input 5 - Note extra closing div 6 - Apply patch 7 - Repeat 8 - Success -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Bug 21243 depends on bug 21151, which changed state. Bug 21151 Summary: SRU search fields mapping pop-up comes up empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21151 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.