[Bug 21041] New: "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Bug ID: 21041 Summary: "Merge patrons" button remains disabled with "Select all" option Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The option to merge selected patron button can't be used if patrons are selected using the "Select all" option link : the button remains grey. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Severity|enhancement |normal Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77019&action=edit Bug 21041: "Merge patrons" button remains disabled with "Select all" option This patch modifies the JavaScript functions for the select all/clear all links so that each action triggers the "change" event, required to enable or disabled the "merge selected patrons" button. To test, apply the patch and perform a patron search which will return multiple results. - Test the "select all" and "clear all" links, and confirm that the "Merge selected patrons" button is enabled and disabled. - Test that checking and unchecking multiple checkboxes still works correctly to enable and disable the button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77019|0 |1 is obsolete| | --- Comment #2 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 77176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77176&action=edit Bug 21041: "Merge patrons" button remains disabled with "Select all" option This patch modifies the JavaScript functions for the select all/clear all links so that each action triggers the "change" event, required to enable or disabled the "merge selected patrons" button. To test, apply the patch and perform a patron search which will return multiple results. - Test the "select all" and "clear all" links, and confirm that the "Merge selected patrons" button is enabled and disabled. - Test that checking and unchecking multiple checkboxes still works correctly to enable and disable the button. Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-luc.lapointe@inLibro | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9302 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 [Bug 9302] Add ability to merge patron records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77176|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77183&action=edit Bug 21041: "Merge patrons" button remains disabled with "Select all" option This patch modifies the JavaScript functions for the select all/clear all links so that each action triggers the "change" event, required to enable or disabled the "merge selected patrons" button. To test, apply the patch and perform a patron search which will return multiple results. - Test the "select all" and "clear all" links, and confirm that the "Merge selected patrons" button is enabled and disabled. - Test that checking and unchecking multiple checkboxes still works correctly to enable and disable the button. Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 9302 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org