[Bug 11601] New: Bootstrap theme has CSS files that do not have LESS counterparts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Bug ID: 11601 Summary: Bootstrap theme has CSS files that do not have LESS counterparts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: wizzyrea@gmail.com Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org We should create parity between the LESS and CSS folders in the Bootstrap theme. CSS should be minified to discourage hand editing. Steps to this available at http://www.lesscss.org/#usage Note that you will need to install Node.js first: http://nodejs.org/ A convenient tool for development with less: https://github.com/jonycheung/Dead-Simple-LESS-Watch-Compiler We should probably also start a wiki page to point people to on how to modify core less files in the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 24631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24631&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Everything looks good except one file: This patch adds "jquery.css," which seems to be a renamed version of jquery.rating.css. Was this an error from the Less compile process? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- hmm possibly, I'll have a check. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11411 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24631|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 25040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25040&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11574 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- Wanted to test, patch does not apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- Owen, No, I looked in master and that jquery file is there in the css for bootstrap, but not in the less, and it's called jquery.css. If it's not supposed to be there, I'll happily remove it. However, the newest attached patch left it alone. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25040|0 |1 is obsolete| | --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 25832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25832&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #8 from Marc Véron <veron@veron.ch> --- To test: Verify the bootstrap theme still works as it should. -- MV: OK In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory -- MV:OK verify that all CSS files have been minified --MV: Not minified files found in koha-tmpl/opac-tmpl/bootstrap/css datatable.css opac.css opac-old.css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11896 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25832|0 |1 is obsolete| | --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 25876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25876&action=edit Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 25880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25880&action=edit [Signed-off] Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified Followed test plan. OK. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- It seems that mixings.css and sco-old.css are not used. Maybe should we remove them too? Owen, could you confirm that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> ---
It seems that mixings.css and sco-old.css are not used. Maybe should we remove them too?
opac-old.css and sco-old.css are unwanted byproducts of my development process and should not have been committed. They should be removed. responsive.css and mixins.css are byproducts of the automatic LESS build process and should not be added (they are currently not in git). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11574 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org