https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186787&action=edit Bug 40860: Consider is_html template notice Change logic of get_notice to fetch the template before GetPreparedLetter. This allows to verify is the template is HTML or not, and act accordingly. Test plan, before applying patch: 1) Enable ILLModule 2) Edit the default ktd ILL partner patron and add a primary email address: <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=16 3) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add some metadata like title and author, after creation click 'Place request with partners'. 'FRL - Walker' should show up as an option. Select that and click 'Send email'. 5) Run the following query to grab the produced email content: $ koha-mysql kohadev $ SELECT content FROM message_queue; 6) Utilize an HTML previewer (to avoid having to send the mail for testing): https://html.onlineviewer.net/ 7) Paste the contents there, notice there's no line breaks when shown as HTML. 8) Apply patch, restart plack, repeat test plan. Notice the HTML preview has appropriate line breaks for each metadata entry. Please note that any other remaining line breaks need to replaced by a <p> tag but that is besides the ill_full_metadata substitution scope of this patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186787|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186788&action=edit Bug 40860: Consider is_html template notice Change logic of get_notice to fetch the template before GetPreparedLetter. This allows to verify is the template is HTML or not, and act accordingly. Test plan, before applying patch: 1) Enable ILLModule 2) Edit the default ktd ILL partner patron and add a primary email address: <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=16 3) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add some metadata like title and author, after creation click 'Place request with partners'. 'FRL - Walker' should show up as an option. Select that and click 'Send email'. 5) Run the following query to grab the produced email content: $ koha-mysql kohadev $ SELECT content FROM message_queue; 6) Utilize an HTML previewer (to avoid having to send the mail for testing): https://html.onlineviewer.net/ 7) Paste the contents there, notice there's no line breaks when shown as HTML. 8) Apply patch, restart plack, repeat test plan. Notice the HTML preview has appropriate line breaks for each metadata entry. Please note that any other remaining line breaks need to replaced by a <p> tag but that is besides the ill_full_metadata substitution scope of this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186788|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 192393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192393&action=edit Bug 40860: Consider is_html template notice Change logic of get_notice to fetch the template before GetPreparedLetter. This allows to verify is the template is HTML or not, and act accordingly. Test plan, before applying patch: 1) Enable ILLModule 2) Edit the default ktd ILL partner patron and add a primary email address: <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=16 3) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add some metadata like title and author, after creation click 'Place request with partners'. 'FRL - Walker' should show up as an option. Select that and click 'Send email'. 5) Run the following query to grab the produced email content: $ koha-mysql kohadev $ SELECT content FROM message_queue; 6) Utilize an HTML previewer (to avoid having to send the mail for testing): https://html.onlineviewer.net/ 7) Paste the contents there, notice there's no line breaks when shown as HTML. 8) Apply patch, restart plack, repeat test plan. Notice the HTML preview has appropriate line breaks for each metadata entry. Please note that any other remaining line breaks need to replaced by a <p> tag but that is besides the ill_full_metadata substitution scope of this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |ILL email notices now release notes| |respect the notice | |template's HTML setting | |when formatting request | |metadata. HTML notices | |display metadata entries on | |separate lines, while | |plain-text notices retain | |their existing formatting. -- You are receiving this mail because: You are watching all bug changes.