[Bug 42044] New: Automatically update LDR/5 for modified records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Bug ID: 42044 Summary: Automatically update LDR/5 for modified records Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org According to https://loc.gov/marc/bibliographic/bdleader.html, the 5th byte of the leader, Record status, could/should be system generated: "System-Generated Elements - Following Leader elements are usually system generated: [...] 05 Record status" Same for authority records. At present, Koha does not automatically update LDR/5 after a record has been modified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 195137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195137&action=edit Bug 42044: Add new system preference 'AutoUpdateRecordStatus' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 195138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195138&action=edit Bug 42044: Automatically update record status (LDR/5) for modified records When a record is modified, record status (LDR/5) should be automatically set to 'c' (Corrected or revised), unless: a) the librarian has manually changed the value to something different from the original one; b) the record was created on the same day by the same librarian (when this can be determined) and the MARC 21 record has no 040 $d subfield. Test plan ========= 1. Create a new bibliographic record. Verify that LDR/5 = 'n' (default). 2. Save the record and modify it. 3. Add 040 $d. 4. Modify the record as a different user. 5. At each step, verify that LDR/5 remains 'n'. 6. Apply the patch; updatedatabase; restart_all. 7. Set AutoUpdateRecordStatus system preference to 'Do'. 8. Repeat steps 1-4 and verify that LDR/5 is set to 'c' when: a) 040 $d is present; b) the record is modified by a different user; c) 008/0–5 is changed to a different date (simulating a modification date different from the creation date). 9. Repeat the whole test procedure for authority records. 10. Set AutoUpdateRecordStatus system preference to 'Don't'. Repeat steps 1-4 and verify that LDR/5 does not change automatically. 11. Check it also for authority records. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #3 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 195139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195139&action=edit Bug 42044: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Sponsorship status|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Summary|Automatically update LDR/5 |Automatically update record |for modified records |status (LDR/5) for modified | |records Comma delimited| |Pontificia Università di list of Sponsors| |San Tommaso d'Aquino | |(Angelicum) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|Pontificia Università di |Pontificia Università di list of Sponsors|San Tommaso d'Aquino |San Tommaso d'Aquino |(Angelicum) |(Angelicum), Pontificia | |Università di San Tommaso | |d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #4 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196269&action=edit Bug 42044: Add new system preference 'AutoUpdateRecordStatus' Patch from commit 72eb3ff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196270&action=edit Bug 42044: Automatically update record status (LDR/5) for modified records When a record is modified, record status (LDR/5) should be automatically set to 'c' (Corrected or revised), unless: a) the librarian has manually changed the value to something different from the original one; b) the record was created on the same day by the same librarian (when this can be determined) and the MARC 21 record has no 040 $d subfield. Test plan ========= 1. Create a new bibliographic record. Verify that LDR/5 = 'n' (default). 2. Save the record and modify it. 3. Add 040 $d. 4. Modify the record as a different user. 5. At each step, verify that LDR/5 remains 'n'. 6. Apply the patch; updatedatabase; restart_all. 7. Set AutoUpdateRecordStatus system preference to 'Do'. 8. Repeat steps 1-4 and verify that LDR/5 is set to 'c' when: a) 040 $d is present; b) the record is modified by a different user; c) 008/0–5 is changed to a different date (simulating a modification date different from the creation date). 9. Repeat the whole test procedure for authority records. 10. Set AutoUpdateRecordStatus system preference to 'Don't'. Repeat steps 1-4 and verify that LDR/5 does not change automatically. 11. Check it also for authority records. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #6 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196271&action=edit Bug 42044: Unit tests Patch from commit a4ad86c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42039 [Bug 42039] Properly set LDR/5 for deleted bibliographic records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196271|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #7 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196333&action=edit Bug 42044: Unit tests Patch from commit d4c9edc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|Pontificia Università di |Pontificia Università di list of Sponsors|San Tommaso d'Aquino |San Tommaso d'Aquino |(Angelicum), Pontificia |(Angelicum) |Università di San Tommaso | |d'Aquino (Angelicum) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #8 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196382&action=edit Bug 42044: Automatically update record status (LDR/5) for modified records When a record is modified, record status (LDR/5) should be automatically set to 'c' (Corrected or revised), unless: a) the librarian has manually changed the value to something different from the original one; b) the record was created on the same day by the same librarian (when this can be determined) and the MARC 21 record has no 040 $d subfield. Test plan ========= 1. Create a new bibliographic record. Verify that LDR/5 = 'n' (default). 2. Save the record and modify it. 3. Add 040 $d. 4. Modify the record as a different user. 5. At each step, verify that LDR/5 remains 'n'. 6. Apply the patch; updatedatabase; restart_all. 7. Set AutoUpdateRecordStatus system preference to 'Do'. 8. Repeat steps 1-4 and verify that LDR/5 is set to 'c' when: a) 040 $d is present; b) the record is modified by a different user; c) 008/0–5 is changed to a different date (simulating a modification date different from the creation date). 9. Repeat the whole test procedure for authority records. 10. Set AutoUpdateRecordStatus system preference to 'Don't'. Repeat steps 1-4 and verify that LDR/5 does not change automatically. 11. Check it also for authority records. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #9 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196383&action=edit Bug 42044: Unit tests Patch from commit 6163e26 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- I think this is the first time I've seen a patch still apply perfectly after three months *except* for the unit tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196269|0 |1 is obsolete| | Attachment #196382|0 |1 is obsolete| | Attachment #196383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #11 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 207437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207437&action=edit Bug 42044: Add new system preference 'AutoUpdateRecordStatus' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #12 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 207438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207438&action=edit Bug 42044: Automatically update record status (LDR/5) for modified records When a record is modified, record status (LDR/5) should be automatically set to 'c' (Corrected or revised), unless: a) the librarian has manually changed the value to something different from the original one; b) the record was created on the same day by the same librarian (when this can be determined) and the MARC 21 record has no 040 $d subfield. Test plan ========= 1. Create a new bibliographic record. Verify that LDR/5 = 'n' (default). 2. Save the record and modify it. 3. Add 040 $d. 4. Modify the record as a different user. 5. At each step, verify that LDR/5 remains 'n'. 6. Apply the patch; updatedatabase; restart_all. 7. Set AutoUpdateRecordStatus system preference to 'Do'. 8. Repeat steps 1-4 and verify that LDR/5 is set to 'c' when: a) 040 $d is present; b) the record is modified by a different user; c) 008/0–5 is changed to a different date (simulating a modification date different from the creation date). 9. Repeat the whole test procedure for authority records. 10. Set AutoUpdateRecordStatus system preference to 'Don't'. Repeat steps 1-4 and verify that LDR/5 does not change automatically. 11. Check it also for authority records. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #13 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 207439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207439&action=edit Bug 42044: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42044 --- Comment #14 from Janusz Kaczmarek <januszop@gmail.com> --- Rebased. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org