https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 153623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153623&action=edit Bug 34307: Update plugin template to match master conventions This change uses WRAPPER to build the breadcrumbs and updates the plugin template to follow some other master conventions like differentiating between Administration and Tools for plugins. Test plan: 0. Apply patch 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Bug 34307 depends on bug 31339, which changed state. Bug 31339 Summary: Add Template::Toolkit WRAPPER for Koha Tool Plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153623|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 154324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154324&action=edit Bug 34307: Update plugin template to match master conventions This change uses WRAPPER to build the breadcrumbs and updates the plugin template to follow some other master conventions like differentiating between Administration and Tools for plugins. Test plan: 0. Apply patch 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154324|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 154673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154673&action=edit Bug 34307: Update plugin template to match master conventions This change uses WRAPPER to build the breadcrumbs and updates the plugin template to follow some other master conventions like differentiating between Administration and Tools for plugins. Test plan: 0. Apply patch 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! So second signoff. I've reached for help about reviewing the code. follow-up to improve i18n But there is something weird, there is a part I couldn't change to improve the extracted strings. I did this: ``` <title> [% IF ( plugin_title ) %][% plugin_title | html %] › [% END %] <span>Plugins</span> › [% IF ( method == 'tool' ) %] <span>Tools</span> [% ELSE %] <span>Administration</span> [% END %] › <span>Koha</span> </title> ``` and got this as a diff of the translation files ``` misc/translator/Koha-staff-prog.pot +msgid "%s%s › %s <span>Plugins</span> › %s <span>Tools</span> %s <span>Administration</span> %s › <span>Koha</span> " misc/translator/po/fr-FR-staff-prog.po +"%s%s › %s <span>Plugins</span> › %s <span>Tools</span> %s " +"<span>Administration</span> %s › <span>Koha</span> " +msgstr "Plugins › Outils › Koha " ``` But I see in the diff that I have individual occurrences of Plugins, Tools, Administration, Koha linked with wrapper-staff-tool-plugin.inc:7 So it's liked it worked, and didn't work at the same time. I checked and the bad occurences aren't in the commented out section of the .po. And they contain the <span> so it's not the remains of the previous version. Any hint? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #7)

But I see in the diff that I have individual occurrences of Plugins, Tools, Administration, Koha linked with wrapper-staff-tool-plugin.inc:7

So it's liked it worked, and didn't work at the same time. I checked and the bad occurences aren't in the commented out section of the .po. And they contain the <span> so it's not the remains of the previous version.

Any hint?

I have no idea about translations. I just followed the pattern that I saw. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154674|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154678&action=edit Bug 34307: (QA follow-up) add <span> to have cleaner strings for i18n Cleaner strings are extracted this way. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- i18n is nice now, thanks Owen for the follow-up :D And thanks for confirming that the code is ok and the adjustments. So we are good to go: it works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.