[Bug 24857] New: Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Bug ID: 24857 Summary: Add ability to create "Volumes" for records, and assign items to volumes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. This but is to add just the volume management itself, which no functionality tied to volumes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 [Bug 24860] Add ability to place volume level holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100652&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100653&action=edit Bug 24857: Add Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100654&action=edit Bug 24857: Add Koha Object(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100655&action=edit Bug 24857: Add Object Methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100656&action=edit Bug 24857: API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100657&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100658&action=edit Bug 24857: Implement volume related controllers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100659&action=edit Bug 24857: Add volume management to detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100660&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100661&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 100662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100662&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100652|0 |1 is obsolete| | Attachment #100653|0 |1 is obsolete| | Attachment #100654|0 |1 is obsolete| | Attachment #100655|0 |1 is obsolete| | Attachment #100656|0 |1 is obsolete| | Attachment #100657|0 |1 is obsolete| | Attachment #100658|0 |1 is obsolete| | Attachment #100659|0 |1 is obsolete| | Attachment #100660|0 |1 is obsolete| | Attachment #100661|0 |1 is obsolete| | Attachment #100662|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101637&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101638&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101639&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101640&action=edit Bug 24857: Add Koha Object(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101641&action=edit Bug 24857: Add Object Methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101642&action=edit Bug 24857: API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101643&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101644&action=edit Bug 24857: Implement volume related controllers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101645&action=edit Bug 24857: Add volume management to detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101646&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101647&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101648&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101637|0 |1 is obsolete| | Attachment #101638|0 |1 is obsolete| | Attachment #101639|0 |1 is obsolete| | Attachment #101640|0 |1 is obsolete| | Attachment #101641|0 |1 is obsolete| | Attachment #101642|0 |1 is obsolete| | Attachment #101643|0 |1 is obsolete| | Attachment #101644|0 |1 is obsolete| | Attachment #101645|0 |1 is obsolete| | Attachment #101646|0 |1 is obsolete| | Attachment #101647|0 |1 is obsolete| | Attachment #101648|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101650&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101651&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101652&action=edit Bug 24857: Add Koha Object(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101653&action=edit Bug 24857: Add Object Methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101654&action=edit Bug 24857: API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101655&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101656&action=edit Bug 24857: Implement volume related controllers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101657&action=edit Bug 24857: Add volume management to detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101658&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101659&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101660&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101661&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101650|0 |1 is obsolete| | Attachment #101651|0 |1 is obsolete| | Attachment #101652|0 |1 is obsolete| | Attachment #101653|0 |1 is obsolete| | Attachment #101654|0 |1 is obsolete| | Attachment #101655|0 |1 is obsolete| | Attachment #101656|0 |1 is obsolete| | Attachment #101657|0 |1 is obsolete| | Attachment #101658|0 |1 is obsolete| | Attachment #101659|0 |1 is obsolete| | Attachment #101660|0 |1 is obsolete| | Attachment #101661|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101670&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101671&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101672&action=edit Bug 24857: Add Koha Object(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101673&action=edit Bug 24857: Add Object Methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101674&action=edit Bug 24857: API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101675&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101676&action=edit Bug 24857: Implement volume related controllers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101677&action=edit Bug 24857: Add volume management to detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101678&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101679&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101680&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101681&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #48 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Getting an ISE because volume info is not cleared from items when volume is deleted -add items to volume -delete volume -see that items still show as in deleted volume -select items, see you still have volume-related links even though there are no volumes -click "add/modify volume" and receive ISE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101670|0 |1 is obsolete| | Attachment #101671|0 |1 is obsolete| | Attachment #101672|0 |1 is obsolete| | Attachment #101673|0 |1 is obsolete| | Attachment #101674|0 |1 is obsolete| | Attachment #101675|0 |1 is obsolete| | Attachment #101676|0 |1 is obsolete| | Attachment #101677|0 |1 is obsolete| | Attachment #101678|0 |1 is obsolete| | Attachment #101679|0 |1 is obsolete| | Attachment #101680|0 |1 is obsolete| | Attachment #101681|0 |1 is obsolete| | --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101730&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101731&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101732&action=edit Bug 24857: Add Koha Object(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101733&action=edit Bug 24857: Add Object Methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101734&action=edit Bug 24857: API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101735&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101736&action=edit Bug 24857: Implement volume related controllers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101737&action=edit Bug 24857: Add volume management to detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101738&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101739&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101740&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101741&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101730|0 |1 is obsolete| | --- Comment #61 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101752&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101731|0 |1 is obsolete| | --- Comment #62 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101753&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101732|0 |1 is obsolete| | --- Comment #63 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101754&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101733|0 |1 is obsolete| | --- Comment #64 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101755&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101734|0 |1 is obsolete| | --- Comment #65 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101756&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101735|0 |1 is obsolete| | --- Comment #66 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101757&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101736|0 |1 is obsolete| | --- Comment #67 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101758&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101737|0 |1 is obsolete| | --- Comment #68 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101759&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101738|0 |1 is obsolete| | --- Comment #69 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101760&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101739|0 |1 is obsolete| | --- Comment #70 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101761&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101740|0 |1 is obsolete| | --- Comment #71 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101762&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101741|0 |1 is obsolete| | --- Comment #72 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 101763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101763&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Claudio <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #73 from David Cook <dcook@prosentient.com.au> --- This sounds odd. What's a volume mean in this context? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #74 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- A volume is a grouping of items within a bib. See bug 24860 for one implementation (patrons can place hold on a volume, get first available item within that volume). Imagine, say, a bib containing multiple copies of a multi-volume series. Patron wants whichever copy of Book 1 comes in first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Laura Horgan <horganl@middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl@middlesex.mass.edu --- Comment #75 from Laura Horgan <horganl@middlesex.mass.edu> --- When will this be added to the system and will ther be a way to identify and possibly migrate or create volumes for items in the system cuurently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could this also be used in context of bound serials (all issues of a year bound into one volume)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #77 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Laura - It's hard to say when this will be in Koha, as it has not yet gone through QA. This patch doesn't include a mechanism to automatically assign items to volumes, but existing items can be added to volumes manually. Katrin - Yes, absolutely! I can see ways in which defining volumes of periodicals would be useful. Though the only functionality beyond the creation of a volume that's currently being worked on is that in bug 24860. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #78 from David Cook <dcook@prosentient.com.au> --- (In reply to Andrew Fuerste-Henry from comment #74)
A volume is a grouping of items within a bib. See bug 24860 for one implementation (patrons can place hold on a volume, get first available item within that volume). Imagine, say, a bib containing multiple copies of a multi-volume series. Patron wants whichever copy of Book 1 comes in first.
That's interesting. I wonder if we should use more generic terminology like "item_group" instead of "volume". Perhaps each group could have a translatable label assigned so you could choose "Volume", "Kit", etc. This might be useful for libraries that provide kits, toy bags, computers (with peripherals). Individual pieces could be barcoded and be items in their own right, but be grouped together. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #79 from Laura Horgan <horganl@middlesex.mass.edu> --- In our last system it was called parts and was used for books dvds kits, etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #80 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Y'all might have a look at bug 24023, which adds a way to group items to check out all together. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101752|0 |1 is obsolete| | Attachment #101753|0 |1 is obsolete| | Attachment #101754|0 |1 is obsolete| | Attachment #101755|0 |1 is obsolete| | Attachment #101756|0 |1 is obsolete| | Attachment #101757|0 |1 is obsolete| | Attachment #101758|0 |1 is obsolete| | Attachment #101759|0 |1 is obsolete| | Attachment #101760|0 |1 is obsolete| | Attachment #101761|0 |1 is obsolete| | Attachment #101762|0 |1 is obsolete| | Attachment #101763|0 |1 is obsolete| | --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104952&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104953&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #83 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104954&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104955&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104956&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104957&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104958&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104959&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104960&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104961&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104962&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #92 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104963&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #93 from Laura Horgan <horganl@middlesex.mass.edu> --- I see this was signed off... What version of Koha will it be available? Not sure if there is somewhere I need to look to see this information... If so please let me know so I won't have to ask this question again. Thanks in advance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104964&action=edit Bug 24857: Copy the volume to the item's enumchron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104966&action=edit Bug 24857: Add user permission for volumes management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Laura Horgan from comment #93)
I see this was signed off... What version of Koha will it be available? Not sure if there is somewhere I need to look to see this information... If so please let me know so I won't have to ask this question again. Thanks in advance
Hi Laura, after sign off this still needs to go through QA. For 20.05 it's too late, as we have already entered 'feature freeze' (focusing on bug fixing and stabilizing) and 'string freeze' (no GUI changes for translations to catch up) for this release. The next one this could be released with is 22.11. Koha doesn't do road maps, but for every version we include what it's ready on time. So the bug and the status is the best way to see what's going on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104952|0 |1 is obsolete| | --- Comment #97 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106728&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104953|0 |1 is obsolete| | --- Comment #98 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106729&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104954|0 |1 is obsolete| | --- Comment #99 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106730&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104955|0 |1 is obsolete| | --- Comment #100 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106731&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104956|0 |1 is obsolete| | --- Comment #101 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106732&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104957|0 |1 is obsolete| | --- Comment #102 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106733&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104958|0 |1 is obsolete| | --- Comment #103 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106734&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104959|0 |1 is obsolete| | --- Comment #104 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106735&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104960|0 |1 is obsolete| | --- Comment #105 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106736&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104961|0 |1 is obsolete| | --- Comment #106 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106737&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104962|0 |1 is obsolete| | --- Comment #107 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106738&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104963|0 |1 is obsolete| | --- Comment #108 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106739&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104964|0 |1 is obsolete| | --- Comment #109 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106740&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104966|0 |1 is obsolete| | --- Comment #110 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106741&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #111 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches don't apply cleanly right now, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24857: Update Database Applying: Bug 24857: Add new Schema files Applying: Bug 24857: Add Koha Object(s) Applying: Bug 24857: Add Object Methods Applying: Bug 24857: API spec Applying: Bug 24857: Koha::Biblio::Volume methods Applying: Bug 24857: Implement volume related controllers Applying: Bug 24857: Add volume management to detail.pl Applying: Bug 24857: Add ability to attach newly cataloged items to a volume Applying: Bug 24857: Add ability to manage item's volumes from detail.pl .git/rebase-apply/patch:121: trailing whitespace. if($query->cookie("holdfor")){ error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt). error: could not build fake ancestor Patch failed at 0001 Bug 24857: Add ability to manage item's volumes from detail.pl The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24857-Add-ability-to-manage-items-volumes-from-GJYBG0.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106728|0 |1 is obsolete| | Attachment #106729|0 |1 is obsolete| | Attachment #106730|0 |1 is obsolete| | Attachment #106731|0 |1 is obsolete| | Attachment #106732|0 |1 is obsolete| | Attachment #106733|0 |1 is obsolete| | Attachment #106734|0 |1 is obsolete| | Attachment #106735|0 |1 is obsolete| | Attachment #106736|0 |1 is obsolete| | Attachment #106737|0 |1 is obsolete| | Attachment #106738|0 |1 is obsolete| | Attachment #106739|0 |1 is obsolete| | Attachment #106740|0 |1 is obsolete| | Attachment #106741|0 |1 is obsolete| | --- Comment #112 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108443&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108444&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #114 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108445&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108446&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #116 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108447&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #117 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108448&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #118 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108449&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #119 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108450&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #120 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108451&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #121 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108452&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #122 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108453&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108454&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #124 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108455&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #125 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108456&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #126 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one is a little scary already, but going in for a first review :) 1) QA script Several issues found, please fix: FAIL Koha/Biblio/Volume.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL Koha/Biblio/Volume/Item.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Biblio/Volume/Item.pm FAIL Koha/Biblio/Volume/Items.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Biblio/Volume/Items.pm FAIL Koha/Biblio/Volumes.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Biblio/Volumes.pm FAIL Koha/REST/V1/Biblios/Volumes.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL Koha/REST/V1/Biblios/Volumes/Items.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL Koha/Schema/Result/Volume.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL Koha/Schema/Result/VolumeItem.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 1446) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL filters missing_filter at line 20 ( var has_volumes = [% volumes.count %];) FAIL js_in_body 2) Doubled up use statement in Biblio.pm +use Koha::Biblio::Volumes; +use Koha::Biblio::Volumes; 3) REST API I'd love to have Tomas take a look on the REST API bits here. 4) sysprefs.sql After all the use statements were so nicely alphabetically resorted, THIS? +('EnableVolumes','0','','Enable volumes feature','YesNo'), ('viewISBD','1','','Allow display of ISBD view of bibiographic records','YesNo'), ;) 5) Pref (question) Enable|Don't enable volumes feature to allow collecting groups of items on a record into volumes. Does it mean the items have to be from the same record or could they be from different ones? 6) Table configuration The new volumn column on the holdings table needs to be added to the table configuration options. 7) GUI "Create new" on the items table would work nicer as "Create new volume" or "New volume" to give context to translators and for better accessibility. Future improvements: It might be nice to offer a kind of grouped view for the items in volumes... but I am not sure yet how this would work best. It might be nice to show the volumes in the OPAC as well. 8) Use case and future plans? Can you tell a bit about in what context or use case this partner is using this? Serials? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I've checked the test plan on the dependent bug now too and am still a little confused about the use case for this. Reading "volume" made me think of something that would be used for serial issues bound together into one volume (serials, binding) But this doesn't seem to be the case with how the volume hold feature works. Does this more work like a "Hold group" maybe? One item out of the group appears to satisfy the hold - so maybe "Group" would be a better word to describe the idea? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108443|0 |1 is obsolete| | Attachment #108444|0 |1 is obsolete| | Attachment #108445|0 |1 is obsolete| | Attachment #108446|0 |1 is obsolete| | Attachment #108447|0 |1 is obsolete| | Attachment #108448|0 |1 is obsolete| | Attachment #108449|0 |1 is obsolete| | Attachment #108450|0 |1 is obsolete| | Attachment #108451|0 |1 is obsolete| | Attachment #108452|0 |1 is obsolete| | Attachment #108453|0 |1 is obsolete| | Attachment #108454|0 |1 is obsolete| | Attachment #108455|0 |1 is obsolete| | Attachment #108456|0 |1 is obsolete| | --- Comment #128 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108666&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #129 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108667&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #130 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108668&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #131 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108669&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #132 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108670&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #133 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108671&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #134 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108672&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #135 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108673&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #136 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108674&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #137 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108675&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #138 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108676&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #139 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108677&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #140 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108678&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #141 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108679&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #142 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108680&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #143 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108681&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #144 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108682&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #145 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108683&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #146 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108684&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #147 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108685&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #148 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108686&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #149 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #126)
This one is a little scary already, but going in for a first review :)
1) QA script Fixed!
2) Doubled up use statement in Biblio.pm
Fixed!
3) REST API
I'd love to have Tomas take a look on the REST API bits here.
I'll ask Tomas to take a look!
4) sysprefs.sql
Fixed!
5) Pref (question)
Enable|Don't enable volumes feature to allow collecting groups of items on a record into volumes.
Does it mean the items have to be from the same record or could they be from different ones?
We decided early on that volumes would have contain only items within the same record.
6) Table configuration
The new volumn column on the holdings table needs to be added to the table configuration options.
This table is not a datatable so that doesn't really apply.
7) GUI
"Create new" on the items table would work nicer as "Create new volume" or "New volume" to give context to translators and for better accessibility.
Fixed!
Future improvements: It might be nice to offer a kind of grouped view for the items in volumes... but I am not sure yet how this would work best. It might be nice to show the volumes in the OPAC as well.
Agreed. If volume management turns out to be popular, that would be an easy extension to this work.
8) Use case and future plans?
Can you tell a bit about in what context or use case this partner is using this? Serials?
Our current and only use case at this time is for volume level holds. Some libraries keep different volumes on the same record ( imagine different seasons of a TV series ). In these cases, a bib level hold won't work if you only want Season 1, but if there are 3 copies of season one, you wouldn't want an item level hold either. Volume level holds solve this problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #127)
Hm, I've checked the test plan on the dependent bug now too and am still a little confused about the use case for this.
Reading "volume" made me think of something that would be used for serial issues bound together into one volume (serials, binding) But this doesn't seem to be the case with how the volume hold feature works.
That is correct. The term volume is used here because that is what most if not all other ILSs use.
Does this more work like a "Hold group" maybe? One item out of the group appears to satisfy the hold - so maybe "Group" would be a better word to describe the idea?
You are correct! I described it in a bit more detail in my previous comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26275 [Bug 26275] Deleting item should not automatically delete volume -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26276 [Bug 26276] When merging biblios with volumes, preserve all volumes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #151 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle,
3) REST API
I'd love to have Tomas take a look on the REST API bits here.
I'll ask Tomas to take a look!
Waiting for Tomas to comment then :)
6) Table configuration
The new volumn column on the holdings table needs to be added to the table configuration options.
This table is not a datatable so that doesn't really apply.
That one is a misunderstanding I think: The items table on the detail page is controlled by the table configuration settings and the volume column appears there as a new column. Table configuration > catalog > holdings_table 9) Unit tests I am a quite suspicious that there are no unit tests at all... We have new things in Biblio.pm, Items.pm and also new modules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108666|0 |1 is obsolete| | Attachment #108667|0 |1 is obsolete| | Attachment #108668|0 |1 is obsolete| | Attachment #108669|0 |1 is obsolete| | Attachment #108670|0 |1 is obsolete| | Attachment #108671|0 |1 is obsolete| | Attachment #108672|0 |1 is obsolete| | Attachment #108673|0 |1 is obsolete| | Attachment #108674|0 |1 is obsolete| | Attachment #108675|0 |1 is obsolete| | Attachment #108676|0 |1 is obsolete| | Attachment #108677|0 |1 is obsolete| | Attachment #108678|0 |1 is obsolete| | Attachment #108679|0 |1 is obsolete| | Attachment #108680|0 |1 is obsolete| | Attachment #108681|0 |1 is obsolete| | Attachment #108682|0 |1 is obsolete| | Attachment #108683|0 |1 is obsolete| | Attachment #108684|0 |1 is obsolete| | Attachment #108685|0 |1 is obsolete| | Attachment #108686|0 |1 is obsolete| | --- Comment #152 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109074&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #153 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109075&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #154 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109076&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #155 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109077&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #156 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109078&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #157 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109079&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109080&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #159 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109081&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #160 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109082&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #161 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109083&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #162 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109084&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #163 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109085&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #164 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109086&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #165 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109087&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #166 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109088&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #167 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109089&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #168 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109090&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #169 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109091&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #170 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109092&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #171 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109093&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #172 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109094&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #173 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #151)
Hi Kyle,
3) REST API
I'd love to have Tomas take a look on the REST API bits here.
I'll ask Tomas to take a look!
Waiting for Tomas to comment then :)
6) Table configuration
The new volumn column on the holdings table needs to be added to the table configuration options.
This table is not a datatable so that doesn't really apply.
That one is a misunderstanding I think: The items table on the detail page is controlled by the table configuration settings and the volume column appears there as a new column.
Table configuration > catalog > holdings_table
I'll take a look!
9) Unit tests
I am a quite suspicious that there are no unit tests at all... We have new things in Biblio.pm, Items.pm and also new modules.
I'll add unit tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109074|0 |1 is obsolete| | Attachment #109075|0 |1 is obsolete| | Attachment #109076|0 |1 is obsolete| | Attachment #109077|0 |1 is obsolete| | Attachment #109078|0 |1 is obsolete| | Attachment #109079|0 |1 is obsolete| | Attachment #109080|0 |1 is obsolete| | Attachment #109081|0 |1 is obsolete| | Attachment #109082|0 |1 is obsolete| | Attachment #109083|0 |1 is obsolete| | Attachment #109084|0 |1 is obsolete| | Attachment #109085|0 |1 is obsolete| | Attachment #109086|0 |1 is obsolete| | Attachment #109087|0 |1 is obsolete| | Attachment #109088|0 |1 is obsolete| | Attachment #109089|0 |1 is obsolete| | Attachment #109090|0 |1 is obsolete| | Attachment #109091|0 |1 is obsolete| | Attachment #109092|0 |1 is obsolete| | Attachment #109093|0 |1 is obsolete| | Attachment #109094|0 |1 is obsolete| | --- Comment #174 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109795&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #175 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109796&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #176 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109797&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #177 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109798&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #178 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109799&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #179 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109800&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #180 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109801&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #181 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109802&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #182 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109803&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #183 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109804&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #184 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109805&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #185 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109806&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #186 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109807&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #187 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109808&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #188 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109809&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #189 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109810&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #190 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109811&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #191 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109812&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #192 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109813&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #193 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109814&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #194 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109815&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #195 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109894&action=edit Bug 24857: (QA follow-up) Add volume to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109795|0 |1 is obsolete| | Attachment #109796|0 |1 is obsolete| | Attachment #109797|0 |1 is obsolete| | Attachment #109798|0 |1 is obsolete| | Attachment #109799|0 |1 is obsolete| | Attachment #109800|0 |1 is obsolete| | Attachment #109801|0 |1 is obsolete| | Attachment #109802|0 |1 is obsolete| | Attachment #109803|0 |1 is obsolete| | Attachment #109804|0 |1 is obsolete| | Attachment #109805|0 |1 is obsolete| | Attachment #109806|0 |1 is obsolete| | Attachment #109807|0 |1 is obsolete| | Attachment #109808|0 |1 is obsolete| | Attachment #109809|0 |1 is obsolete| | Attachment #109810|0 |1 is obsolete| | Attachment #109811|0 |1 is obsolete| | Attachment #109812|0 |1 is obsolete| | Attachment #109813|0 |1 is obsolete| | Attachment #109814|0 |1 is obsolete| | Attachment #109815|0 |1 is obsolete| | Attachment #109894|0 |1 is obsolete| | --- Comment #196 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109901&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #197 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109902&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #198 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109903&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #199 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109904&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #200 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109905&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #201 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109906&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #202 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109907&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #203 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109908&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #204 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109909&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #205 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109910&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #206 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109911&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #207 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109912&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #208 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109913&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #209 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109914&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #210 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109915&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #211 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109916&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #212 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109917&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #213 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109918&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #214 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109919&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #215 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109920&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #216 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109921&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #217 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109922&action=edit Bug 24857: (QA follow-up) Add volume to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #218 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109923&action=edit Bug 24857: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #219 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, tests pass, but there is a db error when you run them: [2020-09-12 21:06:37.69672] [26709] [debug] POST "/api/v1/biblios/XXX/volumes" (57471cdc) [2020-09-12 21:06:37.69813] [26709] [debug] Routing to controller "Koha::REST::V1::Auth" and action "under" [2020-09-12 21:06:37.72833] [26709] [debug] Routing to controller "Koha::REST::V1::Biblios::Volumes" and action "add" DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`volumes`, CONSTRAINT `volumes_ibfk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `volumes` ( `biblionumber`, `created_on`, `description`, `display_order`, `updated_on`) VALUES ( ?, NOW(), ?, ?, current_timestamp )" with ParamValues: 0=0, 1="Vol 1", 2=1] at /home/vagrant/kohaclone/Koha/Object.pm line 166 [2020-09-12 21:06:37.73397] [26709] [debug] 409 Conflict (0.037233s, 26.858/s) ok 5 - POST //jFfMRdUyfmSrbUO5TWioGEhp2HSDQXGSqy01hFdFW0DUU9utfXIyBXUNR:thePassword123@/api/v1/biblios/XXX/volumes ok 6 - SWAGGER3.2.1 ok 2 - volumes add() tests Can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26931 [Bug 26931] Volumes tab should show all volumes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109901|0 |1 is obsolete| | Attachment #109902|0 |1 is obsolete| | Attachment #109903|0 |1 is obsolete| | Attachment #109904|0 |1 is obsolete| | Attachment #109905|0 |1 is obsolete| | Attachment #109906|0 |1 is obsolete| | Attachment #109907|0 |1 is obsolete| | Attachment #109908|0 |1 is obsolete| | Attachment #109909|0 |1 is obsolete| | Attachment #109910|0 |1 is obsolete| | Attachment #109911|0 |1 is obsolete| | Attachment #109912|0 |1 is obsolete| | Attachment #109913|0 |1 is obsolete| | Attachment #109914|0 |1 is obsolete| | Attachment #109915|0 |1 is obsolete| | Attachment #109916|0 |1 is obsolete| | Attachment #109917|0 |1 is obsolete| | Attachment #109918|0 |1 is obsolete| | Attachment #109919|0 |1 is obsolete| | Attachment #109920|0 |1 is obsolete| | Attachment #109921|0 |1 is obsolete| | Attachment #109922|0 |1 is obsolete| | Attachment #109923|0 |1 is obsolete| | --- Comment #220 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113136&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113136|0 |1 is obsolete| | --- Comment #221 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113137&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #222 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113138&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #223 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113139&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #224 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113140&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #225 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113141&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #226 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113142&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #227 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113143&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #228 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113144&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #229 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113145&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #230 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113146&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #231 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113147&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #232 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113148&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #233 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113149&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #234 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113150&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #235 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113151&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #236 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113152&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #237 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113153&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #238 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113154&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #239 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113155&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #240 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113156&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #241 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113157&action=edit Bug 24857: (QA follow-up) Add volume to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #242 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113158&action=edit Bug 24857: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #243 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113159&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #244 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113160&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113137|0 |1 is obsolete| | Attachment #113138|0 |1 is obsolete| | Attachment #113139|0 |1 is obsolete| | Attachment #113140|0 |1 is obsolete| | Attachment #113141|0 |1 is obsolete| | Attachment #113142|0 |1 is obsolete| | Attachment #113143|0 |1 is obsolete| | Attachment #113144|0 |1 is obsolete| | Attachment #113145|0 |1 is obsolete| | Attachment #113146|0 |1 is obsolete| | Attachment #113147|0 |1 is obsolete| | Attachment #113148|0 |1 is obsolete| | Attachment #113149|0 |1 is obsolete| | Attachment #113150|0 |1 is obsolete| | Attachment #113151|0 |1 is obsolete| | Attachment #113152|0 |1 is obsolete| | Attachment #113153|0 |1 is obsolete| | Attachment #113154|0 |1 is obsolete| | Attachment #113155|0 |1 is obsolete| | Attachment #113156|0 |1 is obsolete| | Attachment #113157|0 |1 is obsolete| | Attachment #113158|0 |1 is obsolete| | Attachment #113159|0 |1 is obsolete| | Attachment #113160|0 |1 is obsolete| | --- Comment #245 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113168&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #246 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113169&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #247 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113170&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #248 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113171&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #249 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113172&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #250 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113173&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #251 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113174&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #252 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113175&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #253 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113176&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #254 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113177&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #255 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113178&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #256 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113179&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #257 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113180&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #258 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113181&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #259 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113182&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #260 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113183&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #261 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113184&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #262 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113185&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #263 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113186&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #264 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113187&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #265 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113188&action=edit Bug 24857: (QA follow-up) Add volume to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #266 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113189&action=edit Bug 24857: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #267 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113190&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #268 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113191&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #269 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #219)
Hi Kyle,
tests pass, but there is a db error when you run them:
[2020-09-12 21:06:37.69672] [26709] [debug] POST "/api/v1/biblios/XXX/volumes" (57471cdc) [2020-09-12 21:06:37.69813] [26709] [debug] Routing to controller "Koha::REST::V1::Auth" and action "under" [2020-09-12 21:06:37.72833] [26709] [debug] Routing to controller "Koha::REST::V1::Biblios::Volumes" and action "add" DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`volumes`, CONSTRAINT `volumes_ibfk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `volumes` ( `biblionumber`, `created_on`, `description`, `display_order`, `updated_on`) VALUES ( ?, NOW(), ?, ?, current_timestamp )" with ParamValues: 0=0, 1="Vol 1", 2=1] at /home/vagrant/kohaclone/Koha/Object.pm line 166 [2020-09-12 21:06:37.73397] [26709] [debug] 409 Conflict (0.037233s, 26.858/s) ok 5 - POST //jFfMRdUyfmSrbUO5TWioGEhp2HSDQXGSqy01hFdFW0DUU9utfXIyBXUNR:thePassword123@/ api/v1/biblios/XXX/volumes ok 6 - SWAGGER3.2.1 ok 2 - volumes add() tests
Can you please check?
That error is expected, as we are testing adding a volume for an invalid biblionumber. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27300 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #270 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As this had been waiting so long I've tried to fix the conflict in kohastructure.sql myself, but then ran into the next one in paths.json... Can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113168|0 |1 is obsolete| | Attachment #113169|0 |1 is obsolete| | Attachment #113170|0 |1 is obsolete| | Attachment #113171|0 |1 is obsolete| | Attachment #113172|0 |1 is obsolete| | Attachment #113173|0 |1 is obsolete| | Attachment #113174|0 |1 is obsolete| | Attachment #113175|0 |1 is obsolete| | Attachment #113176|0 |1 is obsolete| | Attachment #113177|0 |1 is obsolete| | Attachment #113178|0 |1 is obsolete| | Attachment #113179|0 |1 is obsolete| | Attachment #113180|0 |1 is obsolete| | Attachment #113181|0 |1 is obsolete| | Attachment #113182|0 |1 is obsolete| | Attachment #113183|0 |1 is obsolete| | Attachment #113184|0 |1 is obsolete| | Attachment #113185|0 |1 is obsolete| | Attachment #113186|0 |1 is obsolete| | Attachment #113187|0 |1 is obsolete| | Attachment #113188|0 |1 is obsolete| | Attachment #113189|0 |1 is obsolete| | Attachment #113190|0 |1 is obsolete| | Attachment #113191|0 |1 is obsolete| | --- Comment #271 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120495&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #272 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120496&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #273 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120497&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #274 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120498&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #275 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120499&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #276 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120500&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #277 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120501&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #278 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120502&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #279 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120503&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #280 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120504&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #281 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120505&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #282 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120506&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #283 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120507&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #284 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120508&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #285 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120509&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #286 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120510&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #287 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120511&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #288 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120512&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #289 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120513&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #290 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120514&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #291 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120515&action=edit Bug 24857: (QA follow-up) Add volume to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #292 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120516&action=edit Bug 24857: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #293 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120517&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #294 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120518&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24023 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120495|0 |1 is obsolete| | Attachment #120496|0 |1 is obsolete| | Attachment #120497|0 |1 is obsolete| | Attachment #120498|0 |1 is obsolete| | Attachment #120499|0 |1 is obsolete| | Attachment #120500|0 |1 is obsolete| | Attachment #120501|0 |1 is obsolete| | Attachment #120502|0 |1 is obsolete| | Attachment #120503|0 |1 is obsolete| | Attachment #120504|0 |1 is obsolete| | Attachment #120505|0 |1 is obsolete| | Attachment #120506|0 |1 is obsolete| | Attachment #120507|0 |1 is obsolete| | Attachment #120508|0 |1 is obsolete| | Attachment #120509|0 |1 is obsolete| | Attachment #120510|0 |1 is obsolete| | Attachment #120511|0 |1 is obsolete| | Attachment #120512|0 |1 is obsolete| | Attachment #120513|0 |1 is obsolete| | Attachment #120514|0 |1 is obsolete| | Attachment #120515|0 |1 is obsolete| | Attachment #120516|0 |1 is obsolete| | Attachment #120517|0 |1 is obsolete| | Attachment #120518|0 |1 is obsolete| | --- Comment #295 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122808&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #296 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122809&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #297 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122810&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #298 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122811&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #299 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122812&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #300 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122813&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #301 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122814&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #302 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122815&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #303 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122816&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #304 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122817&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #305 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122818&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #306 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122819&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #307 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122820&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #308 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122821&action=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #309 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122822&action=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #310 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122823&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #311 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122824&action=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #312 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122825&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #313 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122826&action=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #314 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122827&action=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #315 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122828&action=edit Bug 24857: (QA follow-up) Add volume to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #316 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122829&action=edit Bug 24857: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #317 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122830&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #318 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122831&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20447 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 [Bug 28871] Koha::Objects->empty doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122810|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122811|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122812|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122813|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122814|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122815|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122816|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122818|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122822|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122827|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122828|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122830|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #319 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123882&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #320 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123883&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #321 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123884&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #322 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123885&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #323 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123886&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #324 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123887&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #325 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123888&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #326 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123889&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #327 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123890&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #328 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123891&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #329 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123892&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #330 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123893&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #331 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123894&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #332 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123895&action=edit Bug 24857: Fix license statements Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #333 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123896&action=edit Bug 24857: Fix POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #334 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123897&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #335 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123898&action=edit Bug 24857: Fix simple-quote string Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #336 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123899&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #337 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123900&action=edit Bug 24857: Fix sorting of new syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #338 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123901&action=edit Bug 24857: Change button text from "Create new" to "New volume" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #339 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123902&action=edit Bug 24857: (QA follow-up) Add volume to table settings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #340 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123903&action=edit Bug 24857: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #341 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123904&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #342 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123905&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #343 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123906&action=edit Bug 24857: (QA follow-up) Fix QA script issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #344 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123907&action=edit Bug 24857: (follow-up) Use $c->unhandled_exception This patch makes the controller up to date with the currently used style and codebase. It also sinlences a useless warning, and makes it return 404 (instead of 409) when trying to add items to a volume on a non-existing biblio. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Some warnings 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors, no warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #345 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123908&action=edit Bug 24857: Use $c->objects->find Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #346 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123909&action=edit Bug 24857: Fix permissions in spec This patch corrects the spec so it requires the right permissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #347 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123910&action=edit Bug 24857: (QA follow-up) Adding items should check volume linked to biblio I noticed some tests included /biblios/{biblio_id}/volumes... in the URL. And they passed :-D This means the biblio_id is never tested. This patch fixes those two tests so they have valid biblio_id in the path, and adds a proper regression test for the expected behavior (409). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Notice the tests pass, even with bad data on the request 2. Apply this patch, notice a test is added for the bad biblio_id case and the other two tests are fixed so they have the intended biblio_id. 3. Repeat 1 => SUCCESS: Tests pass! This means things are correctly tested in the controller and the unit tests cover teh 'bad case' returning 409. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #348 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123912&action=edit Bug 24857: (QA follow-up) Further spec fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123907|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123885|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123890|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123893|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123895|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123896|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123897|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123898|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123899|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123901|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123902|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #349 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124021&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #350 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124022&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #351 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124023&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #352 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124024&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #353 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124025&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #354 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124026&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #355 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124027&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #356 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124028&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #357 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124029&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #358 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124030&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #359 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124031&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #360 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124032&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #361 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124033&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #362 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124034&action=edit Bug 24857: Fix license statements Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #363 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124035&action=edit Bug 24857: Fix POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #364 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124036&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #365 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124037&action=edit Bug 24857: Fix simple-quote string Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #366 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124038&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #367 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124039&action=edit Bug 24857: Fix sorting of new syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #368 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124040&action=edit Bug 24857: Change button text from "Create new" to "New volume" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #369 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124041&action=edit Bug 24857: (QA follow-up) Add volume to table settings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #370 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124042&action=edit Bug 24857: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #371 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124043&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #372 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124044&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #373 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124045&action=edit Bug 24857: (QA follow-up) Fix QA script issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #374 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124046&action=edit Bug 24857: (follow-up) Use $c->unhandled_exception This patch makes the controller up to date with the currently used style and codebase. It also sinlences a useless warning, and makes it return 404 (instead of 409) when trying to add items to a volume on a non-existing biblio. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Some warnings 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors, no warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #375 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124047&action=edit Bug 24857: Use $c->objects->find Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #376 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124048&action=edit Bug 24857: Fix permissions in spec This patch corrects the spec so it requires the right permissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #377 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124049&action=edit Bug 24857: (QA follow-up) Adding items should check volume linked to biblio I noticed some tests included /biblios/{biblio_id}/volumes... in the URL. And they passed :-D This means the biblio_id is never tested. This patch fixes those two tests so they have valid biblio_id in the path, and adds a proper regression test for the expected behavior (409). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Notice the tests pass, even with bad data on the request 2. Apply this patch, notice a test is added for the bad biblio_id case and the other two tests are fixed so they have the intended biblio_id. 3. Repeat 1 => SUCCESS: Tests pass! This means things are correctly tested in the controller and the unit tests cover teh 'bad case' returning 409. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #378 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124050&action=edit Bug 24857: (QA follow-up) Further spec fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #379 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124051&action=edit Bug 24857: Rename Volumes => Item groups (DB) This patch renames Volumes => Item groups in the DB structure, and also on permissions and sysprefs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #380 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124052&action=edit Bug 24857: Adapt code to the volumes => item_groups change This patch updates the code so all references to 'volumes' are translated into 'item groups'. Relevant changes: - API routes and specs - Permission name is changed - Syspref name changed Note: I removed a behavior that felt unnatural (at least in the place it was put): deleting the item group if the linked item is deleted. It feels like a controller thing, and also something that could be offered to the staff on the UI on item deletion. To avoid blocking the feature, I suggest this removal, and discuss it in its own context. To test: 1. Run: $ reset_all 2. Apply this patchset 3. Run: $ updatedatabase => SUCCESS: Update works 4. Repeat 1 (with the patches applied) => SUCCESS: Install works with this DB structure 5. Run all the tests: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 6. Follow the original plan (with the Volume=>ItemGRoup change in mind) => SUCCESS: All good! 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #381 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124053&action=edit Bug 24857: item_group_items.item_id must be unique -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to create |Add ability to group items |"Volumes" for records, and |for records |assign items to volumes | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #382 from David Cook <dcook@prosentient.com.au> --- I'm really glad to see Volume change to Item Group, because we've had a number of times when we've wanted to have Item Group holds where library staff could group together items. I haven't looked through the code in a long time. Is it just for holds or does it handle aspects of circulation too like checkouts? That's just a question and by no means a comment on the patches. Just curious. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #383 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #382)
I'm really glad to see Volume change to Item Group, because we've had a number of times when we've wanted to have Item Group holds where library staff could group together items.
I haven't looked through the code in a long time. Is it just for holds or does it handle aspects of circulation too like checkouts? That's just a question and by no means a comment on the patches. Just curious.
This code implements the groups. There's a separate bug that implements hold fulfillment by group items. That one will need some changes after the refactoring we made. It would be great if you could go QA this one so we can build the rest on top of this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #384 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #383)
This code implements the groups. There's a separate bug that implements hold fulfillment by group items. That one will need some changes after the refactoring we made.
It would be great if you could go QA this one so we can build the rest on top of this.
With 33 patches, I think this might make it on the TODO list that I just feel guilty about and never action :(. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #385 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #384)
(In reply to Tomás Cohen Arazi from comment #383)
This code implements the groups. There's a separate bug that implements hold fulfillment by group items. That one will need some changes after the refactoring we made.
It would be great if you could go QA this one so we can build the rest on top of this.
With 33 patches, I think this might make it on the TODO list that I just feel guilty about and never action :(.
If you apply them, and do a git diff, things are pretty clear and simple. I hesitated to squash everything because it wasn't my dev. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28854 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #386 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #385)
(In reply to David Cook from comment #384)
(In reply to Tomás Cohen Arazi from comment #383)
This code implements the groups. There's a separate bug that implements hold fulfillment by group items. That one will need some changes after the refactoring we made.
It would be great if you could go QA this one so we can build the rest on top of this.
With 33 patches, I think this might make it on the TODO list that I just feel guilty about and never action :(.
If you apply them, and do a git diff, things are pretty clear and simple.
That takes a fair number of steps (starting up koha-testing-docker is very slow these days due to db setup), and it isn't easy to comment via Bugzilla when the changes are spread out across a large number of overlapping patches.
I hesitated to squash everything because it wasn't my dev.
Yeah that makes sense. I wasn't suggesting that someone should. I'm just super time poor for Koha these days. -- Mostly it's just me making excuses not to do things :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124035|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124036|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124038|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124039|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124043|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124052|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124022|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124025|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124027|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124029|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124031|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #387 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124331&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #388 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124332&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #389 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124333&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #390 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124334&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #391 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124335&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #392 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124336&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #393 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124337&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #394 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124338&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #395 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124339&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #396 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124340&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #397 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124341&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #398 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124342&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #399 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124343&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #400 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124344&action=edit Bug 24857: Fix license statements Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #401 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124345&action=edit Bug 24857: Fix POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #402 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124346&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #403 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124347&action=edit Bug 24857: Fix simple-quote string Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #404 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124348&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #405 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124349&action=edit Bug 24857: Fix sorting of new syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #406 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124351&action=edit Bug 24857: Change button text from "Create new" to "New volume" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #407 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124352&action=edit Bug 24857: (QA follow-up) Add volume to table settings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #408 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124353&action=edit Bug 24857: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #409 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124354&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #410 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124355&action=edit Bug 24857: (QA follow-up) Fix QA script issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #411 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124356&action=edit Bug 24857: (follow-up) Use $c->unhandled_exception This patch makes the controller up to date with the currently used style and codebase. It also sinlences a useless warning, and makes it return 404 (instead of 409) when trying to add items to a volume on a non-existing biblio. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Some warnings 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors, no warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #412 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124357&action=edit Bug 24857: Use $c->objects->find Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #413 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124358&action=edit Bug 24857: Fix permissions in spec This patch corrects the spec so it requires the right permissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #414 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124359&action=edit Bug 24857: (QA follow-up) Adding items should check volume linked to biblio I noticed some tests included /biblios/{biblio_id}/volumes... in the URL. And they passed :-D This means the biblio_id is never tested. This patch fixes those two tests so they have valid biblio_id in the path, and adds a proper regression test for the expected behavior (409). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Notice the tests pass, even with bad data on the request 2. Apply this patch, notice a test is added for the bad biblio_id case and the other two tests are fixed so they have the intended biblio_id. 3. Repeat 1 => SUCCESS: Tests pass! This means things are correctly tested in the controller and the unit tests cover teh 'bad case' returning 409. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #415 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124360&action=edit Bug 24857: (QA follow-up) Further spec fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #416 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124361&action=edit Bug 24857: Rename Volumes => Item groups (DB) This patch renames Volumes => Item groups in the DB structure, and also on permissions and sysprefs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #417 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124362&action=edit Bug 24857: Adapt code to the volumes => item_groups change This patch updates the code so all references to 'volumes' are translated into 'item groups'. Relevant changes: - API routes and specs - Permission name is changed - Syspref name changed Note: I removed a behavior that felt unnatural (at least in the place it was put): deleting the item group if the linked item is deleted. It feels like a controller thing, and also something that could be offered to the staff on the UI on item deletion. To avoid blocking the feature, I suggest this removal, and discuss it in its own context. To test: 1. Run: $ reset_all 2. Apply this patchset 3. Run: $ updatedatabase => SUCCESS: Update works 4. Repeat 1 (with the patches applied) => SUCCESS: Install works with this DB structure 5. Run all the tests: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 6. Follow the original plan (with the Volume=>ItemGRoup change in mind) => SUCCESS: All good! 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #418 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124363&action=edit Bug 24857: item_group_items.item_id must be unique -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #419 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124421&action=edit Bug 24857: (QA follow-up) Fix for missing Scalar context Template Toolkit will generally assume list context and so we get the wrong result when chaning relationships. We must force scalar context using the Scalar plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #420 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I presume it's deliberate to not expose any of this on the OPAC at all at this time? That comes with the holds work etc? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #421 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I probably would have used the rowGroup plugin for DataTables to visually group the grouped items.. but that can be done in a followup bug maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28883 | --- Comment #422 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Removing dependency on bug 28883 as it is only relevant for the tests (not) using ->as_list. And is not fair for this bug to be blocked by it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124421|0 |1 is obsolete| | --- Comment #423 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124463&action=edit Bug 24857: Do not depend on bug 28883 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124331|0 |1 is obsolete| | --- Comment #424 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124583&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124332|0 |1 is obsolete| | --- Comment #425 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124584&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124333|0 |1 is obsolete| | --- Comment #426 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124585&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124334|0 |1 is obsolete| | --- Comment #427 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124586&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124335|0 |1 is obsolete| | --- Comment #428 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124587&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124336|0 |1 is obsolete| | --- Comment #429 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124588&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124337|0 |1 is obsolete| | --- Comment #430 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124589&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124338|0 |1 is obsolete| | --- Comment #431 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124590&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124339|0 |1 is obsolete| | --- Comment #432 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124591&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124340|0 |1 is obsolete| | --- Comment #433 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124592&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124341|0 |1 is obsolete| | --- Comment #434 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124593&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124342|0 |1 is obsolete| | --- Comment #435 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124594&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124343|0 |1 is obsolete| | --- Comment #436 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124595&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124344|0 |1 is obsolete| | --- Comment #437 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124596&action=edit Bug 24857: Fix license statements Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124345|0 |1 is obsolete| | --- Comment #438 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124597&action=edit Bug 24857: Fix POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124346|0 |1 is obsolete| | --- Comment #439 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124598&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124347|0 |1 is obsolete| | --- Comment #440 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124599&action=edit Bug 24857: Fix simple-quote string Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124348|0 |1 is obsolete| | --- Comment #441 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124600&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124349|0 |1 is obsolete| | --- Comment #442 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124601&action=edit Bug 24857: Fix sorting of new syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124351|0 |1 is obsolete| | --- Comment #443 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124602&action=edit Bug 24857: Change button text from "Create new" to "New volume" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124352|0 |1 is obsolete| | --- Comment #444 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124603&action=edit Bug 24857: (QA follow-up) Add volume to table settings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124353|0 |1 is obsolete| | --- Comment #445 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124604&action=edit Bug 24857: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124354|0 |1 is obsolete| | --- Comment #446 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124605&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124355|0 |1 is obsolete| | --- Comment #447 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124606&action=edit Bug 24857: (QA follow-up) Fix QA script issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124356|0 |1 is obsolete| | --- Comment #448 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124607&action=edit Bug 24857: (follow-up) Use $c->unhandled_exception This patch makes the controller up to date with the currently used style and codebase. It also sinlences a useless warning, and makes it return 404 (instead of 409) when trying to add items to a volume on a non-existing biblio. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Some warnings 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors, no warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124357|0 |1 is obsolete| | --- Comment #449 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124608&action=edit Bug 24857: Use $c->objects->find Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124358|0 |1 is obsolete| | --- Comment #450 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124609&action=edit Bug 24857: Fix permissions in spec This patch corrects the spec so it requires the right permissions. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124359|0 |1 is obsolete| | --- Comment #451 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124610&action=edit Bug 24857: (QA follow-up) Adding items should check volume linked to biblio I noticed some tests included /biblios/{biblio_id}/volumes... in the URL. And they passed :-D This means the biblio_id is never tested. This patch fixes those two tests so they have valid biblio_id in the path, and adds a proper regression test for the expected behavior (409). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Notice the tests pass, even with bad data on the request 2. Apply this patch, notice a test is added for the bad biblio_id case and the other two tests are fixed so they have the intended biblio_id. 3. Repeat 1 => SUCCESS: Tests pass! This means things are correctly tested in the controller and the unit tests cover teh 'bad case' returning 409. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124360|0 |1 is obsolete| | --- Comment #452 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124611&action=edit Bug 24857: (QA follow-up) Further spec fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124361|0 |1 is obsolete| | --- Comment #453 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124612&action=edit Bug 24857: Rename Volumes => Item groups (DB) This patch renames Volumes => Item groups in the DB structure, and also on permissions and sysprefs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124362|0 |1 is obsolete| | --- Comment #454 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124613&action=edit Bug 24857: Adapt code to the volumes => item_groups change This patch updates the code so all references to 'volumes' are translated into 'item groups'. Relevant changes: - API routes and specs - Permission name is changed - Syspref name changed Note: I removed a behavior that felt unnatural (at least in the place it was put): deleting the item group if the linked item is deleted. It feels like a controller thing, and also something that could be offered to the staff on the UI on item deletion. To avoid blocking the feature, I suggest this removal, and discuss it in its own context. To test: 1. Run: $ reset_all 2. Apply this patchset 3. Run: $ updatedatabase => SUCCESS: Update works 4. Repeat 1 (with the patches applied) => SUCCESS: Install works with this DB structure 5. Run all the tests: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 6. Follow the original plan (with the Volume=>ItemGRoup change in mind) => SUCCESS: All good! 7. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124363|0 |1 is obsolete| | --- Comment #455 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124614&action=edit Bug 24857: item_group_items.item_id must be unique Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124463|0 |1 is obsolete| | --- Comment #456 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124615&action=edit Bug 24857: Do not depend on bug 28883 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #457 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That was quite a QA effort.. all works as expected, though I'm sure some future polishing of the UI is likely to take place down the line. Tests pass, QA script is happy and functionality works Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi --- Comment #458 from Ere Maijala <ere.maijala@helsinki.fi> --- Just to raise awareness: It seems to me that this overlaps the holdings record functionality in bug 20447 quite significantly while providing some that the holdings support doesn't yet. While I've not really familiarized myself with what grouped items provide (is there an RFC or other documentation somewhere?), I don't think it makes much sense to have two different methods for grouping items in a bib record. Since this one has already passed QA I assume this one will get merged soon enough, and that means that the future of bug 20447 (to which many people have invested quite a bit, me included) needs to be reconsidered. I wish I had known about this development much sooner. If anyone has further thoughts, I'd welcome discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart+koha@gmail. | |com --- Comment #459 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- A discussion needs to take place on the status of the different bug reports offering the same or alternative to this patch set. Bug 24023 - Add ability to create bundles of items Bug 20447 - Add support for MARC holdings records Bug 28854 - [ALTERNATIVE] Add ability to create bundles of items It's not clear to me and I won't have time to spend on this huge task before the release. Bug 20447 has been part of the roadmap for the 2 last dev cycles and it would be weird to make this one passed before the "MARC holdings records" if they conflict with each other. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|In Discussion |Passed QA --- Comment #460 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #459)
A discussion needs to take place on the status of the different bug reports offering the same or alternative to this patch set.
Bug 24023 - Add ability to create bundles of items Bug 20447 - Add support for MARC holdings records Bug 28854 - [ALTERNATIVE] Add ability to create bundles of items
It's not clear to me and I won't have time to spend on this huge task before the release. Bug 20447 has been part of the roadmap for the 2 last dev cycles and it would be weird to make this one passed before the "MARC holdings records" if they conflict with each other.
While these patch sets all have similar functions, I don't believe they are contradictory: This bug creates groups for holds functionality, i.e. holds one any of a 'volume' set - it is a logical grouping only Bug 24023/28854 are 'bundles' for circulation purposes Bug 20447 is tied to MARC import/export While there may be some overlap, I think these are discrete enough to operate independently - a library would likely only want to implement either 'groups' or 'holdings' and I believe they can stand alone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #461 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- No discussion but wait for another RM. Ok, if you want, that's a technique... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Bug 24857 depends on bug 28871, which changed state. Bug 28871 Summary: Koha::Objects->empty doesn't work correctly in list context https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28871 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 [Bug 28871] Koha::Objects->empty doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #462 from Fridolin Somers <fridolin.somers@biblibre.com> --- What a complex situation. This also linked to Bug 15516 - Allow to place a hold on first available item from a group of titles And maybe a bit to Bug 15565 - Place multiple item-level holds at once for the same record Holds system is already really complex, we must be careful what we add in it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15565 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124583|0 |1 is obsolete| | Attachment #124584|0 |1 is obsolete| | Attachment #124585|0 |1 is obsolete| | Attachment #124586|0 |1 is obsolete| | Attachment #124587|0 |1 is obsolete| | Attachment #124588|0 |1 is obsolete| | Attachment #124589|0 |1 is obsolete| | Attachment #124590|0 |1 is obsolete| | Attachment #124591|0 |1 is obsolete| | Attachment #124592|0 |1 is obsolete| | Attachment #124593|0 |1 is obsolete| | Attachment #124594|0 |1 is obsolete| | Attachment #124595|0 |1 is obsolete| | Attachment #124596|0 |1 is obsolete| | Attachment #124597|0 |1 is obsolete| | Attachment #124598|0 |1 is obsolete| | Attachment #124599|0 |1 is obsolete| | Attachment #124600|0 |1 is obsolete| | Attachment #124601|0 |1 is obsolete| | Attachment #124602|0 |1 is obsolete| | Attachment #124603|0 |1 is obsolete| | Attachment #124604|0 |1 is obsolete| | Attachment #124605|0 |1 is obsolete| | Attachment #124606|0 |1 is obsolete| | Attachment #124607|0 |1 is obsolete| | Attachment #124608|0 |1 is obsolete| | Attachment #124609|0 |1 is obsolete| | Attachment #124610|0 |1 is obsolete| | Attachment #124611|0 |1 is obsolete| | Attachment #124612|0 |1 is obsolete| | Attachment #124613|0 |1 is obsolete| | Attachment #124614|0 |1 is obsolete| | Attachment #124615|0 |1 is obsolete| | --- Comment #463 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131449&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #464 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131450&action=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #465 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131451&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #466 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131452&action=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #467 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131453&action=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #468 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131454&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #469 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131455&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #470 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131456&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #471 from Nick Clemens <nick@bywatersolutions.com> --- Patches rebased and squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131449|0 |1 is obsolete| | Attachment #131450|0 |1 is obsolete| | Attachment #131451|0 |1 is obsolete| | Attachment #131452|0 |1 is obsolete| | Attachment #131453|0 |1 is obsolete| | Attachment #131454|0 |1 is obsolete| | Attachment #131455|0 |1 is obsolete| | Attachment #131456|0 |1 is obsolete| | --- Comment #472 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134288&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #473 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134289&action=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #474 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134290&action=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #475 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134291&action=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #476 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134292&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #477 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134293&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #478 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134294&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #479 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134295&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #480 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134296&action=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #481 from Fridolin Somers <fridolin.somers@biblibre.com> --- I don't understand enough this feature and its links with other features. So I've chosen to pass it to next Release Manager. Great work ByWaters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134288|0 |1 is obsolete| | Attachment #134289|0 |1 is obsolete| | Attachment #134290|0 |1 is obsolete| | Attachment #134291|0 |1 is obsolete| | Attachment #134292|0 |1 is obsolete| | Attachment #134293|0 |1 is obsolete| | Attachment #134294|0 |1 is obsolete| | Attachment #134295|0 |1 is obsolete| | Attachment #134296|0 |1 is obsolete| | --- Comment #482 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135590&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135590|0 |1 is obsolete| | --- Comment #483 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135591&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #484 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135592&action=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #485 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135593&action=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #486 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135594&action=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #487 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135595&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #488 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135596&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #489 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135597&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #490 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135598&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #491 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135599&action=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #492 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135600&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135591|0 |1 is obsolete| | Attachment #135592|0 |1 is obsolete| | Attachment #135593|0 |1 is obsolete| | Attachment #135594|0 |1 is obsolete| | Attachment #135595|0 |1 is obsolete| | Attachment #135596|0 |1 is obsolete| | Attachment #135597|0 |1 is obsolete| | Attachment #135598|0 |1 is obsolete| | Attachment #135599|0 |1 is obsolete| | Attachment #135600|0 |1 is obsolete| | --- Comment #493 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135601&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission https://bugs.koha-community.org/show_bug.cgi?id=24860 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #494 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135602&action=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #495 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135603&action=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #496 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135604&action=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #497 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135605&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #498 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135606&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #499 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135607&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #500 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135608&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #501 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135609&action=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #502 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135610&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135601|0 |1 is obsolete| | Attachment #135602|0 |1 is obsolete| | Attachment #135603|0 |1 is obsolete| | Attachment #135604|0 |1 is obsolete| | Attachment #135605|0 |1 is obsolete| | Attachment #135606|0 |1 is obsolete| | Attachment #135607|0 |1 is obsolete| | Attachment #135608|0 |1 is obsolete| | Attachment #135609|0 |1 is obsolete| | Attachment #135610|0 |1 is obsolete| | --- Comment #503 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135614&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission https://bugs.koha-community.org/show_bug.cgi?id=24860 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #504 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135615&action=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #505 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135616&action=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #506 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135617&action=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #507 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135618&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #508 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135619&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #509 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135620&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #510 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135621&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #511 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135622&action=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #512 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135623&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135618|0 |1 is obsolete| | Attachment #135619|0 |1 is obsolete| | Attachment #135620|0 |1 is obsolete| | Attachment #135621|0 |1 is obsolete| | Attachment #135622|0 |1 is obsolete| | Attachment #135623|0 |1 is obsolete| | --- Comment #513 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135624&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #514 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135625&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #515 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135626&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #516 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135627&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #517 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135628&action=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #518 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135629&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135614|0 |1 is obsolete| | Attachment #135615|0 |1 is obsolete| | Attachment #135616|0 |1 is obsolete| | Attachment #135617|0 |1 is obsolete| | Attachment #135624|0 |1 is obsolete| | Attachment #135625|0 |1 is obsolete| | Attachment #135626|0 |1 is obsolete| | Attachment #135627|0 |1 is obsolete| | Attachment #135628|0 |1 is obsolete| | Attachment #135629|0 |1 is obsolete| | --- Comment #519 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137259&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission https://bugs.koha-community.org/show_bug.cgi?id=24860 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #520 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137260&action=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #521 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137261&action=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #522 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137262&action=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #523 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137263&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #524 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137264&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #525 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137265&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #526 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137266&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #527 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137267&action=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #528 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137268&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #529 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137311&action=edit Bug 24857: Fix rebase problems Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137259|0 |1 is obsolete| | Attachment #137260|0 |1 is obsolete| | Attachment #137261|0 |1 is obsolete| | Attachment #137262|0 |1 is obsolete| | Attachment #137263|0 |1 is obsolete| | Attachment #137264|0 |1 is obsolete| | Attachment #137265|0 |1 is obsolete| | Attachment #137266|0 |1 is obsolete| | Attachment #137267|0 |1 is obsolete| | Attachment #137268|0 |1 is obsolete| | Attachment #137311|0 |1 is obsolete| | --- Comment #530 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137314&action=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission https://bugs.koha-community.org/show_bug.cgi?id=24860 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #531 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137315&action=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #532 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137316&action=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #533 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137317&action=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #534 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137318&action=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #535 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137319&action=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #536 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137320&action=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #537 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137321&action=edit Bug 24857: Add new Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #538 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137322&action=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #539 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137323&action=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #540 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #541 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137441&action=edit Bug 24857: (QA follow-up) Make update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #542 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137442&action=edit Bug 24857: Fix missing additionalProperties in spec Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #543 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137443&action=edit Bug 24857: Remove incorrect object_class method Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 [Bug 31133] TestBuilder fragile on virtual fks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #544 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137608&action=edit Bug 24857: Remove object_class from singular classes Fixes Can't use string ("Koha::Biblio::ItemGroup") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line 830. Can't use string ("Koha::Biblio::ItemGroup::Item") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line 830. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31140 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140 [Bug 31140] TestBuilder.t is failing on item groups modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #545 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138933&action=edit Bug 24857: (QA follow-up) Add spec description Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com Text to go in the| |This feature allows for release notes| |libraries to group items | |within a record. A new | |system preference has been | |added for this feature, | |EnableItemGroups. This | |system preference once | |enabled will allow the | |library to group specific | |items on a record to each | |other. A library can name | |the group and add items | |from the same record to | |this group. From the | |record, a new tab will | |appear and display on that | |item if it is part of a | |group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #546 from Lucas Gass <lucas@bywatersolutions.com> --- No backport for 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31460 [Bug 31460] Merging item groups loses groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This feature allows for |This feature allows for release notes|libraries to group items |libraries to group items |within a record. A new |within a record. A new |system preference has been |system preference has been |added for this feature, |added for this feature, |EnableItemGroups. This |EnableItemGroups. This |system preference once |system preference, once |enabled will allow the |enabled, will allow the |library to group specific |library to group specific |items on a record to each |items on a record to each |other. A library can name |other. A library can name |the group and add items |the group and add items |from the same record to |from the same record to |this group. From the |this group. From the |record, a new tab will |record, a new tab will |appear and display on that |appear and display on that |item if it is part of a |item if it is part of a |group. |group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 [Bug 32353] items.item_group_id should be undefined in tests by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/609 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This feature allows for |This feature was sponsored release notes|libraries to group items |by Arlington Public |within a record. A new |Library. This feature |system preference has been |allows for libraries to |added for this feature, |group items within a |EnableItemGroups. This |record. A new system |system preference, once |preference has been added |enabled, will allow the |for this feature, |library to group specific |EnableItemGroups. This |items on a record to each |system preference, once |other. A library can name |enabled, will allow the |the group and add items |library to group specific |from the same record to |items on a record to each |this group. From the |other. A library can name |record, a new tab will |the group and add items |appear and display on that |from the same record to |item if it is part of a |this group. From the |group. |record, a new tab will | |appear and display on that | |item if it is part of a | |group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640 [Bug 33640] Adding new item group from item additem.pl does nothing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 [Bug 33639] Adding item to item group from 'Add item' screen doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33672 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 [Bug 35124] Incorrect item groups table markup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 [Bug 34520] Database update 22.06.00.078 breaks update process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 [Bug 34234] Item groups dropdown in detail page modal does not respect display order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 [Bug 35754] Place multiple item-group holds at once for the same record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35754 | --- Comment #547 from David Cook <dcook@prosentient.com.au> --- I'm starting to look at this and it looks like a similar idea to bug 15516 except that it's the library creating the group rather than the patron. I wonder if bug 15516 could be re-implemented as a item_group. Maybe we could add a column to differentiate between staff-added and user-added item groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 [Bug 35754] Place multiple item-group holds at once for the same record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #548 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #547)
I'm starting to look at this and it looks like a similar idea to bug 15516 except that it's the library creating the group rather than the patron.
I wonder if bug 15516 could be re-implemented as a item_group. Maybe we could add a column to differentiate between staff-added and user-added item groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see...
There is another major different: item groups group items from the same record. The point of 15526 I think is creating groups with items from different records (I don't care if I get the movie, the paperback, the hardcover...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #549 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #548)
(In reply to David Cook from comment #547)
I'm starting to look at this and it looks like a similar idea to bug 15516 except that it's the library creating the group rather than the patron.
I wonder if bug 15516 could be re-implemented as a item_group. Maybe we could add a column to differentiate between staff-added and user-added item groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see...
There is another major different: item groups group items from the same record. The point of 15526 I think is creating groups with items from different records (I don't care if I get the movie, the paperback, the hardcover...)
Hmm that could be. It's been a while since I looked at a live implementation or the code. I'll be looking at it very shortly so I guess I'll see! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 [Bug 35754] Place multiple item-group holds at once for the same record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #550 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #548)
There is another major different: item groups group items from the same record. The point of 15526 I think is creating groups with items from different records (I don't care if I get the movie, the paperback, the hardcover...)
I've just finished rebasing and doing some testing... With bug 15516 alone, it creates hold groups using record-level or item-level holds from different records. However, when bug 15516 and bug 15565 are combined, then you can do hold groups for items within the same bib record as well. For now, on Bugzilla, I'm trying to keep the two bug reports separate. Locally, I join them together. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 [Bug 37686] render_resource_not_found() and render_resource_deleted() misses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #551 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks like this feature has not really adjusted the holds to pull form. The available item count, call numbers, etc do not reflect the item groups. The data shown on HTP more resembles biblio level holds instead of item group level holds. Will open a new report. The fact that we can (potentially) have biblio level holds, item level holds and item group level holds together makes holds to pull a bit of a mess? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40979 [Bug 40979] Item group level holds are not shown correctly on Holds to pull -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org