https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #377 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124049&action=edit Bug 24857: (QA follow-up) Adding items should check volume linked to biblio I noticed some tests included /biblios/{biblio_id}/volumes... in the URL. And they passed :-D This means the biblio_id is never tested. This patch fixes those two tests so they have valid biblio_id in the path, and adds a proper regression test for the expected behavior (409). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Notice the tests pass, even with bad data on the request 2. Apply this patch, notice a test is added for the bad biblio_id case and the other two tests are fixed so they have the intended biblio_id. 3. Repeat 1 => SUCCESS: Tests pass! This means things are correctly tested in the controller and the unit tests cover teh 'bad case' returning 409. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.