http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11750&action=edit Proposed patch Proposed patch adds a lot of corrections in tags edition in OPAC. Affects search results, basket, list and detail pages. I tried to uniform the code on those pages. Main correction : On search results / basket / list page, when adding tag on several records, a status appears on each selected record line. I used a border and yellow background. When clicking on button to end tag edition, the status of all records is initialized. Concerning sysprefs, they where missing in some places. I used TagsShowOnDetail and TagsInputOnDetail for detail page and TagsShowOnList and TagsInputOnList for other pages. In basket, the toolbar was existing twice in TT (for basket witt or without details). The code was the same so I moved it to be unique. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #2)

I really like the improvements in this patch, but I also have a complaint: Whitespace changes in otherwise unchanged lines makes it difficult to track what is really different and what isn't. I would prefer that whitespace-only changes be submitted in a separate patch if they're really desirable.

I agree, speaking as a release maintainer, separate patches make my life (and anyone ever doing code maintenance in the future) a lot easier. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #2)

I see only one glitch in functionality that needs to be addressed:

If I choose some items (in results, the cart, or a list) and add a tag, I see the "tag added" message by each one. If I then select some different items on that same list and add another tag, the "tag added" message on the original selection doesn't disappear altogether, it just loses its text, leaving an empty yellow box behind.

It's not a big issue, but I would like to see a revision before I sign off. Thanks!

Your right, corrected in new patch (a span with border-radius must be hidden when empty) Thanks a lot for testing. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11767|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11786&action=edit [SIGNED-OFF] Bug 8660: Tag status does not show on multiple tag add Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * patch signed-off since more than 1 month, QAing it myself * template only changes, low side effect risk * koha-qa.pl is OK: ../qa/koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to commit 813c744) * 8b19523 Bug 8660: Tag status does not show on multiple tag add koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc koha-tmpl/opac-tmpl/prog/en/js/tags.js koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt - koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc OK forbidden patterns OK tt_valid OK valid_template OK - koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt OK forbidden patterns OK tt_valid OK valid_template OK - koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt OK forbidden patterns OK tt_valid OK valid_template OK - koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt OK forbidden patterns OK tt_valid OK valid_template OK - koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt OK forbidden patterns OK tt_valid OK valid_template OK - koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt OK forbidden patterns OK tt_valid OK valid_template OK * some css added to opac/prog, I added them in opac/ccsr as well Testing the feature (using the CCSR theme) * when I add tag to multiple biblios, I see the status on each line * when I add a tag to a given biblio, from the biblio list, It does not work anymore= clicking on "Add" does nothing (no message, no change, no javascript error) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11786|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12905&action=edit Proposed patch (rebased master) Main patch rebased -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #12)

Created attachment 13168 [details] Bug 8660: follow-up: Porting changes to cssr theme

Signed-off-by: Mason James <mtj@kohaaloha.com>

i tested this patch with the CSSR theme, it works well :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Great and clean patch. Note: I did not test the CCSR theme. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|3.12 |3.10 --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8660 --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply to 3.8.x if it could be rebased and signed off then yep :) -- You are receiving this mail because: You are watching all bug changes.