[Bug 7161] New: Open Library - Larger image, Read, borrow and checked-out status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Bug #: 7161 Summary: Open Library - Larger image, Read, borrow and checked-out status Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: savitra.sirohi@osslabs.biz QAContact: ian.walls@bywatersolutions.com Modified Open Library JS to: 1. Use jscmd=data instead of default, this provides ebooks availability information. This will allow us to display read/borrow/checkedout icons 2. Show larger image in opac-detail page 3. Show read/borrow/checked-out status in opac-detail page below the image -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Savitra Sirohi <savitra.sirohi@osslabs.biz> 2011-11-05 06:35:25 UTC --- *** Bug 6672 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #2 from Amit Gupta <amit.gupta@osslabs.biz> 2011-11-05 08:28:07 UTC --- Created attachment 6221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6221 Open Library - Larger image, Read, borrow and checked-out status -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |amit.gupta@osslabs.biz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6221|0 |1 is patch| | Attachment #6221|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> 2011-11-05 10:57:54 UTC --- Created attachment 6227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6227 Bug-7161 Open Library - Larger image, Read, borrow and checked-out status To test: 1. go into system administration and search for "cover" 2. change "OpenLibraryCovers" to "add" and all other to "don't show" 3. verify that opac search results have small covers, while detail page has big ones 4. (optional) find book which is available for reading (and not borrowed!) on Open Library and change ISBN on one of your books to test Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6221|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |m.de.rooy@rijksmuseum.nl Version|unspecified |master AssignedTo|oleonard@myacpl.org |amit.gupta@osslabs.biz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-12 10:59:59 UTC --- QA Comments: Thanks for your work. Could you clarify/modify please following points: I did not find an example on short notice for ebooks with availability information/icon. There is a new function keys; but I couldn't see a call for it. Same for get_cover; only call is in comments. Some further questions on the code: A console debug message is still present. A regex call before creating Preview div has been eliminated; the reason for doing that is not made clear in this report. Can imagine that is was not really needed. A variable a is filled with element a and modified href. But later on an element a is manually appended with yet another book.url. Not clear? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2012-02-10 12:13:19 UTC --- I'd like to see the larger open library images in 3.8 - should this patch be broken in to parts so that such a simple fix can be pushed while the other parts are worked on? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9865&action=edit Bug-7161 Open Library - Larger image, Read, borrow and checked-out status To test: 1. go into system administration and search for "cover" 2. change "OpenLibraryCovers" to "add" and all other to "don't show" 3. verify that opac search results have small covers, while detail page has big ones Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Addressing M. de Rooy's concerns * remove console.log * removed some comments that looked like debug code? * remove ebook display - I couldn't get it to work properly, and we want the bigger images. So it's gone. * remove get_cover -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6227|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9865|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9873&action=edit Bug-7161 Open Library - Larger image, Read, borrow and checked-out status To test: 1. go into system administration and search for "cover" 2. change "OpenLibraryCovers" to "add" and all other to "don't show" 3. verify that opac search results have small covers, while detail page has big ones Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Addressing M. de Rooy's concerns * remove console.log * removed some comments that looked like debug code? * remove ebook display - I couldn't get it to work properly, and we want the bigger images. So it's gone. * remove get_cover Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Marcel, you already made a 1st QA, so I let this one for you. Looking at the code I don't see anything wrong -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_10 |master QA Contact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #8)
Marcel, you already made a 1st QA, so I let this one for you. Looking at the code I don't see anything wrong
Will be looking at this shortly.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10539&action=edit Patch for 7161 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> June 27, 2012: Removing unused function keys from openlibrary.js. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9873|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10540&action=edit Followup for 7161 Only whitespace changes to fix indentation after tab removal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Earlier comments have been implemented. Did some minor corrections myself on unused function and whitespace. Marking as Passed QA now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11312&action=edit tini tiny cover on search results My bug was marked a duplicate of this - but this didn't fix my my bug which was that the open library images are too small to see on the search results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- The images on the search results for open library are still pretty tiny - can we update those to be somewhere between the size that's there now and the size that's on the detail page? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9660 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #15 from Nicole C. Engard <nengard@gmail.com> --- Bug 9660 addresses the search results issue. Nicole -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org