[Bug 10647] New: OPAC MARC plain view only working for MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Bug ID: 10647 Summary: OPAC MARC plain view only working for MARC21 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 9570 introduced the MARC flavor for OPAC MARC plain view, which was using MARC21slim2OPACMARCdetail.xsl. The bug is that there are no files for UNIMARC and NORMARC flavors in actual sources. Seems like MARC21slim2OPACMARCdetail.xsl has nothing specific to MARC21 flavor. Should there be copies of MARC21slim2OPACMARCdetail.xsl named UNIMARCslim2OPACMARCdetail.xsl and NORMARCslim2OPACMARCdetail.xsl ? Or should this XSLT not depend on MARC flavor like before ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9570 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Fridolyn SOMERS from comment #0)
Seems like MARC21slim2OPACMARCdetail.xsl has nothing specific to MARC21 flavor.
I agree.
Should there be copies of MARC21slim2OPACMARCdetail.xsl named UNIMARCslim2OPACMARCdetail.xsl and NORMARCslim2OPACMARCdetail.xsl ? Or should this XSLT not depend on MARC flavor like before ?
I think for this one the XSLT should not depend on the MARC flavor, unless somebody can point to examples where the convention for display plain tagged views of a MARC record are different for the UNIMARC community. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- I can confirm this bug. Clicking on the "view plain" link gives a Ajaxy "spinning wheel" and a "Loading..." message for a second or two, then a yellow warning saying "Sorry, plain view is temporarily unavailable." I get this in the opac-error.log: opac-showmarc.pl: Could not create file parser context for file "/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/xslt/NORMARCslim2OPACMARCdetail.xsl": No such file or directory at /usr/share/koha/opac/cgi-bin/opac/opac-showmarc.pl line 80, referer: http://kurs.demo.bibkat.no/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=18 ...which seems to confirm that a missing XSLT file is the culprit. And I'm also seeing a ton of 500 errors in my Apache logs (from bots) for pages like this: /cgi-bin/koha/opac-showmarc.pl?id=10611&viewas=html ...which is what that Ajax call is trying to fetch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 25929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25929&action=edit Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC On "MARC view" in the OPAC, clicking on "Plain view" does not work for UNIMARC and NORMARC. To test: - Make sure you have a UNIMARC or NORMARC setup - Go to the "MARC view" of a record in the OPAC - Click on "view plain" and observe the "Sorry, plain view is temporarily unavailable." error message - Apply the patch - Click on "view plain" and observe that a plain view of the MARC record is now displayed - Sign off I have only tested this on NORMARC, it might be good if someone can test on UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC MARC plain view only |Make OPAC MARC plain view |working for MARC21 |work for all flavours of | |MARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25929|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 25931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25931&action=edit Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC On "MARC view" in the OPAC, clicking on "Plain view" does not work for UNIMARC and NORMARC. To test: - Make sure you have a UNIMARC or NORMARC setup and OPACXSLTDetailsDisplay not empty - Go to the "MARC view" of a record in the OPAC - Click on "view plain" and observe the "Sorry, plain view is temporarily unavailable." error message - Apply the patch - Click on "view plain" and observe that a plain view of the MARC record is now displayed - Sign off I have only tested this on NORMARC, it might be good if someone can test on UNIMARC. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Signed and added "OPACXSLTDetailsDisplay not empty" in test plan. Very old and ugly bug, thanks Magnus :D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Good idea. The patch works for bootstrap by the grace of the fallback in opac-showmarc. You do only rename the file in prog. You should do the same for bootstrap. But I personally do not really like the idea of renaming this one file from MARC21 to MARC. It is still listed very close to the MARC21 files. [1] We could rename it more rigorously like plainMARC.xsl or something? [2] Or we could leave the file as-is and create a file for UNIMARC and NORMARC just with an xsl:import? Something like: <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> <xsl:stylesheet version="1.0" xmlns:marc="http://www.loc.gov/MARC21/slim" xmlns:xsl="http://www.w3.org/1999/XSL/Transform"> <xsl:import href="MARC21slim2OPACMARCdetail.xsl"/> </xsl:stylesheet> Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25931|0 |1 is obsolete| | --- Comment #7 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 26310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26310&action=edit Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC On "MARC view" in the OPAC, clicking on "Plain view" does not work for UNIMARC and NORMARC. To test: - Make sure you have a UNIMARC or NORMARC setup - Go to the "MARC view" of a record in the OPAC - Click on "view plain" and observe the "Sorry, plain view is temporarily unavailable." error message - Apply the patch - Click on "view plain" and observe that a plain view of the MARC record is now displayed - Sign off I have only tested this on NORMARC, it might be good if someone can test on UNIMARC. Updated 2014-03-13: Incoroprates changes suggested by Marcel. Test plan is the same as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26310|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26323&action=edit [SIGNED OFF] Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC On "MARC view" in the OPAC, clicking on "Plain view" does not work for UNIMARC and NORMARC. To test: - Make sure you have a UNIMARC or NORMARC setup - Go to the "MARC view" of a record in the OPAC - Click on "view plain" and observe the "Sorry, plain view is temporarily unavailable." error message - Apply the patch - Click on "view plain" and observe that a plain view of the MARC record is now displayed - Sign off I have only tested this on NORMARC, it might be good if someone can test on UNIMARC. Updated 2014-03-13: Incoroprates changes suggested by Marcel. Test plan is the same as before. Updated 2014-03-13: Tested in my UNIMARC system. toggled opactheme to all three values, with OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay both set to default. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26323|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26338&action=edit [PASSED QA] Bug 10647 - Make OPAC MARC plain view work for all flavours of MARC On "MARC view" in the OPAC, clicking on "Plain view" does not work for UNIMARC and NORMARC. To test: - Make sure you have a UNIMARC or NORMARC setup - Go to the "MARC view" of a record in the OPAC - Click on "view plain" and observe the "Sorry, plain view is temporarily unavailable." error message - Apply the patch - Click on "view plain" and observe that a plain view of the MARC record is now displayed - Sign off I have only tested this on NORMARC, it might be good if someone can test on UNIMARC. Updated 2014-03-13: Incoroprates changes suggested by Marcel. Test plan is the same as before. Updated 2014-03-13: Tested in my UNIMARC system. toggled opactheme to all three values, with OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay both set to default. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with MARC21 and UNIMARC, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org