[Bug 11127] New: OPAC suggestion: the delete link is active when no suggestion selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Bug ID: 11127 Summary: OPAC suggestion: the delete link is active when no suggestion selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22349&action=edit Bug 11127: OPAC suggestion: the delete link is active when no suggestion selected To reproduce: 1/ go on opac-suggestions.pl 2/ create a suggestion 3/ click on the delete link without checking any checkbox The form is submitted with a message "The selected suggestions have been deleted.". Test plan: 1/ after applying the patch, click on delete without any checkbox checked, a js alert should occur. 2/ check at least a cb and click on the delete link. The deletion should work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Should I produce the same fix for others themes (bootstrap and ccsr)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11090 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Instead of adding the "disabled" attribute to an element which isn't really supposed to have it (according to the specification) I think it would be better to check for the existence of a checked checkbox: var checkedBoxes = $("input:checked"); if ($(checkedBoxes).size() == 0) { alert(MSG_NO_RECORD_SELECTED); return false; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: If there are still suggestions, there is also the Delete selected button below. If you click on that button without a selection, it still says: Selected sugg have been deleted. For consistency, I would recommend adjusting that too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, Why are there 2 ways to delete selected suggestions? Should not we keep only the button on the bottom? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- ping Owen -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #6)
ping Owen
Sorry, here I am! (In reply to Jonathan Druart from comment #5)
Why are there 2 ways to delete selected suggestions? Should not we keep only the button on the bottom?
I don't see any reason not to offer both options. We do the same on the lists page and the on the user account page with renewal options. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22349|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25818&action=edit Bug 11127: OPAC suggestion: the delete link is active when no suggestion selected To reproduce: 1/ go on opac-suggestions.pl 2/ create a suggestion 3/ click on the delete link without checking any checkbox The form is submitted with a message "The selected suggestions have been deleted.". Test plan: 0/ enable the bootstrap theme 1/ after applying the patch, click on delete without any checkbox checked, a js alert should occur. 2/ check at least a cb and click on the delete link. The deletion should work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 25823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25823&action=edit [Signed-off] Bug 11127: OPAC suggestion: the delete link is active when no suggestion selected To reproduce: 1/ go on opac-suggestions.pl 2/ create a suggestion 3/ click on the delete link without checking any checkbox The form is submitted with a message "The selected suggestions have been deleted.". Test plan: 0/ enable the bootstrap theme 1/ after applying the patch, click on delete without any checkbox checked, a js alert should occur. 2/ check at least a cb and click on the delete link. The deletion should work. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25818|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I like the idea and it works nicely :) The only thing I am a bit concerned about is reusing the message from the cart. I think right now they are always in the template even if the cart is turned off, but that might change at some point. Also the message might read a bit nicer as "No suggestion has been selected" - as item is also a bit confusing for translations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26073&action=edit Bug 11127: Define a specific message for suggestion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, the alert doesn't come up for me now and I can't see the new message in the template. Maybe we could just add the string directly into the alert? There seems to be an example for this a bit below. I think the MSG.* mostly exist because the Javascript for those is in a separate .js file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- The alert isn't coming up now because the MSG is defined in the prog include, but the template is only modified for the bootstrap theme. I would probably just put the MSG definition in the template itself since it's only relevant to that one page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26073|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26120&action=edit Bug 11127: Define a specific message for suggestion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #13)
The alert isn't coming up now because the MSG is defined in the prog include, but the template is only modified for the bootstrap theme.
Arg stupid mistake, sorry Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I am sorry, but after takig a look at the code, I think we need to move the line with the message out of the IF statement, or it will depend on cart and lists being turned on: [% IF Koha.Preference( 'opacbookbag' ) == 1 or Koha.Preference( 'virtualshelves' ) == 1 %] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26120|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26168&action=edit Bug 11127: Define a specific message for suggestion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26168|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 26307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26307&action=edit [SIGNED OFF] Bug 11127: Define a specific message for suggestion Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26308&action=edit [PASSED QA] Bug 11127: OPAC suggestion: the delete link is active when no suggestion selected To reproduce: 1/ go on opac-suggestions.pl 2/ create a suggestion 3/ click on the delete link without checking any checkbox The form is submitted with a message "The selected suggestions have been deleted.". Test plan: 0/ enable the bootstrap theme 1/ after applying the patch, click on delete without any checkbox checked, a js alert should occur. 2/ check at least a cb and click on the delete link. The deletion should work. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26309&action=edit [PASSED QA] Bug 11127: Define a specific message for suggestion Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m Component|OPAC |Test Suite Assignee|jonathan.druart@biblibre.co |nicolas.legrand@bulac.fr |m | Summary|OPAC suggestion: the delete |Replace given by if-else in |link is active when no |Circulation_issuingrules.t |suggestion selected | QA Contact|testopia@bugs.koha-communit |gmcharlt@gmail.com |y.org | Severity|normal |trivial --- Comment #22 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace given by if-else in |OPAC suggestion: the delete |Circulation_issuingrules.t |link is active when no | |suggestion selected --- Comment #23 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Oups, the title of this bug was the one of Bug 11934 : "Replace given by if-else statements" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Test Suite |OPAC Assignee|nicolas.legrand@bulac.fr |jonathan.druart@biblibre.co | |m QA Contact|gmcharlt@gmail.com |testopia@bugs.koha-communit | |y.org Severity|trivial |normal --- Comment #24 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Sorry, I've add a odd behavior with my Lazarus Plugin. I restore this bug from history. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org