http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11191&action=edit Proposed patch I found the problem : In some cases, the XSLT generates an empty a tag : <a href="..." /> This brakes the page. The concerned code is the building of subjects. Correction : ------------ Subject field with authority code ($9) : if the content of <a> is empty (= $display variable), it is set with the $9 value. Subject field without authority code ($9) : added a test on $a not empty, to avoid the same problem. Test plan : ----------- Bug appears on a record with a subject field (ie 606) containing a $9 as last subfield. Check also a record with a subject field containing some fields but not $9 nor $a. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11191|0 |1 is obsolete| | --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11378&action=edit Proposed patch (all MARC) Added same control on 'm880Select' template used in MARC21 and NORMARC. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)

Created attachment 11478 [details] Bug 8513: OPAC detail page broken with XSLT

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

patch looks good and applies, passing QA fyi: we need to add some xsl, xml and javascript tests to the Koha qa-tools... :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- prove t/00-valid-xml.t t/00-valid-xml.t .. ok All tests successful. Files=1, Tests=94, 5 wallclock secs ( 0.10 usr 0.01 sys + 0.47 cusr 0.68 csys = 1.26 CPU) Result: PASS Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Paul is there a bug for the staff side? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8615 -- You are receiving this mail because: You are watching all bug changes.