[Bug 11499] New: zebra_setup.pl not correctly setting indexing mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Bug ID: 11499 Summary: zebra_setup.pl not correctly setting indexing mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com Bibliographic and authorities indexing mode is set in several places, including the koha-conf.xml file. The latter is not being properly set by the zebra_setup.pl helper script. I figured this when writing my patches for bug 11096 when I noticed i was getting USMARC data when I shouldn't. To reproduce: - Run the attached regression test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24014&action=edit Bug 11499 - (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24015&action=edit Bug 11499 - Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11096 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24014|0 |1 is obsolete| | Attachment #24015|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 24021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24021&action=edit Bug 11499: (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 The test should fail unless the main page is applied. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 24022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24022&action=edit Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24021|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24122&action=edit Bug 11499: (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 The test should fail unless the main page is applied. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24022|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24123&action=edit Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes unit test, koha-qa.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11499 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org