http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 19952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19952&action=edit Bug 10646: mod_rewrite should be enabled by the postinst script This patch makes the post install scripts used by the .deb packages enable the mod_rewrite module (which is mandatory if you want to run Koha). It tests the module isn't already enabled, and enables if necesary, and reloads Apache configuration. To test: - Install current koha-common packages on a fresh setup. Make sure you have mod_rewrite disabled (its the default if you didn't have apache and it was just pulled by koha-common at least on Ubuntu 12.04). Run $ a2dismod rewrite to make sure it is disabled on your test box. Create a new koha instance like this: $ koha-create --create-db name You'll get an error like this: Syntax error on line 76 of /etc/koha/apache-shared.conf: Invalid command 'RewriteEngine', perhaps misspelled or defined by a module not included in the server configuration Action 'configtest' failed. The Apache error log may have more information. ...fail! , build your own packages, make sure you have mod_rewrite disabled (which is the default on Ubuntu 12.04 at least), and install the package. Create a new instance issuing: - Apply the patch, build your packages, repeat: No apache warning about the rewrite module. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to Robin Sheat from comment #3)

I don't think that we should change system configuration like this. What happens if it breaks something else on the system?

I'd rather koha-create aborts with an error, or something like that.

I disagree. I think we'll have already broken whatever else could be broken by an Apache configuration change. We've already clobbered the heck out of whatever Apache configuration the user had before by uninstalling the user's existing Apache MPM (probably prefork or worker with Apache 2.2 and I guess event with Apache 2.4) and installing itk in its place, so we might as well just make Koha work at that point. That said, I don't have a particularly strong feeling that this is necessary, since the error message it pretty self-explanatory, I just think the horse has already left the barn. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Jared Camins-Esakov from comment #4)

I disagree. I think we'll have already broken whatever else could be broken by an Apache configuration change. We've already clobbered the heck out of whatever Apache configuration the user had before by uninstalling the user's existing Apache MPM (probably prefork or worker with Apache 2.2 and I guess

That's all voluntary however, warnings are given. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19969|0 |1 is obsolete| | --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 23013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23013&action=edit Bug 10646 - warn if mod_rewrite is not enabled Koha requires mod_rewrite. If it's not enabled in Apache, then koha-create will now abort with a helpful error message. Also adds a warning when not run as root to avoid confusing errors. Test plan: * apply the patch * a2dismod rewrite * run koha-create without sudo, note the error about being root * run koha-create with sudo, note the error about rewrite * a2enmod rewrute * repeat test above, note that it works -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- I'm going to pass QA on this because I wrote it, Tomás tested it, and it's packaging related :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Mirko Tietgen from comment #2)

This patch makes the post install scripts used by the .deb packages enable the mod_rewrite module (which is mandatory if you want to run Koha). The mod_rewrite module is not mandatory anymore in Apache configuration (etc/koha-httpd.conf) since Bug 9683. Why is it different when using packaged version ?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #12 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Fridolin SOMERS from comment #11)

The mod_rewrite module is not mandatory anymore in Apache configuration (etc/koha-httpd.conf) since Bug 9683. Why is it different when using packaged version ?

In both the opac and the staff client, the following rewrite rules are applied: RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) RewriteRule (.+) $1?%1%2 [N,R,NE] RewriteRule ^/bib/([^\/]*)/?$ /cgi-bin/koha/detail\.pl?bib=$1 [PT] RewriteRule ^/isbn/([^\/]*)/?$ /search?q=isbn:$1 [PT] RewriteRule ^/issn/([^\/]*)/?$ /search?q=issn:$1 [PT] I'm not sure if they're ever useful (from looking at bug 9683, I suspect not.) We could make them conditional, or we could drop them totally. I don't really mind either way. -- You are receiving this mail because: You are watching all bug changes.

(In reply to Fridolin SOMERS from comment #11)

...

The mod_rewrite module is not mandatory anymore in Apache configuration (etc/koha-httpd.conf) since Bug 9683. Why is it different when using packaged version ?

In both the opac and the staff client, the following rewrite rules are applied:

RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) RewriteRule (.+) $1?%1%2 [N,R,NE] RewriteRule ^/bib/([^\/]*)/?$ /cgi-bin/koha/detail\.pl?bib=$1 [PT] RewriteRule ^/isbn/([^\/]*)/?$ /search?q=isbn:$1 [PT] RewriteRule ^/issn/([^\/]*)/?$ /search?q=issn:$1 [PT]

I'm not sure if they're ever useful (from looking at bug 9683, I suspect not.) We could make them conditional, or we could drop them totally. I don't really mind either way. Yes but Bug 9683 added a <IfModule mod_rewrite.c> around those lines. It means

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #14 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Robin Sheat from comment #12) that those lines are not active is mod_rewrite if not enabled. In my opinion, very few libs are using those rules. But it can be kept has examples. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.4. -- You are receiving this mail because: You are watching all bug changes.