[Bug 5448] New: Boolean.pm's interface could be cleaned up
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 Summary: Boolean.pm's interface could be cleaned up Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 There seems to have been a bit of cargo cult programming going on in Boolean.pm. It also exports a routine that is not used (what it does export true_p is only used by C4::Context. Generates warnings because having ascertained its input is undefined it then attempts to manipulate it. The testscript for Boolean.pm has a handcrafted approach that makes it a bit obscure to see what its changing. Before refactoring Boolean.pm move test script to using Test::More for more clarity -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-11-26 17:31:31 UTC --- Created attachment 2791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2791 Patch to Testscript -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-11-26 17:32:38 UTC --- Created attachment 2792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2792 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Patch Pushed --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-01 19:53:02 UTC --- Patches pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 --- Comment #4 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-13 12:16:50 UTC --- This bug is mentioned in: Bug 5448 Use Test::More in Boolean.t http://lists.koha-community.org/pipermail/koha-patches/2010-November/013109.... Bug 5448: Refactor Boolean.pm http://lists.koha-community.org/pipermail/koha-patches/2010-November/013110.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org