http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5448 Summary: Boolean.pm's interface could be cleaned up Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 There seems to have been a bit of cargo cult programming going on in Boolean.pm. It also exports a routine that is not used (what it does export true_p is only used by C4::Context. Generates warnings because having ascertained its input is undefined it then attempts to manipulate it. The testscript for Boolean.pm has a handcrafted approach that makes it a bit obscure to see what its changing. Before refactoring Boolean.pm move test script to using Test::More for more clarity -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.