[Bug 35239] New: Missing form field ids in batch patron modification template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Bug ID: 35239 Summary: Missing form field ids in batch patron modification template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy, accessibility Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Tools -> Batch patron modification -> Modifications (after submitting a batch of patrons): The edit form already has valid labels but not all the form fields have matching ids. There is also a markup error, a missing "=" in this tag: <input type"hidden" name="patron_attributes_value" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Koha Training Catalyst <koha-training@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 --- Comment #1 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 169627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169627&action=edit Bug 35239: Missing form field ids in batch patron modification template Test Plan 1. Tools > Batch patron modification 2. List valid card number in text box 3. [Continue] 4. Edit patrons form, click on input box label 5. Matching input box gets focus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169627|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169774&action=edit Bug 35239: Missing form field ids in batch patron modification template Test Plan 1. Tools > Batch patron modification 2. List valid card number in text box 3. [Continue] 4. Edit patrons form, click on input box label 5. Matching input box gets focus Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169775&action=edit Bug 35239: (follow-up) Correct more missing label inconsistencies This patch corrects a couple more labels and modifies the process of cloning a patron attribute field so that each new cloned row has matching label and input. To test, apply the patch and, if necessary, create some patron attribute types: - Go to Administration -> Patron attribute types - Create at least two new patron attribute types. - Go to Tools -> Batch patron modification. - Submit a batch of patrons for batch modification - In the list of fields to modify, test that clicking each label gives focus to the corresponding field (except date fields, we need to fix that globally). - Click "New" next to the patron attribute field. - A copy of the field should be created. Test that the new field also has matching label and <select> Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169774|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 169797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169797&action=edit Bug 35239: Missing form field ids in batch patron modification template Test Plan 1. Tools > Batch patron modification 2. List valid card number in text box 3. [Continue] 4. Edit patrons form, click on input box label 5. Matching input box gets focus Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169775|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 169798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169798&action=edit Bug 35239: (follow-up) Correct more missing label inconsistencies This patch corrects a couple more labels and modifies the process of cloning a patron attribute field so that each new cloned row has matching label and input. To test, apply the patch and, if necessary, create some patron attribute types: - Go to Administration -> Patron attribute types - Create at least two new patron attribute types. - Go to Tools -> Batch patron modification. - Submit a batch of patrons for batch modification - In the list of fields to modify, test that clicking each label gives focus to the corresponding field (except date fields, we need to fix that globally). - Click "New" next to the patron attribute field. - A copy of the field should be created. Test that the new field also has matching label and <select> Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the batch patron release notes| |modification edit form | |labels so that they all | |have IDs, and the input box | |now receives the focus when | |clicking on the label (this | |includes patron attribute | |fields, but excludes date | |fields). This is an | |accesibility improvement. | |Before this, you had to | |click in the input box to | |add a value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the batch patron |This fixes the batch patron release notes|modification edit form |modification edit form |labels so that they all |labels so that they all |have IDs, and the input box |have IDs, and the input box |now receives the focus when |now receive the focus when |clicking on the label (this |clicking on the label (this |includes patron attribute |includes patron attribute |fields, but excludes date |fields, but excludes date |fields). This is an |fields). This is an |accesibility improvement. |accessibility improvement. |Before this, you had to |Before this, you had to |click in the input box to |click in the input box to |add a value. |add a value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA'd by RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org