[Bug 35257] New: Only admin start page uses "circulation desks"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Bug ID: 35257 Summary: Only admin start page uses "circulation desks" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the sidebar and on the desk admin page, we only use "Desks". The administration start page seems to be the only place that uses the term "circulation desk". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 167594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167594&action=edit Bug 35257: Change 'Circulation desks' to 'Desks' The administration page is the only page that uses "Circulation desks" for navigation elements. All other areas (sidebar menu, breadcrumbs, adding and editing desks, page titles) all use just "Desks". This updates the Koha administration page to use "desks" for consistency. It also updates the UseCirculationDesks system preference description. Test plan: 1. Enable the UseCirculationDesks system preference. 2. Go to Koha administration > Patrons and circulation 3. Select the Circulation desks option. 4. Note that the sidebar menu, breadcrumbs, and page titles all use just "Desks". 5. Note that in the top-right hand menu bar that it says "NO DESK SET". If you click the dropdown menu it says "Set library and desk". 6. Apply the patch. 7. Go to Koha administartion > Patrons and circulation. 8. Note that the heading now says just "Desks". 9. Note that the description for the UseCirculationDesks system preference is now "Don't use/Use circulation desks". 10. Sign off D: Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | Keywords| |Sandbox CC| |david@davidnind.com Text to go in the| |This changes the Koha release notes| |administration page title | |for "Circulation desks" to | |"Desks" for consistency - | |all other areas such as the | |sidebar, page titles, and | |breadcrumbs all use just | |"Desks". It also updates | |the UseCirculationDesks | |system preference | |description. Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167594|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167654&action=edit Bug 35257: Change 'Circulation desks' to 'Desks' The administration page is the only page that uses "Circulation desks" for navigation elements. All other areas (sidebar menu, breadcrumbs, adding and editing desks, page titles) all use just "Desks". This updates the Koha administration page to use "desks" for consistency. It also updates the UseCirculationDesks system preference description. Test plan: 1. Enable the UseCirculationDesks system preference. 2. Go to Koha administration > Patrons and circulation 3. Select the Circulation desks option. 4. Note that the sidebar menu, breadcrumbs, and page titles all use just "Desks". 5. Note that in the top-right hand menu bar that it says "NO DESK SET". If you click the dropdown menu it says "Set library and desk". 6. Apply the patch. 7. Go to Koha administartion > Patrons and circulation. 8. Note that the heading now says just "Desks". 9. Note that the description for the UseCirculationDesks system preference is now "Don't use/Use circulation desks". 10. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- $ git grep "circulation desk" Shows a few more occurrences of this. Don't know if intentional or not, just fyi. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #3)
$ git grep "circulation desk"
Shows a few more occurrences of this. Don't know if intentional or not, just fyi.
I did notice that. However, I just concentrated on the navigation insistencies. Happy to look at other occurrences if you have any suggestions. The bigger question I guess is are there desks other than just for circulation, and how this feature is expected to be used. But I don't work in a library, so I'm not really sure what is accepted practice (if there is any...). If it is made more generic, as just desks, then I think it should be changed elsewhere where appropriate, and circulation desks used as an example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167654|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168089&action=edit Bug 35257: Change 'Circulation desks' to 'Desks' The administration page is the only page that uses "Circulation desks" for navigation elements. All other areas (sidebar menu, breadcrumbs, adding and editing desks, page titles) all use just "Desks". This updates the Koha administration page to use "desks" for consistency. It also updates the UseCirculationDesks system preference description. Test plan: 1. Enable the UseCirculationDesks system preference. 2. Go to Koha administration > Patrons and circulation 3. Select the Circulation desks option. 4. Note that the sidebar menu, breadcrumbs, and page titles all use just "Desks". 5. Note that in the top-right hand menu bar that it says "NO DESK SET". If you click the dropdown menu it says "Set library and desk". 6. Apply the patch. 7. Go to Koha administartion > Patrons and circulation. 8. Note that the heading now says just "Desks". 9. Note that the description for the UseCirculationDesks system preference is now "Don't use/Use circulation desks". 10. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Patch complexity|Trivial patch |String patch Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 This is string patch ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org