[Bug 37846] New: Serial prediction pattern test appears at the bottom of the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Bug ID: 37846 Summary: Serial prediction pattern test appears at the bottom of the page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I'm not sure if this is intended or simply a consequence of the bootstrap upgrade... To recreate: 1. Go to Serials > New subscription 2. Enter a record number in the form (e.g. 55) 3. Click Next (and confirm there is no vendor) 4. Enter values for - First issue publication date - Frequency - Subscription length - Subscription start date - Numbering pattern - Numbering "Begins with" 5. Click Test prediction pattern --> The prediction appears at the bottom of the page. In version 24.05, it appeared on the right side of the screen. Personally, I don't mind so much that it's underneath instead of on the side, but I would at least put the buttons under the prediction section. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171134&action=edit Bug 37846: Fix serial prediction pattern layout This patch corrects the class which is added to the serial prediction pattern in order for it to display as a second column in the subscription edit page. "col-xs-*" classes no longer exist in Bootstrap 5. To test, apply the patch and go to Serials. 1. Click "New subscription" 2. Enter a record number in the form (e.g. 55) 3. Click "Next" (and confirm there is no vendor) 4. Enter values for - First issue publication date - Frequency - Subscription length - Subscription start date - Numbering pattern - Numbering "Begins with" 5. Click "Test prediction pattern" - The prediction pattern panel should appear as a second column on the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171134|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 171166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171166&action=edit Bug 37846: Fix serial prediction pattern layout This patch corrects the class which is added to the serial prediction pattern in order for it to display as a second column in the subscription edit page. "col-xs-*" classes no longer exist in Bootstrap 5. To test, apply the patch and go to Serials. 1. Click "New subscription" 2. Enter a record number in the form (e.g. 55) 3. Click "Next" (and confirm there is no vendor) 4. Enter values for - First issue publication date - Frequency - Subscription length - Subscription start date - Numbering pattern - Numbering "Begins with" 5. Click "Test prediction pattern" - The prediction pattern panel should appear as a second column on the page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Text to go in the| |This fixes the test release notes| |prediction pattern when | |adding a new subscription | |for a serial - the | |prediction pattern was | |appearing at the bottom of | |the page, instead of in a | |column to the right. (This | |is related to the OPAC and | |staff interface Bootstrap 5 | |upgrade in Koha 24.11.) CC| |david@davidnind.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- This code seems very fragile! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171166|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171177&action=edit Bug 37846: Fix serial prediction pattern layout This patch corrects the class which is added to the serial prediction pattern in order for it to display as a second column in the subscription edit page. "col-xs-*" classes no longer exist in Bootstrap 5. To test, apply the patch and go to Serials. 1. Click "New subscription" 2. Enter a record number in the form (e.g. 55) 3. Click "Next" (and confirm there is no vendor) 4. Enter values for - First issue publication date - Frequency - Subscription length - Subscription start date - Numbering pattern - Numbering "Begins with" 5. Click "Test prediction pattern" - The prediction pattern panel should appear as a second column on the page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37846 Bug 37846 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org