[Bug 36273] New: ILL - Refactor $op in ill-requests.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Bug ID: 36273 Summary: ILL - Refactor $op in ill-requests.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: pedro.amorim@ptfs-europe.com Depends on: 36241, 36243, 36245, 36249 With bug 34478, presenting a form page should be a GET request without 'cud-' in the op URL parameter. Additionally, a form that creates, updates or deletes some object should be a POST with the 'cud-' prefix. ill-requests.pl did not do this distinction originally, and still doesn't. It instead works around 'cud-' in the $op to preserve existing functionality. It should be refactored to better distinguish between a GET $op and a POST $op. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36241 [Bug 36241] ILL Batches are broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36243 [Bug 36243] ILL "Edit request" action is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36245 [Bug 36245] ILL - Custom backend form action is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36249 [Bug 36249] ILL - "Request from partners" action is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Bug 36273 depends on bug 36241, which changed state. Bug 36241 Summary: ILL Batches are broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36241 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Bug 36273 depends on bug 36243, which changed state. Bug 36243 Summary: ILL "Edit request" action is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36243 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Bug 36273 depends on bug 36249, which changed state. Bug 36249 Summary: ILL - "Request from partners" action is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36249 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Bug 36273 depends on bug 36245, which changed state. Bug 36245 Summary: ILL - Custom backend form action is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36245 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176794&action=edit Bug 36273: OPAC: WIP This is working, currently built on top of bug 36197 as that was the development that brought this issue to light. Refreshing the following URL with unauthenticatedOPACILLRequest enabled would always create a new ILL request. http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?method=create&stage=form&backend=Standard&type=article&branchcode=CPL&unauthenticated_first_name=Pedro%20Jorge&unauthenticated_last_name=Andrade%20Amorim&unauthenticated_email=pedro.amorim@ptfs-europe.com This patch gets rid of using the get_op_param_deprecation method in the OPAC controller. This creates the needed distinction between 'create' op (show the form) and 'cud-create' op (handle POST form submission) More testing is required. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40652 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36273 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- unauthenticatedOPACILLRequest is no longer a issue since it enforces a captcha. But a security problem still exists. See bug 40652. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org