[Bug 9667] New: Inventory scrolling to top with every click
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Bug ID: 9667 Summary: Inventory scrolling to top with every click Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: nengard@gmail.com I was wondering if there is a way to keep the list from scrolling all the way back to the top if I click on the link to the item? If I have to set what is in the list to missing, it is a pain to have scroll down to where I was after clicking each item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Bruce Metcalf <bugzilla@augustansociety.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@augustansociety.co | |m --- Comment #1 from Bruce Metcalf <bugzilla@augustansociety.com> --- Workaround that works in 3.6: go back one page in browser to return to original position on inventory list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still happens in current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29676&action=edit Bug 9667 - Inventory scrolling to top with every click An "onclick" attribute on inventory results links causes the page to scroll to the top each time. This patch updates the click handling to use a progressive-enhancement method. Unrelated changes: I added use of the Branches T:T plugin to output library name instead of branchcode, and put a check around call number to prevent output of empty [] in results. To test, use the inventory tool to check a batch of items. On the results page: - Confirm that branch name is shown instead of code. - Confirm that no [] shows for items without call numbers - Confirm that clicking a title opens a pop-up window showing details for that title. - Confirm that clicking a title opens a pop-up window whether you're on the first page of results or any subsequent page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia@hotmail.com --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Inventory is still scrolling to top after clicking on the link to an item and branch code is still being shown rather than branch name, so failing QA. However the pop-up window does open showing details when clicked on on any page, and [] shows for items without call numbers, so these work as they should. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Thanks for testing Aleshia, but I'm not sure why it's not working for you. Everything works for me. Perhaps someone else could take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Ian Beardslee <ibeardslee@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ibeardslee@gmail.com --- Comment #6 from Ian Beardslee <ibeardslee@gmail.com> --- Created attachment 30052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30052&action=edit Signed patch All good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Ian Beardslee <ibeardslee@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Ian Beardslee <ibeardslee@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29676|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30052|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30082&action=edit Bug 9667 - Inventory scrolling to top with every click An "onclick" attribute on inventory results links causes the page to scroll to the top each time. This patch updates the click handling to use a progressive-enhancement method. Unrelated changes: I added use of the Branches T:T plugin to output library name instead of branchcode, and put a check around call number to prevent output of empty [] in results. To test, use the inventory tool to check a batch of items. On the results page: - Confirm that branch name is shown instead of code. - Confirm that no [] shows for items without call numbers - Confirm that clicking a title opens a pop-up window showing details for that title. - Confirm that clicking a title opens a pop-up window whether you're on the first page of results or any subsequent page. Signed-off-by: Ian Beardslee <ian@catalyst.net.nz> Tested in Firefox and Chromium. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org